From: Sachin Kamat <spk.linux@gmail.com>
To: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
Cc: linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
linux-i2c@vger.kernel.org,
Naveen Krishna <naveenkrishna.ch@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
sjg@chromium.org, open list <linux-kernel@vger.kernel.org>,
Wolfram Sang <wsa@the-dreams.de>,
cpgs@samsung.com, broonie@kernel.org
Subject: Re: [PATCH 2/2] i2c: exynos5: fix minor styling nits
Date: Wed, 25 Jun 2014 16:19:32 +0530 [thread overview]
Message-ID: <CAK5sBcEVHYQutEm9Lh3eGX8_6zKLV-m3XfYKtnfPs8CBExpHqg@mail.gmail.com> (raw)
In-Reply-To: <1403692697-7381-2-git-send-email-ch.naveen@samsung.com>
Hi Naveen,
On Wed, Jun 25, 2014 at 4:08 PM, Naveen Krishna Chatradhi
<ch.naveen@samsung.com> wrote:
> This patch removes an extra line and fixes a styling nit
> in exynos5_i2c_message_start()
>
> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
> ---
> drivers/i2c/busses/i2c-exynos5.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-exynos5.c b/drivers/i2c/busses/i2c-exynos5.c
> index 0d1a7bc..4c2e6f3 100644
> --- a/drivers/i2c/busses/i2c-exynos5.c
> +++ b/drivers/i2c/busses/i2c-exynos5.c
> @@ -525,7 +525,7 @@ static void exynos5_i2c_message_start(struct exynos5_i2c *i2c, int stop)
> if (i2c->msg->flags & I2C_M_RD) {
> i2c_ctl |= HSI2C_RXCHON;
>
> - i2c_auto_conf = HSI2C_READ_WRITE;
> + i2c_auto_conf |= HSI2C_READ_WRITE;
This change looks more than just a styling nit. Please update the commit message
accordingly.
--
Regards,
Sachin.
next prev parent reply other threads:[~2014-06-25 10:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 10:38 [PATCH 1/2] i2c: exynos5: remove an unnecessary read of FIFO_STATUS register Naveen Krishna Chatradhi
2014-06-25 10:38 ` [PATCH 2/2] i2c: exynos5: fix minor styling nits Naveen Krishna Chatradhi
2014-06-25 10:49 ` Sachin Kamat [this message]
2014-06-26 4:58 ` Naveen Krishna Ch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK5sBcEVHYQutEm9Lh3eGX8_6zKLV-m3XfYKtnfPs8CBExpHqg@mail.gmail.com \
--to=spk.linux@gmail.com \
--cc=broonie@kernel.org \
--cc=ch.naveen@samsung.com \
--cc=cpgs@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=naveenkrishna.ch@gmail.com \
--cc=sjg@chromium.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).