From: Bryan Wu <cooloney@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Alexandre Courbot <gnurou@gmail.com>,
Richard Purdie <rpurdie@rpsys.net>, Arnd Bergmann <arnd@arndb.de>,
Jacek Anaszewski <j.anaszewski@samsung.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] gpiolib: Add missing dummies for the unified device properties interface
Date: Tue, 12 May 2015 10:48:28 -0700 [thread overview]
Message-ID: <CAK5ve-+9jtPMYdYmicJDRwiUcb8g5XD0h-G88RULY3GX6skZmQ@mail.gmail.com> (raw)
In-Reply-To: <CACRpkdbsOvOpx8ctm2h2ZCQefpa-dB-fWOfObm4BSCG8xcupow@mail.gmail.com>
On Tue, May 12, 2015 at 3:31 AM, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Thu, May 7, 2015 at 10:08 AM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
>
>> If GPIOLIB=n:
>>
>> drivers/leds/leds-gpio.c: In function ‘gpio_leds_create’:
>> drivers/leds/leds-gpio.c:187: error: implicit declaration of function ‘devm_get_gpiod_from_child’
>> drivers/leds/leds-gpio.c:187: warning: assignment makes pointer from integer without a cast
>>
>> Add dummies for fwnode_get_named_gpiod() and devm_get_gpiod_from_child()
>> for the !GPIOLIB case to fix this.
>>
>> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>> Fixes: 40b7318319281b1b ("gpio: Support for unified device properties interface")
>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>
> Counting on this to go through the LEDs tree as discussed.
>
> Yours,
> Linus Walleij
OK, merged with Alex and Linus Acks. Thanks,
-Bryan
next prev parent reply other threads:[~2015-05-12 17:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-07 8:08 [PATCH 0/3] leds: leds-gpio: Allow compile test if !GPIOLIB Geert Uytterhoeven
2015-05-07 8:08 ` [PATCH 1/3] gpiolib: Add missing dummies for the unified device properties interface Geert Uytterhoeven
2015-05-08 17:43 ` Bryan Wu
2015-05-12 7:48 ` Geert Uytterhoeven
2015-05-12 7:47 ` Alexandre Courbot
2015-05-12 10:31 ` Linus Walleij
2015-05-12 17:48 ` Bryan Wu [this message]
2015-05-07 8:08 ` [PATCH 2/3] leds: leds-gpio: Add missing #include <linux/of.h> Geert Uytterhoeven
2015-05-07 12:15 ` Jacek Anaszewski
2015-05-12 17:49 ` Bryan Wu
2015-05-07 8:08 ` [PATCH 3/3] leds: leds-gpio: Allow compile test if !GPIOLIB Geert Uytterhoeven
2015-05-07 12:15 ` Jacek Anaszewski
2015-05-12 10:23 ` Linus Walleij
2015-05-12 17:53 ` Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK5ve-+9jtPMYdYmicJDRwiUcb8g5XD0h-G88RULY3GX6skZmQ@mail.gmail.com \
--to=cooloney@gmail.com \
--cc=arnd@arndb.de \
--cc=geert@linux-m68k.org \
--cc=gnurou@gmail.com \
--cc=j.anaszewski@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).