From: Bryan Wu <bryan.wu@canonical.com>
To: "Kim, Milo" <Milo.Kim@ti.com>
Cc: "linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Richard Purdie <rpurdie@rpsys.net>
Subject: Re: [PATCH 2/3] leds-lp5523: add new device id for LP55231
Date: Tue, 4 Sep 2012 16:10:48 +0800 [thread overview]
Message-ID: <CAK5ve-LvRumrD6OP-aCYF0GqvdHjF7caHsC04cF7-cQZc19EDg@mail.gmail.com> (raw)
In-Reply-To: <A874F61F95741C4A9BA573A70FE3998F41EF2105@DQHE02.ent.ti.com>
On Tue, Sep 4, 2012 at 3:06 PM, Kim, Milo <Milo.Kim@ti.com> wrote:
> To support LP55231 device, the device id is added.
> Additionally, the i2c driver name is changed from lp5523 to lp5523x.
>
Applied to my for-next.
-Bryan
> Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
> ---
> drivers/leds/leds-lp5523.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/leds/leds-lp5523.c b/drivers/leds/leds-lp5523.c
> index 80d3792..e69e72a 100644
> --- a/drivers/leds/leds-lp5523.c
> +++ b/drivers/leds/leds-lp5523.c
> @@ -104,6 +104,11 @@
> #define LED_ACTIVE(mux, led) (!!(mux & (0x0001 << led)))
> #define SHIFT_MASK(id) (((id) - 1) * 2)
>
> +enum lp5523_chip_id {
> + LP5523,
> + LP55231,
> +};
> +
> struct lp5523_engine {
> int id;
> u8 mode;
> @@ -1005,7 +1010,8 @@ static int lp5523_remove(struct i2c_client *client)
> }
>
> static const struct i2c_device_id lp5523_id[] = {
> - { "lp5523", 0 },
> + { "lp5523", LP5523 },
> + { "lp55231", LP55231 },
> { }
> };
>
> @@ -1013,7 +1019,7 @@ MODULE_DEVICE_TABLE(i2c, lp5523_id);
>
> static struct i2c_driver lp5523_driver = {
> .driver = {
> - .name = "lp5523",
> + .name = "lp5523x",
> },
> .probe = lp5523_probe,
> .remove = lp5523_remove,
> --
> 1.7.9.5
>
>
> Best Regards,
> Milo
>
>
--
Bryan Wu <bryan.wu@canonical.com>
Kernel Developer +86.186-168-78255 Mobile
Canonical Ltd. www.canonical.com
Ubuntu - Linux for human beings | www.ubuntu.com
prev parent reply other threads:[~2012-09-04 8:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-04 7:06 [PATCH 2/3] leds-lp5523: add new device id for LP55231 Kim, Milo
2012-09-04 8:10 ` Bryan Wu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK5ve-LvRumrD6OP-aCYF0GqvdHjF7caHsC04cF7-cQZc19EDg@mail.gmail.com \
--to=bryan.wu@canonical.com \
--cc=Milo.Kim@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).