From: Masahiro Yamada <masahiroy@kernel.org>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
linux-arch <linux-arch@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 2/8] kbuild: prevent exported headers from including <stdlib.h>, <stdbool.h>
Date: Tue, 5 Apr 2022 10:12:17 +0900 [thread overview]
Message-ID: <CAK7LNAQDD4u5acyG7m4mziz-nz3D2u+ukdZZB+jZah_3JZFMTQ@mail.gmail.com> (raw)
In-Reply-To: <YkssI2uDHRq41zjw@google.com>
On Tue, Apr 5, 2022 at 2:34 AM Nick Desaulniers <ndesaulniers@google.com> wrote:
>
> On Mon, Apr 04, 2022 at 12:41:54AM -0700, Christoph Hellwig wrote:
> > On Mon, Apr 04, 2022 at 03:19:42PM +0900, Masahiro Yamada wrote:
> > > If we can make kernel headers self-contained (that is, none of exported
> > > kernel headers includes system headers), we will be able to add the
> > > -nostdinc flag, but that is much far from where we stand now.
>
> This is something I'd like to see done. IMO, the kernel headers should
> be the independent variable of which the libc is the dependendent
> variable.
>
> Android's libc, Bionic, is making use of the UAPI headers. They are
> doing some rewriting of UAPI headers, but I'd like to see what needs to
> be upstreamed from there. I just noticed
> include/uapi/linux/libc-compat.h, which seems like a good place for such
> compat related issues.
>
> In particular, having UAPI_HEADER_TESTS depend on CC_CAN_LINK is
> something I think we can works towards removing. The header tests
> themselves don't link; they force a dependency on a prebuilt libc
> sysroot, and they only need the headers from the sysroot because of this
> existing circular dependency between kernel headers and libc headers.
>
> I'd be happy to be explicitly cc'ed on changes like this series, going
> forward. Masahiro, if there's parts you'd like me to help with besides
> just code review, please let me know how I can help.
I wanted to make uapi headers as self-contained as possible,
but I did not see much progress.
I just fixed up some low-hanging fruits, but there are still
many remaining issues.
Thank you very much for your contribution:
https://lore.kernel.org/all/20220404175448.46200-1-ndesaulniers@google.com/
If you eliminate other issues, that would be appreciated.
> >
> > What is still missing for that?
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2022-04-05 2:20 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-04 6:19 [PATCH 0/8] UAPI: make more exported headers self-contained, and put them into test coverage Masahiro Yamada
2022-04-04 6:19 ` [PATCH 1/8] agpgart.h: do not include <stdlib.h> from exported header Masahiro Yamada
2022-04-04 7:40 ` Christoph Hellwig
2022-04-04 17:27 ` Nick Desaulniers
2022-04-04 6:19 ` [PATCH 2/8] kbuild: prevent exported headers from including <stdlib.h>, <stdbool.h> Masahiro Yamada
2022-04-04 7:41 ` Christoph Hellwig
2022-04-04 8:01 ` Arnd Bergmann
2022-04-04 8:03 ` Masahiro Yamada
2022-04-04 17:34 ` Nick Desaulniers
2022-04-05 1:12 ` Masahiro Yamada [this message]
2022-04-04 6:19 ` [PATCH 3/8] riscv: add linux/bpf_perf_event.h to UAPI compile-test coverage Masahiro Yamada
2022-04-04 7:41 ` Christoph Hellwig
2022-04-04 6:19 ` [PATCH 4/8] mips: add asm/stat.h " Masahiro Yamada
2022-04-04 7:42 ` Christoph Hellwig
2022-04-04 6:19 ` [PATCH 5/8] powerpc: " Masahiro Yamada
2022-04-04 7:42 ` Christoph Hellwig
2022-04-04 6:19 ` [PATCH 6/8] sparc: " Masahiro Yamada
2022-04-04 7:43 ` Christoph Hellwig
2022-04-04 6:19 ` [PATCH 7/8] posix_types.h: add __kernel_uintptr_t to UAPI posix_types.h Masahiro Yamada
2022-04-04 11:30 ` kernel test robot
2022-04-04 11:51 ` Masahiro Yamada
2022-04-04 12:02 ` Masahiro Yamada
2022-04-04 11:51 ` kernel test robot
2022-04-04 13:04 ` kernel test robot
2022-04-04 6:19 ` [PATCH 8/8] virtio_ring.h: do not include <stdint.h> from exported header Masahiro Yamada
2022-04-04 7:44 ` Christoph Hellwig
2022-04-04 7:58 ` Masahiro Yamada
2022-04-04 8:04 ` Arnd Bergmann
2022-04-05 5:35 ` Christoph Hellwig
2022-04-05 6:29 ` Arnd Bergmann
2022-04-05 7:01 ` Christoph Hellwig
2022-04-05 11:55 ` Michael S. Tsirkin
2022-04-05 11:57 ` Michael S. Tsirkin
2022-04-05 11:59 ` Michael S. Tsirkin
2022-04-05 11:57 ` Michael S. Tsirkin
2022-04-04 7:34 ` [PATCH 0/8] UAPI: make more exported headers self-contained, and put them into test coverage Arnd Bergmann
2022-05-13 8:43 ` Masahiro Yamada
2022-05-13 9:01 ` Arnd Bergmann
2022-05-13 9:13 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNAQDD4u5acyG7m4mziz-nz3D2u+ukdZZB+jZah_3JZFMTQ@mail.gmail.com \
--to=masahiroy@kernel.org \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).