From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752567AbdLLPJJ (ORCPT ); Tue, 12 Dec 2017 10:09:09 -0500 Received: from conssluserg-03.nifty.com ([210.131.2.82]:64717 "EHLO conssluserg-03.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751585AbdLLPJF (ORCPT ); Tue, 12 Dec 2017 10:09:05 -0500 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-03.nifty.com vBCF8pHF012103 X-Nifty-SrcIP: [209.85.217.175] X-Google-Smtp-Source: ACJfBoubQJ4TnKyoWca1RbOHyzfauB8z4ib12HgssyGvxxefVdD2JNb+ENh+n/JNoCS7QlhKhc6MG+7d0/9z4MJBqD8= MIME-Version: 1.0 In-Reply-To: References: <20171114123834.xsjiy2ynvott4gae@brain> <1511780854-7213-1-git-send-email-paolo.pisati@canonical.com> From: Masahiro Yamada Date: Wed, 13 Dec 2017 00:08:10 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3] scripts/package: snap-pkg target To: Paolo Pisati Cc: Jim Davis , Michal Marek , Behan Webster , Matthias Kaehlcke , =?UTF-8?Q?Vin=C3=ADcius_Tinti?= , linux-kbuild , linux-kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2017-12-08 0:31 GMT+09:00 Masahiro Yamada : > 2017-12-07 3:14 GMT+09:00 Paolo Pisati : >> On Wed, Dec 6, 2017 at 11:36 AM, Masahiro Yamada >> wrote: >>> Just one question to Paolo: >>> >>> If some change like firmware removal happens in the future, >>> patching for snapcraft is necessary? >>> (i.e. users are required to upgrade snapcraft from --edge ?) >>> >>> I guess the answer is yes, because "plugin: kernel" needs to know >>> the kernel-build system internal. >> >> Well, in this case, i had to fix the 'kernel-with-firmware' option to >> skip the 'firmware_install' step since >> we took it by default - let's say that in the future the >> 'modules_install' target is removed or change name, >> then i'll have to patch snapcraft. >> >> Wrt updating from -edge, i told you to take it from there because snap >> packages land there more often and more quickly >> compared to the canonicaldeb archive, so from a developer perspective >> it's easier&quicker to iterate over it, but sooner >> or later (e.g. once snapcraft 2.36.1 reaches the snap -stable >> channel), it will be copied to the deb archive too - >> IOW, you would get using apt-get only too. >> -- > > > I will pick up this for v4.16-rc1. > It sounds like this target is a bit fragile, but let's see. > I hope a breakage will not happen... > Applied to linux-kbuild/misc. Thanks! -- Best Regards Masahiro Yamada