linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Laura Abbott <labbott@redhat.com>
Cc: Andy Lutomirski <luto@kernel.org>,
	mjw@fedoraproject.org, "H . J . Lu" <hjl.tools@gmail.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	X86 ML <x86@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Nick Clifton <nickc@redhat.com>,
	Cary Coutant <ccoutant@gmail.com>
Subject: Re: [RFC PATCH 0/3] Salted build ids via linker sections
Date: Mon, 26 Mar 2018 16:48:11 +0900	[thread overview]
Message-ID: <CAK7LNAQTf_tVvks==_wGsEeNs6Bpdcfy9k39fpzneFvVZGAOiA@mail.gmail.com> (raw)
In-Reply-To: <20180321014635.29113-1-labbott@redhat.com>

2018-03-21 10:46 GMT+09:00 Laura Abbott <labbott@redhat.com>:
> Hi,
>
> This is a proposal that's come out of several discussion for Fedora but
> may be of interest to other distributions.
>
> In Fedora, the debug information is packaged separately (foo-debuginfo) and
> can be installed separately. There's been a long standing issue where only one
> version of a debuginfo info package can be installed at a time. Mark Wielaard
> made an effort for Fedora 27 to allow parallel installation of debuginfo (see
> https://fedoraproject.org/wiki/Changes/ParallelInstallableDebuginfo for
> more details)

Is this a kernel-specific problem?

IIUC, the URL above is discussing packages in general.

Any executable from slightly different versions
could result in identical ELF.
If so, will you tweak link process of every package
that needs parallel installation?




> Part of the requirement to allow this to work is that build ids are
> unique between builds. The existing upstream rpm implementation ensures
> this by re-calculating the build-id using the version and release as a
> seed. This doesn't work 100% for the kernel because of the vDSO which is
> its own binary and doesn't get updated. After poking holes in a few of my
> ideas, there was a discussion with some people from the binutils team about
> adding --build-id-salt to let ld do the calculation debugedit is doing. There
> was a counter proposal made about adding some extra information via a .comment
> which will affect the build id calculation but just get stripped out.
>
> This is an implementation of the counter proposal. If an environment variable
> is set, that value gets added as a .comment section to the necessary binaries.
> This is RFC mostly to see if this approach is plausible enough to be merged or
> if it's worth trying to update binutils with the --build-id-salt option.
> I don't care about any names, I was pretty inconsistent. If people are
> roughly satisifed with this I'll probably just change all the names to
> build-salt or whatever gets bike shedded.
>
> Thanks,
> Laura
>
> Laura Abbott (3):
>   kbuild: Introduce build-salt generated header
>   kbuild: Link with generated build-salt header
>   x86/vdso: Add build salt to the vDSO
>
>  Makefile                              | 13 +++++++++++--
>  arch/x86/entry/vdso/vdso-layout.lds.S |  3 +++
>  scripts/.gitignore                    |  1 +
>  scripts/Makefile                      |  2 +-
>  scripts/build-id.lds.S                |  5 +++++
>  scripts/gencomment                    | 19 +++++++++++++++++++
>  scripts/link-vmlinux.sh               |  3 ++-
>  7 files changed, 42 insertions(+), 4 deletions(-)
>  create mode 100644 scripts/build-id.lds.S
>  create mode 100755 scripts/gencomment
>
> --
> 2.16.2
>



-- 
Best Regards
Masahiro Yamada

  parent reply	other threads:[~2018-03-26  7:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-21  1:46 [RFC PATCH 0/3] Salted build ids via linker sections Laura Abbott
2018-03-21  1:46 ` [RFC PATCH 1/3] kbuild: Introduce build-salt generated header Laura Abbott
2018-03-21  1:46 ` [RFC PATCH 2/3] kbuild: Link with generated build-salt header Laura Abbott
2018-03-21  1:46 ` [RFC PATCH 3/3] x86/vdso: Add build salt to the vDSO Laura Abbott
2018-03-21  9:40 ` [RFC PATCH 0/3] Salted build ids via linker sections Nick Clifton
2018-03-26  7:48 ` Masahiro Yamada [this message]
2018-03-26  9:58   ` Mark Wielaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK7LNAQTf_tVvks==_wGsEeNs6Bpdcfy9k39fpzneFvVZGAOiA@mail.gmail.com' \
    --to=yamada.masahiro@socionext.com \
    --cc=ccoutant@gmail.com \
    --cc=hjl.tools@gmail.com \
    --cc=labbott@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mjw@fedoraproject.org \
    --cc=nickc@redhat.com \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).