From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932441AbcA0Nkt (ORCPT <rfc822;w@1wt.eu>);
	Wed, 27 Jan 2016 08:40:49 -0500
Received: from conssluserg002.nifty.com ([202.248.44.40]:17460 "EHLO
	conssluserg002-v.nifty.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1752792AbcA0Nkq (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 27 Jan 2016 08:40:46 -0500
X-Nifty-SrcIP: [209.85.160.176]
MIME-Version: 1.0
In-Reply-To: <1453868872-26300-12-git-send-email-wangkefeng.wang@huawei.com>
References: <1453868872-26300-1-git-send-email-wangkefeng.wang@huawei.com>
	<1453868872-26300-12-git-send-email-wangkefeng.wang@huawei.com>
Date: Wed, 27 Jan 2016 22:40:19 +0900
X-Gmail-Original-Message-ID: <CAK7LNAQWd3fchwtyE8hAC=ZZ+mk4gyqReJ9SSxvaY0u1SoSkvA@mail.gmail.com>
Message-ID: <CAK7LNAQWd3fchwtyE8hAC=ZZ+mk4gyqReJ9SSxvaY0u1SoSkvA@mail.gmail.com>
Subject: Re: [PATCH 11/15] bus: uniphier-system-bus: use of_platform_default_populate()
 to populate default bus
From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        Arnd Bergmann <arnd@arndb.de>, Shawn Guo <shawnguo@kernel.org>,
        Russell King <linux@arm.linux.org.uk>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Hauke Mehrtens <hauke@hauke-m.de>, Rob Herring <robh+dt@kernel.org>,
        guohanjun@huawei.com
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Kefeng,

2016-01-27 13:27 GMT+09:00 Kefeng Wang <wangkefeng.wang@huawei.com>:
> Use helper of_platform_default_populate() in linux/of_platform
> when possible, instead of calling of_platform_populate() with
> the default match table.
>
> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
>  drivers/bus/uniphier-system-bus.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/bus/uniphier-system-bus.c b/drivers/bus/uniphier-system-bus.c
> index 834a2ae..f50bd6d 100644
> --- a/drivers/bus/uniphier-system-bus.c
> +++ b/drivers/bus/uniphier-system-bus.c
> @@ -257,8 +257,7 @@ static int uniphier_system_bus_probe(struct platform_device *pdev)
>         uniphier_system_bus_set_reg(priv);
>
>         /* Now, the bus is configured.  Populate platform_devices below it */
> -       return of_platform_populate(dev->of_node, of_default_bus_match_table,
> -                                   NULL, dev);
> +       return of_platform_default_populate(dev->of_node, NULL, dev);
>  }
>
>  static const struct of_device_id uniphier_system_bus_match[] = {


I did not notice the existence of of_platform_default_populate().

If I had used this function, commit b80443cc22 would have not been
needed in the first place...

Thanks for cleaning this!

Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>


-- 
Best Regards
Masahiro Yamada