From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752564AbdK2D64 (ORCPT ); Tue, 28 Nov 2017 22:58:56 -0500 Received: from conssluserg-02.nifty.com ([210.131.2.81]:26053 "EHLO conssluserg-02.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751822AbdK2D6y (ORCPT ); Tue, 28 Nov 2017 22:58:54 -0500 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-02.nifty.com vAT3waHU003916 X-Nifty-SrcIP: [209.85.213.46] X-Google-Smtp-Source: AGs4zMah7KAdikhv/zsPuDOl2obYJjBlY8Y3hlagVkgHH1Q9RbkC9PYIGhst4YzkWZl5WoBwE04DCZ55PDXg9cgHNVY= MIME-Version: 1.0 In-Reply-To: <20171128152541.jdd2k5n5mjpppqxv@rob-hp-laptop> References: <1511854150-26346-1-git-send-email-yamada.masahiro@socionext.com> <20171128152541.jdd2k5n5mjpppqxv@rob-hp-laptop> From: Masahiro Yamada Date: Wed, 29 Nov 2017 12:57:55 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] dt-bindings: uniphier: add bindings for UniPhier SoC family To: Rob Herring Cc: devicetree@vger.kernel.org, =?UTF-8?Q?Andreas_F=C3=A4rber?= , Mauro Carvalho Chehab , Randy Dunlap , Linux Kernel Mailing List , "David S. Miller" , Greg Kroah-Hartman , Mark Rutland , linux-arm-kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, 2017-11-29 0:25 GMT+09:00 Rob Herring : > On Tue, Nov 28, 2017 at 04:29:10PM +0900, Masahiro Yamada wrote: > > Commit msg? I will write something to fill the line. >> Signed-off-by: Masahiro Yamada >> --- >> >> Documentation/devicetree/bindings/arm/uniphier.txt | 40 ++++++++++++++++++++++ > > Perhaps arm/socionext/uniphier.txt instead. I just recalled that I created the directory, Documentation/devicetree/bindings/arm/uniphier/ So, perhaps, it should go to Documentation/devicetree/bindings/arm/uniphier/uniphier.txt >> MAINTAINERS | 1 + >> 2 files changed, 41 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/arm/uniphier.txt >> >> diff --git a/Documentation/devicetree/bindings/arm/uniphier.txt b/Documentation/devicetree/bindings/arm/uniphier.txt >> new file mode 100644 >> index 0000000..08d3cf3 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/arm/uniphier.txt >> @@ -0,0 +1,40 @@ >> +Socionext UniPhier SoC family >> + >> +Required properties in the root node: >> + - compatible: should contain board and SoC compatible strings >> + >> + SoC compatibles: >> + - "socionext,uniphier-ld4" - LD4 SoC >> + - "socionext,uniphier-pro4" - Pro4 SoC >> + - "socionext,uniphier-sld8" - sLD8 SoC >> + - "socionext,uniphier-pro5" - Pro5 SoC >> + - "socionext,uniphier-pxs2" - PXs2 SoC >> + - "socionext,uniphier-ld6b" - LD6b SoC >> + - "socionext,uniphier-ld11" - LD11 SoC >> + - "socionext,uniphier-ld20" - LD20 SoC >> + - "socionext,uniphier-pxs3" - PXs3 SoC > > Sort this? Or are these in chronological order? This is sorted in the chronological order. I already put some bindings sorted chronologically (for example, Documentation/devicetree/bindings/clock/uniphier-clock.txt) (If the alphabetical sort is highly recommended, I will do so, but I do not know what to do for the existing ones.) >> + >> + Board compatibles: >> + - "socionext,uniphier-ld4-ref" - LD4 Reference Board >> + - "socionext,uniphier-pro4-ref" - Pro4 Reference Board >> + - "socionext,uniphier-pro4-ace" - Pro4 Ace Board >> + - "socionext,uniphier-pro4-sanji" - Pro4 Sanji Board >> + - "socionext,uniphier-sld8-ref" - sLD8 Reference Board >> + - "socionext,uniphier-pxs2-gentil" - PXs2 Gentil Board >> + - "socionext,uniphier-pxs2-vodka" - PXs2 Vodka Board >> + - "socionext,uniphier-ld6b-ref" - LD6b Reference Board >> + - "socionext,uniphier-ld11-ref" - LD11 Reference Board >> + - "socionext,uniphier-ld11-global" - LD11 Global Board >> + - "socionext,uniphier-ld20-ref" - LD20 Reference Board >> + - "socionext,uniphier-ld20-global" - LD20 Global Board >> + - "socionext,uniphier-pxs3-ref" - PXs3 Reference Board > > I would group boards by each SoC. Then it clear which board compatibles > go with each SoC compatible and you don't have to have the SoC name in > the board compatible. > OK, will do. -- Best Regards Masahiro Yamada