linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Joe Perches <joe@perches.com>
Cc: Douglas Anderson <dianders@chromium.org>,
	Daniel Thompson <daniel.thompson@linaro.org>,
	Jason Wessel <jason.wessel@windriver.com>,
	Christophe Leroy <christophe.leroy@c-s.fr>,
	"Peter Zijlstra (Intel)" <peterz@infradead.org>,
	Kees Cook <keescook@chromium.org>,
	kgdb-bugreport@lists.sourceforge.net,
	Johannes Weiner <hannes@cmpxchg.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
	Nicholas Mc Guire <hofrat@osadl.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] kdb: Get rid of broken attempt to print CCVERSION in kdb summary
Date: Fri, 19 Apr 2019 12:28:20 +0900	[thread overview]
Message-ID: <CAK7LNAQe2uaVfKee1F6R4siVvUSCMgSaYAnUQfz8MS5PeFqpGA@mail.gmail.com> (raw)
In-Reply-To: <20190418160651.40cb6a11186a6c6028e9d20d@linux-foundation.org>

Hi Joe,

Can you detect redundant Cc: by checkpatch?

Please see below in details.
Thanks.


On Fri, Apr 19, 2019 at 8:07 AM Andrew Morton <akpm@linux-foundation.org> wrote:
>
> On Wed, 17 Apr 2019 15:37:49 +0900 Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
>
> > > It's pretty benign: Doug will still only get a single email.
> > >
> > >
> > > checkpatch checks for duplicates cc's but I think it assumes that
> > > things like
> > >
> > > Reported-by: fred
> > > Tested-by: fred
> > >
> > > were intentional.
> > >
> > > It would perhaps be better for checkpatch to special-case the "Cc:
> > > fred" tag and report a duplicated Cc: if fred was also mentioned in any
> > > other tag.
> >
> > Sorry, I do not understand what you mean.
> >
> >
> > Douglas did not add any Cc: tag at all
> > in his original patch:
> > https://lore.kernel.org/patchwork/patch/1053953/
> >
> >
> > It's you who added the Cc: tags
> > (and I am guessing you did it by scripting.)
> >
> > Why is this topic related to checkpatch?
>
> Because I regularly check all patches with checkpatch but checkpatch
> failed to detect that I had
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ...
> Cc: Douglas Anderson <dianders@chromium.org>
>
> and I believe that checkpatch could and should have warned about this
> situation.
>


-- 
Best Regards
Masahiro Yamada

  reply	other threads:[~2019-04-19  3:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-23  1:52 Douglas Anderson
2019-03-30 12:14 ` Masahiro Yamada
2019-04-11  9:06 ` Masahiro Yamada
2019-04-16 23:30   ` Andrew Morton
2019-04-17  6:37     ` Masahiro Yamada
2019-04-18 23:06       ` Andrew Morton
2019-04-19  3:28         ` Masahiro Yamada [this message]
2019-04-19 11:14           ` Joe Perches
2019-04-19 20:58             ` Andrew Morton
2019-04-20  3:57               ` Joe Perches
2019-05-06 14:28             ` Masahiro Yamada
2019-05-07 13:55               ` Daniel Thompson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK7LNAQe2uaVfKee1F6R4siVvUSCMgSaYAnUQfz8MS5PeFqpGA@mail.gmail.com \
    --to=yamada.masahiro@socionext.com \
    --cc=akpm@linux-foundation.org \
    --cc=christophe.leroy@c-s.fr \
    --cc=daniel.thompson@linaro.org \
    --cc=dianders@chromium.org \
    --cc=gustavo@embeddedor.com \
    --cc=hannes@cmpxchg.org \
    --cc=hofrat@osadl.org \
    --cc=jason.wessel@windriver.com \
    --cc=joe@perches.com \
    --cc=keescook@chromium.org \
    --cc=kgdb-bugreport@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --subject='Re: [PATCH] kdb: Get rid of broken attempt to print CCVERSION in kdb summary' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).