From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Paul Burton <paul.burton@mips.com>
Cc: "linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
Ralf Baechle <ralf@linux-mips.org>,
James Hogan <jhogan@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] MIPS: remove meaningless generic-(CONFIG_GENERIC_CSUM) += checksum.h
Date: Tue, 22 Jan 2019 11:01:14 +0900 [thread overview]
Message-ID: <CAK7LNAQpVF=uHs+AxVomxQDwzpPtmKTT4-D4Hc7JphygF0BFKQ@mail.gmail.com> (raw)
In-Reply-To: <20190121174106.6tgokdtlo5f72hdx@pburton-laptop>
Hi Paul,
On Tue, Jan 22, 2019 at 2:44 AM Paul Burton <paul.burton@mips.com> wrote:
>
> Hi Masahiro,
>
> On Mon, Jan 21, 2019 at 11:48:49AM +0900, Masahiro Yamada wrote:
> > This line is weird in multiple ways.
> >
> > (CONFIG_GENERIC_CSUM) might be a typo of $(CONFIG_GENERIC_CSUM).
> >
> > Even if you add '$' to it, $(CONFIG_GENERIC_CSUM) is never evaluated
> > to 'y' because scripts/Makefile.asm-generic does not include
> > include/config/auto.conf. So, the asm-generic wrapper of checksum.h
> > is never generated.
> >
> > Even if you manage to generate it, it is never included by anyone
> > because MIPS has the checkin header with the same file name:
> >
> > arch/mips/include/asm/checksum.h
> >
> > As you see in the top Makefile, the checkin headers are included before
> > generated ones.
> >
> > LINUXINCLUDE := \
> > -I$(srctree)/arch/$(SRCARCH)/include \
> > -I$(objtree)/arch/$(SRCARCH)/include/generated \
> > ...
> >
> > Commit 4e0748f5beb9 ("MIPS: Use generic checksum functions for MIPS R6")
> > already added the asm-generic fallback code in the checkin header:
> >
> > #ifdef CONFIG_GENERIC_CSUM
> > #include <asm/generic/checksum.h>
> > #else
> > ...
> > #endif
> >
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>
> Good catch. Would you prefer to take this through your kbuild tree or
> that I take it through the MIPS tree?
Could you apply it to MIPS tree? Thanks.
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2019-01-22 2:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 2:48 [PATCH] MIPS: remove meaningless generic-(CONFIG_GENERIC_CSUM) += checksum.h Masahiro Yamada
2019-01-21 17:41 ` Paul Burton
2019-01-22 2:01 ` Masahiro Yamada [this message]
2019-01-23 17:51 ` Paul Burton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK7LNAQpVF=uHs+AxVomxQDwzpPtmKTT4-D4Hc7JphygF0BFKQ@mail.gmail.com' \
--to=yamada.masahiro@socionext.com \
--cc=jhogan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=paul.burton@mips.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).