* [PATCH v2] openrisc: make function cache_loop() inline
@ 2018-11-14 23:08 Changbin Du
2018-11-19 11:29 ` Changbin Du
0 siblings, 1 reply; 3+ messages in thread
From: Changbin Du @ 2018-11-14 23:08 UTC (permalink / raw)
To: yamada.masahiro
Cc: jonas, stefan.kristiansson, shorne, openrisc, linux-kernel, Changbin Du
The third operand of mtspr instruction must be a constant. To guarantee
this condition, function cache_loop() which uses macro mtspr() must be
inlined. So let's force it as 'inline'. This is to fix compiling error with
new option CONFIG_NO_AUTO_INLINE.
In file included from arch/openrisc/mm/cache.c:17:0:
arch/openrisc/mm/cache.c: In function 'cache_loop':
arch/openrisc/include/asm/spr.h:20:27: warning: asm operand 0 probably doesn't match constraints
^
arch/openrisc/mm/cache.c:29:3: note: in expansion of macro 'mtspr'
mtspr(reg, line);
^~~~~
arch/openrisc/include/asm/spr.h:20:27: error: impossible constraint in 'asm'
Signed-off-by: Changbin Du <changbin.du@gmail.com>
Reported-by: kbuild test robot <lkp@intel.com>
Cc: Stafford Horne <shorne@gmail.com>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Stafford Horne <shorne@gmail.com>
---
arch/openrisc/mm/cache.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/openrisc/mm/cache.c b/arch/openrisc/mm/cache.c
index b747bf1fc1b6..4a4b2b6e006b 100644
--- a/arch/openrisc/mm/cache.c
+++ b/arch/openrisc/mm/cache.c
@@ -20,7 +20,7 @@
#include <asm/cacheflush.h>
#include <asm/tlbflush.h>
-static void cache_loop(struct page *page, const unsigned int reg)
+static inline void cache_loop(struct page *page, const unsigned int reg)
{
unsigned long paddr = page_to_pfn(page) << PAGE_SHIFT;
unsigned long line = paddr & ~(L1_CACHE_BYTES - 1);
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] openrisc: make function cache_loop() inline
2018-11-14 23:08 [PATCH v2] openrisc: make function cache_loop() inline Changbin Du
@ 2018-11-19 11:29 ` Changbin Du
2018-11-19 14:41 ` Masahiro Yamada
0 siblings, 1 reply; 3+ messages in thread
From: Changbin Du @ 2018-11-19 11:29 UTC (permalink / raw)
To: yamada.masahiro
Cc: yamada.masahiro, jonas, stefan.kristiansson, shorne, openrisc,
linux-kernel
Hi, Yamada,
Could you add this patch to your kbuild tree? Horne already acked it.
On Thu, Nov 15, 2018 at 07:08:56AM +0800, Changbin Du wrote:
> The third operand of mtspr instruction must be a constant. To guarantee
> this condition, function cache_loop() which uses macro mtspr() must be
> inlined. So let's force it as 'inline'. This is to fix compiling error with
> new option CONFIG_NO_AUTO_INLINE.
>
> In file included from arch/openrisc/mm/cache.c:17:0:
> arch/openrisc/mm/cache.c: In function 'cache_loop':
> arch/openrisc/include/asm/spr.h:20:27: warning: asm operand 0 probably doesn't match constraints
> ^
> arch/openrisc/mm/cache.c:29:3: note: in expansion of macro 'mtspr'
> mtspr(reg, line);
> ^~~~~
> arch/openrisc/include/asm/spr.h:20:27: error: impossible constraint in 'asm'
>
> Signed-off-by: Changbin Du <changbin.du@gmail.com>
> Reported-by: kbuild test robot <lkp@intel.com>
> Cc: Stafford Horne <shorne@gmail.com>
> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
> Acked-by: Stafford Horne <shorne@gmail.com>
> ---
> arch/openrisc/mm/cache.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/openrisc/mm/cache.c b/arch/openrisc/mm/cache.c
> index b747bf1fc1b6..4a4b2b6e006b 100644
> --- a/arch/openrisc/mm/cache.c
> +++ b/arch/openrisc/mm/cache.c
> @@ -20,7 +20,7 @@
> #include <asm/cacheflush.h>
> #include <asm/tlbflush.h>
>
> -static void cache_loop(struct page *page, const unsigned int reg)
> +static inline void cache_loop(struct page *page, const unsigned int reg)
> {
> unsigned long paddr = page_to_pfn(page) << PAGE_SHIFT;
> unsigned long line = paddr & ~(L1_CACHE_BYTES - 1);
> --
> 2.17.1
>
--
Cheers,
Changbin Du
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] openrisc: make function cache_loop() inline
2018-11-19 11:29 ` Changbin Du
@ 2018-11-19 14:41 ` Masahiro Yamada
0 siblings, 0 replies; 3+ messages in thread
From: Masahiro Yamada @ 2018-11-19 14:41 UTC (permalink / raw)
To: Changbin Du
Cc: Jonas Bonn, Stefan Kristiansson, Stafford Horne, openrisc,
Linux Kernel Mailing List
On Mon, Nov 19, 2018 at 8:31 PM Changbin Du <changbin.du@gmail.com> wrote:
>
> Hi, Yamada,
> Could you add this patch to your kbuild tree? Horne already acked it.
>
> On Thu, Nov 15, 2018 at 07:08:56AM +0800, Changbin Du wrote:
> > The third operand of mtspr instruction must be a constant. To guarantee
> > this condition, function cache_loop() which uses macro mtspr() must be
> > inlined. So let's force it as 'inline'. This is to fix compiling error with
> > new option CONFIG_NO_AUTO_INLINE.
> >
> > In file included from arch/openrisc/mm/cache.c:17:0:
> > arch/openrisc/mm/cache.c: In function 'cache_loop':
> > arch/openrisc/include/asm/spr.h:20:27: warning: asm operand 0 probably doesn't match constraints
> > ^
> > arch/openrisc/mm/cache.c:29:3: note: in expansion of macro 'mtspr'
> > mtspr(reg, line);
> > ^~~~~
> > arch/openrisc/include/asm/spr.h:20:27: error: impossible constraint in 'asm'
> >
> > Signed-off-by: Changbin Du <changbin.du@gmail.com>
> > Reported-by: kbuild test robot <lkp@intel.com>
> > Cc: Stafford Horne <shorne@gmail.com>
> > Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
> > Acked-by: Stafford Horne <shorne@gmail.com>
Now applied to linux-kbuild.
Thanks!
> > ---
> > arch/openrisc/mm/cache.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/openrisc/mm/cache.c b/arch/openrisc/mm/cache.c
> > index b747bf1fc1b6..4a4b2b6e006b 100644
> > --- a/arch/openrisc/mm/cache.c
> > +++ b/arch/openrisc/mm/cache.c
> > @@ -20,7 +20,7 @@
> > #include <asm/cacheflush.h>
> > #include <asm/tlbflush.h>
> >
> > -static void cache_loop(struct page *page, const unsigned int reg)
> > +static inline void cache_loop(struct page *page, const unsigned int reg)
> > {
> > unsigned long paddr = page_to_pfn(page) << PAGE_SHIFT;
> > unsigned long line = paddr & ~(L1_CACHE_BYTES - 1);
> > --
> > 2.17.1
> >
>
> --
> Cheers,
> Changbin Du
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-19 14:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-14 23:08 [PATCH v2] openrisc: make function cache_loop() inline Changbin Du
2018-11-19 11:29 ` Changbin Du
2018-11-19 14:41 ` Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).