From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
kieran.bingham+renesas@ideasonboard.com,
stable <stable@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>
Subject: Re: [PATCH] kbuild: fix kernel/bounds.c 'W=1' warning
Date: Sun, 7 Oct 2018 05:31:21 +0900 [thread overview]
Message-ID: <CAK7LNAQzOeoid3dRnAbZE3H-ZSbcJ4wJa_nreC-VLOutUH_ssA@mail.gmail.com> (raw)
In-Reply-To: <20181005083313.2088252-1-arnd@arndb.de>
On Fri, Oct 5, 2018 at 5:34 PM Arnd Bergmann <arnd@arndb.de> wrote:
>
> Building any configuration with 'make W=1' produces a warning:
>
> kernel/bounds.c:16:6: warnign: no previous prototype for 'foo' [-Wmissing-prototypes]
>
> When also passing -Werror, this prevents us from building any
> other files. Nobody ever calls the function, but we can't make
> it 'static' either since we want the compiler output.
>
> Calling it 'main' instead however avoids the warning, because gcc
> does not insist on having a declaration for main.
>
> Reported-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> Cc: stable@vger.kernel.org
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Applied to kbuild/fixes
with 's/warnign/warning/'
Thanks!
> I have run into this problem several times before, and thought I had
> sent a fix at some point. Looking in the archives, I came across
> the suggested fix from Kieran, so I'm following up on that here.
> ---
> kernel/bounds.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/bounds.c b/kernel/bounds.c
> index c373e887c066..9795d75b09b2 100644
> --- a/kernel/bounds.c
> +++ b/kernel/bounds.c
> @@ -13,7 +13,7 @@
> #include <linux/log2.h>
> #include <linux/spinlock_types.h>
>
> -void foo(void)
> +int main(void)
> {
> /* The enum constants to put into include/generated/bounds.h */
> DEFINE(NR_PAGEFLAGS, __NR_PAGEFLAGS);
> @@ -23,4 +23,6 @@ void foo(void)
> #endif
> DEFINE(SPINLOCK_SIZE, sizeof(spinlock_t));
> /* End of constants */
> +
> + return 0;
> }
> --
> 2.18.0
>
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2018-10-06 20:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 14:22 [PATCH] kernel/bounds: Provide prototype for foo Kieran Bingham
2018-09-21 14:45 ` Greg Kroah-Hartman
2018-09-21 15:58 ` Kieran Bingham
2018-09-21 16:03 ` Kieran Bingham
2018-10-05 8:33 ` [PATCH] kbuild: fix kernel/bounds.c 'W=1' warning Arnd Bergmann
2018-10-05 8:47 ` Kieran Bingham
2018-10-05 8:52 ` David Laight
2018-10-05 9:07 ` Arnd Bergmann
2018-10-05 9:27 ` Kieran Bingham
2018-10-06 20:31 ` Masahiro Yamada [this message]
2018-10-06 21:18 ` Miguel Ojeda
2018-10-06 21:58 ` Masahiro Yamada
2018-10-06 22:06 ` Masahiro Yamada
2018-10-08 10:00 ` Kieran Bingham
2018-10-08 14:32 ` Masahiro Yamada
2018-10-08 14:41 ` Geert Uytterhoeven
2018-10-06 22:07 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNAQzOeoid3dRnAbZE3H-ZSbcJ4wJa_nreC-VLOutUH_ssA@mail.gmail.com \
--to=yamada.masahiro@socionext.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).