From: Masahiro Yamada <masahiroy@kernel.org>
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: decompressor: simplify libfdt builds
Date: Sun, 19 Jan 2020 10:24:01 +0900 [thread overview]
Message-ID: <CAK7LNAR2zdOLyoJRJpYVt0C+TqQ172z32OJMQi5tHKP6=0G=WA@mail.gmail.com> (raw)
In-Reply-To: <20200117221534.GR25745@shell.armlinux.org.uk>
Hi Russell,
On Sat, Jan 18, 2020 at 7:15 AM Russell King - ARM Linux admin
<linux@armlinux.org.uk> wrote:
> > -ifeq ($(CONFIG_ARM_ATAG_DTB_COMPAT),y)
> > -OBJS += $(libfdt_objs) atags_to_fdt.o
> > +# -fstack-protector-strong triggers protection checks in this code,
> > +# but it is being used too early to link to meaningful stack_chk logic.
> > +nossp-flags-$(CONFIG_CC_HAS_STACKPROTECTOR_NONE) := -fno-stack-protector
> > +$(foreach o, $(libfdt_objs), \
> > + $(eval CFLAGS_$(o) := -I $(srctree)/scripts/dtc/libfdt) $(nossp-flags-y))
>
> The above change causes build breakage over a number of ARM builds,
> which unfortunately doesn't result in emails from any build system
> containing the cause of the failure.
>
> See
> https://kernelci.org/build/rmk/branch/for-next/kernel/v5.5-rc1-12-g9a6545e2fc83/
>
> where the failures are reported as:
>
> ../arch/arm/boot/compressed/Makefile:87: *** missing separator. Stop.
>
> Thanks. Patch dropped.
Sorry, I made a mistake about the location of
the closing parenthesis.
I fixed the build error, and posted v2:
https://www.armlinux.org.uk/developer/patches/viewpatch.php?id=8953/1
--
Best Regards
Masahiro Yamada
prev parent reply other threads:[~2020-01-19 1:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-04 4:49 [PATCH] ARM: decompressor: simplify libfdt builds Masahiro Yamada
2020-01-17 22:15 ` Russell King - ARM Linux admin
2020-01-19 1:24 ` Masahiro Yamada [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK7LNAR2zdOLyoJRJpYVt0C+TqQ172z32OJMQi5tHKP6=0G=WA@mail.gmail.com' \
--to=masahiroy@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).