From: Masahiro Yamada <firstname.lastname@example.org> To: Andrew Morton <email@example.com> Cc: Douglas Anderson <firstname.lastname@example.org>, Daniel Thompson <email@example.com>, Jason Wessel <firstname.lastname@example.org>, Christophe Leroy <email@example.com>, "Peter Zijlstra (Intel)" <firstname.lastname@example.org>, Kees Cook <email@example.com>, firstname.lastname@example.org, Johannes Weiner <email@example.com>, Linux Kernel Mailing List <firstname.lastname@example.org>, "Gustavo A. R. Silva" <email@example.com>, Nicholas Mc Guire <firstname.lastname@example.org>, Joe Perches <email@example.com> Subject: Re: [PATCH] kdb: Get rid of broken attempt to print CCVERSION in kdb summary Date: Wed, 17 Apr 2019 15:37:49 +0900 [thread overview] Message-ID: <CAK7LNAR4Ty8835sfo4HSvBsMCsV65mY2HOajFSY2TOYurmkFdw@mail.gmail.com> (raw) In-Reply-To: <firstname.lastname@example.org> Hi Andrew, On Wed, Apr 17, 2019 at 8:31 AM Andrew Morton <email@example.com> wrote: > > On Thu, 11 Apr 2019 18:06:23 +0900 Masahiro Yamada <firstname.lastname@example.org> wrote: > > > On Sat, Mar 23, 2019 at 10:55 AM Douglas Anderson <email@example.com> wrote: > > > > > > If you drop into kdb and type "summary", it prints out a line that > > > says this: > > > > > > ccversion CCVERSION > > > > > > ...and I don't mean that it actually prints out the version of the C > > > compiler. It literally prints out the string "CCVERSION". > > > > > > The version of the C Compiler is already printed at boot up and it > > > doesn't seem useful to replicate this in kdb. Let's just delete it. > > > We can also delete the bit of the Makefile that called the C compiler > > > in an attempt to pass this into kdb. This will remove one extra call > > > to the C compiler at Makefile parse time and (very slightly) speed up > > > builds. > > > > > > Signed-off-by: Douglas Anderson <firstname.lastname@example.org> > > > > > > I know you add lots of Cc: lines > > when you pick up patches, but I think > > your script can be improved. > > > > You added "Cc: Douglas Anderson <email@example.com>", > > but Douglas is the author. > > I think the author should be excluded from Cc. > > Whoops. > > It's pretty benign: Doug will still only get a single email. > > > checkpatch checks for duplicates cc's but I think it assumes that > things like > > Reported-by: fred > Tested-by: fred > > were intentional. > > It would perhaps be better for checkpatch to special-case the "Cc: > fred" tag and report a duplicated Cc: if fred was also mentioned in any > other tag. Sorry, I do not understand what you mean. Douglas did not add any Cc: tag at all in his original patch: https://lore.kernel.org/patchwork/patch/1053953/ It's you who added the Cc: tags (and I am guessing you did it by scripting.) Why is this topic related to checkpatch? -- Best Regards Masahiro Yamada
next prev parent reply other threads:[~2019-04-17 6:38 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-23 1:52 Douglas Anderson 2019-03-30 12:14 ` Masahiro Yamada 2019-04-11 9:06 ` Masahiro Yamada 2019-04-16 23:30 ` Andrew Morton 2019-04-17 6:37 ` Masahiro Yamada [this message] 2019-04-18 23:06 ` Andrew Morton 2019-04-19 3:28 ` Masahiro Yamada 2019-04-19 11:14 ` Joe Perches 2019-04-19 20:58 ` Andrew Morton 2019-04-20 3:57 ` Joe Perches 2019-05-06 14:28 ` Masahiro Yamada 2019-05-07 13:55 ` Daniel Thompson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAK7LNAR4Ty8835sfo4HSvBsMCsV65mY2HOajFSY2TOYurmkFdw@mail.gmail.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH] kdb: Get rid of broken attempt to print CCVERSION in kdb summary' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).