linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Masahiro Yamada <masahiroy@kernel.org>
To: David Gow <davidgow@google.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	Brendan Higgins <brendanhiggins@google.com>
Subject: Re: [PATCH v1 1/1] .gitignore: Unignore .kunitconfig
Date: Tue, 31 Jan 2023 11:11:14 +0900	[thread overview]
Message-ID: <CAK7LNAR8D6E_md3=1dLAc-o73xmKXDRXv9Fi_hiav1VhPSW58w@mail.gmail.com> (raw)
In-Reply-To: <CABVgOSnRC3AuUo4Qc2K3pXEcj3Wbt9LE2DTbejGrPOCKefxB2g@mail.gmail.com>

On Tue, Jan 31, 2023 at 9:01 AM David Gow <davidgow@google.com> wrote:
>
> On Sat, 28 Jan 2023 at 22:37, Masahiro Yamada <masahiroy@kernel.org> wrote:
> >
> > On Sat, Jan 28, 2023 at 3:56 PM David Gow <davidgow@google.com> wrote:
> > >
> > > On Fri, 27 Jan 2023 at 22:56, Andy Shevchenko
> > > <andriy.shevchenko@linux.intel.com> wrote:
> > > >
> > > > There are almost dozen of .kunitconfig files that are ignored but
> > > > tracked. Unignore them.
> > > >
> > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > > ---
> > >
> > > Thanks! Only the original root-directory .kunitignore file was
> > > intended to be ignored, and that's no longer as important, and is now
> > > in the build dir anyway.
> > >
> > > Reviewed-by: David Gow <davidgow@google.com>
> > >
> > > Cheers,
> > > -- David
> > >
> > > >  .gitignore | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/.gitignore b/.gitignore
> > > > index 22984d22d29e..e4f2ba0be516 100644
> > > > --- a/.gitignore
> > > > +++ b/.gitignore
> > > > @@ -100,6 +100,7 @@ modules.order
> > > >  !.get_maintainer.ignore
> > > >  !.gitattributes
> > > >  !.gitignore
> > > > +!.kunitconfig
> > > >  !.mailmap
> > > >  !.rustfmt.toml
> > > >
> > > > --
> > > > 2.39.0
> > > >
> >
> >
> > Why is this a dot file in the first place?
> >
>
> In short, historical reasons.
>
> The long answer is that there are two places "kunitconfig" files are
> used: as a user-provided file with their preferred test config (which
> is kept local), and as a recommended test config for a given subsystem
> (which is checked in).
> Originally, no .kunitconfig files were checked in: one was either
> autogenerated or manually modified and left in the root source
> directory. This eventually moved into the build directory, and a
> number of features which de-emphasized it in favour of command-line
> arguments and the (new) checked-in per-subsystem configs, which
> probably shouldn't be hidden.


Do you mean there are two types for .kunitconfig - auto-generated ones
and check-in ones?

If this patch is applied, is there a possibility where
auto-generated .kunitconfig files would be accidentally
added to the repository?





> There's no fundamental reason (other than it being a bit annoying to
> rename everything and update the code) we can't change it, either for
> all kunitconfig files, or just the checked-in ones, if that's
> preferred.
>
> -- David



-- 
Best Regards
Masahiro Yamada

  reply	other threads:[~2023-01-31  2:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-27 14:57 [PATCH v1 1/1] .gitignore: Unignore .kunitconfig Andy Shevchenko
2023-01-28  6:55 ` David Gow
2023-01-28 14:37   ` Masahiro Yamada
2023-01-31  0:00     ` David Gow
2023-01-31  2:11       ` Masahiro Yamada [this message]
2023-01-31  2:38         ` David Gow
2023-03-10 15:30 ` Andy Shevchenko
2023-03-31  8:18   ` David Gow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK7LNAR8D6E_md3=1dLAc-o73xmKXDRXv9Fi_hiav1VhPSW58w@mail.gmail.com' \
    --to=masahiroy@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=brendanhiggins@google.com \
    --cc=davidgow@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).