From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751382AbdECEhi (ORCPT ); Wed, 3 May 2017 00:37:38 -0400 Received: from conssluserg-01.nifty.com ([210.131.2.80]:52784 "EHLO conssluserg-01.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750737AbdECEhe (ORCPT ); Wed, 3 May 2017 00:37:34 -0400 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-01.nifty.com v434b91O008606 X-Nifty-SrcIP: [209.85.161.169] MIME-Version: 1.0 In-Reply-To: <20170414215450.18307-2-sthemmin@microsoft.com> References: <20170414215450.18307-1-sthemmin@microsoft.com> <20170414215450.18307-2-sthemmin@microsoft.com> From: Masahiro Yamada Date: Wed, 3 May 2017 13:37:08 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/2] kbuild: cleanup signing keys with mrproper To: Stephen Hemminger Cc: Michal Marek , Linux Kbuild mailing list , Linux Kernel Mailing List , Stephen Hemminger , David Woodhouse , David Howells Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +CC David Woodhouse +CC David Howells 2017-04-15 6:54 GMT+09:00 Stephen Hemminger : > When 'make mrproper' is run it was supposed to remove the signing > keys in the certs directory, but only the filename is given > rather than the pathanme which is necessary to cause cleanup. > > Signed-off-by: Stephen Hemminger > --- > Makefile | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Makefile b/Makefile > index efa267a92ba6..04ca211552f7 100644 > --- a/Makefile > +++ b/Makefile > @@ -1274,9 +1274,9 @@ MRPROPER_DIRS += include/config usr/include include/generated \ > arch/*/include/generated .tmp_objdiff > MRPROPER_FILES += .config .config.old .version .old_version \ > Module.symvers tags TAGS cscope* GPATH GTAGS GRTAGS GSYMS \ > - signing_key.pem signing_key.priv signing_key.x509 \ > - x509.genkey extra_certificates signing_key.x509.keyid \ > - signing_key.x509.signer vmlinux-gdb.py > + certs/signing_key.pem certs/signing_key.priv certs/signing_key.x509 \ > + certs/x509.genkey certs/extra_certificates certs/signing_key.x509.keyid \ > + certs/signing_key.x509.signer vmlinux-gdb.py > The logic seems quite simple, but I am not quite sure which file is still valid? [1] signing_key.pem - OK, this should be certs/signing_key.pem and removed by 'make mrproper' [2] signing_key.priv - deprecated by commit fb1179499134 ? [3] signing_key.x509 - OK, this should be certs/signing_key.x509 and removed by 'make mrproper' [4] x509.genkey - this is an intermediate file for generating signing_key.pem, but unneeded for installing external modules. Does it make more sense to delete this by 'make clean'? [5] extra_certificates - I am not sure where this is generated, and used [6] siging_key.x509.keyid - same as [5] [7] signing_key.x509.signer - same as [5] -- Best Regards Masahiro Yamada