From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5953AC1B0D9 for ; Fri, 4 Dec 2020 05:45:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 397CD22583 for ; Fri, 4 Dec 2020 05:45:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728175AbgLDFpT (ORCPT ); Fri, 4 Dec 2020 00:45:19 -0500 Received: from conssluserg-03.nifty.com ([210.131.2.82]:36204 "EHLO conssluserg-03.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728110AbgLDFpT (ORCPT ); Fri, 4 Dec 2020 00:45:19 -0500 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (authenticated) by conssluserg-03.nifty.com with ESMTP id 0B45iOHK014725; Fri, 4 Dec 2020 14:44:24 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-03.nifty.com 0B45iOHK014725 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1607060664; bh=GxQOUZTbjpTLY9LjOb5fkHKriTuvaD4ieHcqMtD0zU0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=R/YJZpM2TUDt4msXhrrmCenmQFK0SPqfC9vbu3g9nS1uDiYEMIty1jmuSbtOd2vYq oEYaisN/8FFUyC5kXvxyzAADam3yAGSM8Jv4U9iTASPKnyjhyopf5Q+b39tIHTGSCU KZ7J4dN8tnT06VbKOQ2ZprJsDd8Cv5pswud7Nh/uWxRgxXts+naYIWjIADLIcO7s5K Ej8G5+pa9LOo7URiBg4yREvuAij+MGPvFS5oXHYYGpclLh27KCxc8ZZUlGKiQWf522 EHVl1iaoIuUMext3AHN9LGrV0uf0SPa8lD1TjlonnkYekjiibvR+J9arhCRKRvkC19 33escYa1CP/5Q== X-Nifty-SrcIP: [209.85.210.179] Received: by mail-pf1-f179.google.com with SMTP id x24so2944563pfn.6; Thu, 03 Dec 2020 21:44:24 -0800 (PST) X-Gm-Message-State: AOAM532j3L5ujb0DxJ0+eDemsbIyiqWVmXq3grIzkhgMm+7hust/FdBR Zxjv1Ss0sQDVJMP8aFNMHg6/6SKLcPDAcHvCZq4= X-Google-Smtp-Source: ABdhPJwSYF2cWdLfL5qZiKxAtQSsH8nHXtNTwO15tGB6CNOA8wl/q/O5NzJ1suMu/FAzPoErqTxsjO3rMshMsV8gl/4= X-Received: by 2002:a62:e519:0:b029:197:bcec:7c0c with SMTP id n25-20020a62e5190000b0290197bcec7c0cmr2396899pff.63.1607060663618; Thu, 03 Dec 2020 21:44:23 -0800 (PST) MIME-Version: 1.0 References: <20200829051524.706585-1-masahiroy@kernel.org> In-Reply-To: <20200829051524.706585-1-masahiroy@kernel.org> From: Masahiro Yamada Date: Fri, 4 Dec 2020 14:43:46 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/3] ia64: clean-up header dependency and build process, fix build warning To: Tony Luck , Fenghua Yu , linux-ia64@vger.kernel.org Cc: Randy Dunlap , Linux Kbuild mailing list , Andrew Morton , Ard Biesheuvel , Arnd Bergmann , Dmitry Safonov <0x7f454c46@gmail.com>, afzal mohammed , linux-efi , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, IA64 maintainers, Could you check this series, please? The build warning is still remaining. On Sat, Aug 29, 2020 at 2:16 PM Masahiro Yamada wrote: > > > Randy Dunlap reports the following warning with CONFIG_IA64_PALINFO=m: > > ../scripts/Makefile.build:68: 'arch/ia64/kernel/palinfo.ko' will not be built even though obj-m is specified. > ../scripts/Makefile.build:69: You cannot use subdir-y/m to visit a module Makefile. Use obj-y/m instead. > > This comes from the fact Kbuild descends into arch/ia64/kernel/ twice. > > First, to generate , > Second, to build kernel and module objects. > > The warning is emitted in the first descend because it is not the > intended usage. > > I looked into the code closely, and noticed arch/ia64/kernel/nr-irqs.c > was not needed in the first place. > > It was separated out of arch/ia64/kernel/asm-offsets.c just because > was including too many bogus headers. > > IA64 is not actively maintained, and there exists unneeded obsolete code. > > The first two patches are the outcome when I played with ARCH=ia64 builds, > but not prerequisites for 3/3. Anyway I believe they are nice cleanups > and folded in this patch set. > > 3/3 is the important one to fix the false positive warning, > and it is a nice cleanup too. > > > > Masahiro Yamada (3): > ia64: do not typedef struct pal_min_state_area_s > ia64: remove unneeded header includes from > ia64: remove generated/nr-irqs.h generation to fix build warning > > arch/ia64/Makefile | 6 ------ > arch/ia64/include/asm/irq.h | 4 +++- > arch/ia64/include/asm/mca.h | 11 ++++------- > arch/ia64/include/asm/pal.h | 4 ++-- > arch/ia64/include/asm/sal.h | 2 +- > arch/ia64/kernel/Makefile | 5 ----- > arch/ia64/kernel/asm-offsets.c | 18 +++++++++--------- > arch/ia64/kernel/efi.c | 1 + > arch/ia64/kernel/mca.c | 5 +++-- > arch/ia64/kernel/mca_drv.c | 2 +- > arch/ia64/kernel/nr-irqs.c | 22 ---------------------- > 11 files changed, 24 insertions(+), 56 deletions(-) > delete mode 100644 arch/ia64/kernel/nr-irqs.c > > -- > 2.25.1 > -- Best Regards Masahiro Yamada