From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751256AbdCYOlE (ORCPT ); Sat, 25 Mar 2017 10:41:04 -0400 Received: from conssluserg-03.nifty.com ([210.131.2.82]:23774 "EHLO conssluserg-03.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750915AbdCYOlC (ORCPT ); Sat, 25 Mar 2017 10:41:02 -0400 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-03.nifty.com v2PEedPO015678 X-Nifty-SrcIP: [209.85.161.178] MIME-Version: 1.0 In-Reply-To: <20170324211330.0e463621@bbrezillon> References: <1490213273-8571-1-git-send-email-yamada.masahiro@socionext.com> <20170324211330.0e463621@bbrezillon> From: Masahiro Yamada Date: Sat, 25 Mar 2017 23:40:38 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RESEND PATCH v2 00/53] mtd: nand: denali: 2nd round of Denali NAND IP patch bomb To: Boris Brezillon Cc: linux-mtd@lists.infradead.org, Laurent Monat , thorsten.christiansson@idquantique.com, Enrico Jorns , Artem Bityutskiy , Dinh Nguyen , Marek Vasut , Graham Moore , David Woodhouse , Masami Hiramatsu , Chuanxiao Dong , Jassi Brar , devicetree@vger.kernel.org, Linux Kernel Mailing List , Brian Norris , Richard Weinberger , Cyrille Pitchen , Rob Herring , Mark Rutland Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Boris, 2017-03-25 5:13 GMT+09:00 Boris Brezillon : >> >> Masahiro Yamada (53): >> mtd: nand: allow to set only one of ECC size and ECC strength from DT >> mtd: nand: use read_oob() instead of cmdfunc() for bad block check >> mtd: nand: denali: remove unused CONFIG option and macros >> mtd: nand: denali: remove redundant define of BANK(x) >> mtd: nand: denali: remove more unused struct members >> mtd: nand: denali: fix comment of denali_nand_info::flash_mem >> mtd: nand: denali: consolidate INTR_STATUS__* and INTR_EN__* macros >> mtd: nand: denali: introduce capability flag >> mtd: nand: denali: use int where no reason to use fixed width variable >> mtd: nand: denali: fix erased page checking >> mtd: nand: denali: fix bitflips calculation in handle_ecc() >> mtd: nand: denali: support HW_ECC_FIXUP capability >> mtd: nand: denali_dt: enable HW_ECC_FIXUP for Altera SOCFPGA variant >> mtd: nand: denali: support 64bit capable DMA engine >> mtd: nand: denali_dt: remove dma-mask DT property >> mtd: nand: denali_dt: use pdev instead of ofdev for platform_device >> mtd: nand: denali: allow to override revision number >> mtd: nand: denali: use nand_chip to hold frequently accessed data >> mtd: nand: denali: call nand_set_flash_node() to set DT node >> mtd: nand: denali: do not set mtd->name >> mtd: nand: denali: move multi device fixup code to a helper function >> mtd: nand: denali: simplify multi device fixup code >> mtd: nand: denali: set DEVICES_CONNECTED 1 if not set >> mtd: nand: denali: remove meaningless writes to read-only registers >> mtd: nand: denali: remove unnecessary writes to ECC_CORRECTION >> mtd: nand: denali: support 1024 byte ECC step size >> mtd: nand: denali: avoid hard-coding ecc.strength and ecc.bytes >> mtd: nand: denali: support "nand-ecc-strength" DT property >> mtd: nand: denali: remove Toshiba and Hynix specific fixup code >> mtd: nand: denali_dt: add compatible strings for UniPhier SoC variants >> mtd: nand: denali: set NAND_ECC_CUSTOM_PAGE_ACCESS >> mtd: nand: denali: do not propagate NAND_STATUS_FAIL to waitfunc() >> mtd: nand: denali: use BIT() and GENMASK() for register macros >> mtd: nand: denali: remove unneeded find_valid_banks() >> mtd: nand: denali: handle timing parameters by setup_data_interface() >> mtd: nand: denali: remove meaningless pipeline read-ahead operation >> mtd: nand: denali: rework interrupt handling >> mtd: nand: denali: fix NAND_CMD_STATUS handling >> mtd: nand: denali: fix NAND_CMD_PARAM handling >> mtd: nand: do not check R/B# for CMD_READID in nand_command(_lp) >> mtd: nand: do not check R/B# for CMD_SET_FEATURES in nand_command(_lp) >> mtd: nand: denali: switch over to cmd_ctrl instead of cmdfunc >> mtd: nand: denali: fix bank reset function >> mtd: nand: denali: use interrupt instead of polling for bank reset >> mtd: nand: denali: propagate page to helpers via function argument >> mtd: nand: denali: merge struct nand_buf into struct denali_nand_info >> mtd: nand: denali: use flag instead of register macro for direction >> mtd: nand: denali: fix raw and oob accessors for syndrome page layout >> mtd: nand: denali: support hardware-assisted erased page detection >> mtd: nand: allocate aligned buffers if NAND_OWN_BUFFERS is unset >> mtd: nand: denali: skip driver internal bounce buffer when possible >> mtd: nand: denali: use non-managed kmalloc() for DMA buffer >> mtd: nand: denali: enable bad block table scan > > Applied patch 1 to 9, 40 and 41. I'll see what else I can apply so that > you don't have to re-post the remaining 42 patches, but I fear some of > them won't apply correctly without patch 10 on which I had comments. Thanks! This will be very helpful when sending the next version. If you like, you can also apply the following 9 patches cleanly in this order. 18/53 mtd: nand: denali: use nand_chip to hold frequently accessed data 19/53 mtd: nand: denali: call nand_set_flash_node() to set DT node 20/53 mtd: nand: denali: do not set mtd->name 21/53 mtd: nand: denali: move multi device fixup code to a helper function 22/53 mtd: nand: denali: simplify multi device fixup code 23/53 mtd: nand: denali: set DEVICES_CONNECTED 1 if not set 24/53 mtd: nand: denali: remove meaningless writes to read-only registers 25/53 mtd: nand: denali: remove unnecessary writes to ECC_CORRECTION 36/53 mtd: nand: denali: remove meaningless pipeline read-ahead operation These are less controversial, and have no dependency on 10/53-17/53. 50/53 "mtd: nand: allocate aligned buffers if NAND_OWN_BUFFERS is unset" is a change to the NAND framework. (used as a pre-requisite for 51/53) Surely no dependency on the others, but If you wait more for comments from other developers, that's no problem. I will update the commented parts, and hopefully send v3 next week. Thanks! -- Best Regards Masahiro Yamada