From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Laura Abbott <labbott@redhat.com>
Cc: Andy Lutomirski <luto@kernel.org>,
mjw@fedoraproject.org, "H . J . Lu" <hjl.tools@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
X86 ML <x86@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Nick Clifton <nickc@redhat.com>,
Cary Coutant <ccoutant@gmail.com>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>
Subject: Re: [RFCv2 PATCH 3/3] x86/vdso: Add build salt to the vDSO
Date: Mon, 7 May 2018 15:42:57 +0900 [thread overview]
Message-ID: <CAK7LNARS9ZrN=cUaZJkQQHwNc-nuBc6p0YYRhTgGecDbyiWN6g@mail.gmail.com> (raw)
In-Reply-To: <20180329180112.11055-4-labbott@redhat.com>
2018-03-30 3:01 GMT+09:00 Laura Abbott <labbott@redhat.com>:
> The vDSO is linked separately from the kernel and modules. Ensure it picks
> up the comment section, if available.
>
> Signed-off-by: Laura Abbott <labbott@redhat.com>
> ---
> v2: Updated name
> ---
> arch/x86/entry/vdso/vdso-layout.lds.S | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/x86/entry/vdso/vdso-layout.lds.S b/arch/x86/entry/vdso/vdso-layout.lds.S
> index acfd5ba7d943..7c78dd39aae8 100644
> --- a/arch/x86/entry/vdso/vdso-layout.lds.S
> +++ b/arch/x86/entry/vdso/vdso-layout.lds.S
> @@ -1,5 +1,6 @@
> /* SPDX-License-Identifier: GPL-2.0 */
> #include <asm/vdso.h>
> +#include <generated/build-salt.h>
>
> /*
> * Linker script for vDSO. This is an ELF shared object prelinked to
> @@ -95,6 +96,8 @@ SECTIONS
> .altinstructions : { *(.altinstructions) } :text
> .altinstr_replacement : { *(.altinstr_replacement) } :text
>
> + BUILD_ID_SALT
> +
> /DISCARD/ : {
> *(.discard)
> *(.discard.*)
> --
> 2.16.2
>
For consistency, I think '-T scripts/build-salt.lds'
should be passed to cmd_vdso
in arch/x86/entry/vdso/Makefile.
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2018-05-07 6:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-29 18:01 [RFCv2 PATCH 0/3] Salted build ids via linker sections Laura Abbott
2018-03-29 18:01 ` [RFCv2 PATCH 1/3] kbuild: Introduce build-salt generated header Laura Abbott
2018-03-29 18:01 ` [RFCv2 PATCH 2/3] kbuild: Link with generated build-salt header Laura Abbott
2018-05-07 6:38 ` Masahiro Yamada
2018-03-29 18:01 ` [RFCv2 PATCH 3/3] x86/vdso: Add build salt to the vDSO Laura Abbott
2018-05-07 6:42 ` Masahiro Yamada [this message]
2018-03-30 12:40 ` [RFCv2 PATCH 0/3] Salted build ids via linker sections Mark Wielaard
2018-05-07 6:58 ` Masahiro Yamada
2018-05-08 2:49 ` Andy Lutomirski
2018-05-14 20:51 ` Laura Abbott
2018-05-07 6:28 ` Masahiro Yamada
2018-05-14 21:02 ` Laura Abbott
2018-05-17 8:37 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK7LNARS9ZrN=cUaZJkQQHwNc-nuBc6p0YYRhTgGecDbyiWN6g@mail.gmail.com' \
--to=yamada.masahiro@socionext.com \
--cc=ccoutant@gmail.com \
--cc=hjl.tools@gmail.com \
--cc=labbott@redhat.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mjw@fedoraproject.org \
--cc=nickc@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).