From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE75EC352A3 for ; Tue, 11 Feb 2020 14:47:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7862F2082F for ; Tue, 11 Feb 2020 14:47:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581432453; bh=cVKOZJZcZejMymcRRIHndr9HBYGpN7fc3yqRknLTLFg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=kfjCiiATy6DETKoa5yO6EYud8G9ijdQnDuaPNzyxoQxMLZ9H7NWFWOWQ6/mC1bCTs A34OGb2KC9p/EcSpMADhUesRItNLcspNs+zYvSCxWchcPlk/z0WNo2vtnJ54F77vwa d68CuS3SuaoSdG+LFJmEJSszFg1Hx7cDcsbHMTd4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730248AbgBKOrc (ORCPT ); Tue, 11 Feb 2020 09:47:32 -0500 Received: from conssluserg-01.nifty.com ([210.131.2.80]:42840 "EHLO conssluserg-01.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727511AbgBKOrc (ORCPT ); Tue, 11 Feb 2020 09:47:32 -0500 Received: from mail-ua1-f51.google.com (mail-ua1-f51.google.com [209.85.222.51]) (authenticated) by conssluserg-01.nifty.com with ESMTP id 01BElErD023152; Tue, 11 Feb 2020 23:47:15 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-01.nifty.com 01BElErD023152 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1581432435; bh=eK4UEfP1oZq3xGwyYCFOa/ywH4zsvgqp7UQXXtIcfqs=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=crroNUFQPqc5SssgcTr9um9PNEZK2LvgAeaZkwnGSWhon21TAY4Tp5uZmJ2X8r1nX GGhnlMxrGyK7//gl8GrNAOKd5Gkts/LeSgIMQOIaCOT1r9BH6e6ehhmPZNMpGwYJQB wsj+5Hm5/YVm8ZPnqYG7lVQU+Tk10YW0pNH2nmbhzntPvycP3BPNcliqyXK2mbLab8 N0TN9jvUiIUgh/dkvOrLstIGUcBELQzEoayKMC+FDCu4ret7NfFRbG593PVhdGLneN Vf4jTBHirudUZqst9vtnbBkL2f39jTc/XdQbZZ1MvIgCnH1+h1t1AL2cyGbzDlaXxO 16YnFG/BXQBNQ== X-Nifty-SrcIP: [209.85.222.51] Received: by mail-ua1-f51.google.com with SMTP id w15so4041015uap.0; Tue, 11 Feb 2020 06:47:15 -0800 (PST) X-Gm-Message-State: APjAAAUeES/6yNFHUaxEIFsHkB3acpSzXa8A42rQ/J1Lr8ng7H04AtgD O/+3BoBHZHbHZtFLFbNKxZzkGUdRKUXv9VtM3zQ= X-Google-Smtp-Source: APXvYqzDPRbZecWv+oOo/Lrsuuq5Z7QghTxTaXBXXeUAt6x2WB0jCtkjC+HDS/jqpuSByLl+CoFvHPehizJkb1SyP4I= X-Received: by 2002:ab0:45c7:: with SMTP id u65mr3961359uau.109.1581432434139; Tue, 11 Feb 2020 06:47:14 -0800 (PST) MIME-Version: 1.0 References: <20200210161852.842-1-masahiroy@kernel.org> In-Reply-To: From: Masahiro Yamada Date: Tue, 11 Feb 2020 23:46:38 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] scripts/kallsyms: fix memory corruption caused by write over-run To: Justin Capella Cc: Linux Kbuild mailing list , youling257 , Pavel Machek , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi. On Tue, Feb 11, 2020 at 11:36 AM Justin Capella wrote: > > Looks like len is already +1, maybe it shouldn't be? This increment is for storing one more character, 'type'. sym->sym[0] = type; > > len = strlen(name) + 1; > > > > - sym = malloc(sizeof(*sym) + len); > > + sym = malloc(sizeof(*sym) + len + 1); This increment is for the '\0' termination. So, malloc() needs to allocate: sizeof(*sym) + strlen(name) + 2. > > > Maybe strlcpy or if len wasn't incremented? > > > > > - memcpy(sym_name(sym), name, len); > > + strcpy(sym_name(sym), name); > > -- Best Regards Masahiro Yamada