From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FBBFC31E49 for ; Wed, 19 Jun 2019 04:14:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DE3902082C for ; Wed, 19 Jun 2019 04:14:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nifty.com header.i=@nifty.com header.b="ch+ctMIk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726130AbfFSEOy (ORCPT ); Wed, 19 Jun 2019 00:14:54 -0400 Received: from conssluserg-02.nifty.com ([210.131.2.81]:48715 "EHLO conssluserg-02.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725562AbfFSEOy (ORCPT ); Wed, 19 Jun 2019 00:14:54 -0400 Received: from mail-ua1-f46.google.com (mail-ua1-f46.google.com [209.85.222.46]) (authenticated) by conssluserg-02.nifty.com with ESMTP id x5J4EgaU020701; Wed, 19 Jun 2019 13:14:43 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-02.nifty.com x5J4EgaU020701 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1560917683; bh=QX44iii4P2UFmWqWLSZMenrivHB0MmnMCrYU3gNIPx4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ch+ctMIkdk25F6gzZwKALUFenoSqbgauELK4ifFnyH4MQ17Sfb9nZL6//0M4Ao3gH v7M7zIxrIbrHcespNKYDo/hF2zYmhmWqKQCZ/eHTDpzVmMn1KCMfhm/m+aIK2DzQcK gk5S5c+++YAizb9zVCFQaP2zrvt9lyriCY8J16G/PghxGMAR9MyUi6ZoD0FkLNF+jL DmiR6d5RCGnSLlusH1zUnHO0pJygaSXvcBPY5OGqoUOkvXZgN5GDS/5/qKH2+S4qbo OQDLLxW2YKlRhQbbOqxfbN9JckNCtjq6LJYzP8wfAE7tlI5ZvlTGirSXX1MCwshBU1 cLXRPqEK8rMsA== X-Nifty-SrcIP: [209.85.222.46] Received: by mail-ua1-f46.google.com with SMTP id f20so8409476ual.0; Tue, 18 Jun 2019 21:14:43 -0700 (PDT) X-Gm-Message-State: APjAAAUJ+66aOng1LdDPmd8kiFjCBK2VXhB6zC2sAHqJSOZHNsHFNvOl p0mB+8QKTvdbPiQg8s5CpBEK2UcJTM0s/UTnEs8= X-Google-Smtp-Source: APXvYqxBotwh1SQcA96UGGzZy8r+gUOgx7aQvw27NlrCOkCpgVAmjGEbonICt0MXByl4qSQeU0pO/1xGh5cwGP03Fww= X-Received: by 2002:a9f:366b:: with SMTP id s40mr37751624uad.121.1560917682204; Tue, 18 Jun 2019 21:14:42 -0700 (PDT) MIME-Version: 1.0 References: <20190619132326.1846345b@canb.auug.org.au> In-Reply-To: From: Masahiro Yamada Date: Wed, 19 Jun 2019 13:14:06 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: linux-next: build failure after merge of the net-next tree To: Stephen Rothwell Cc: David Miller , Networking , Linux Next Mailing List , Linux Kernel Mailing List , Kevin Darbyshire-Bryant Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 19, 2019 at 1:02 PM Masahiro Yamada wrote: > > Hi. > > > On Wed, Jun 19, 2019 at 12:23 PM Stephen Rothwell wrote: > > > > Hi all, > > > > After merging the net-next tree, today's linux-next build (x86_64 > > allmodconfig) failed like this: > > > > In file included from usr/include/linux/tc_act/tc_ctinfo.hdrtest.c:1: > > ./usr/include/linux/tc_act/tc_ctinfo.h:30:21: error: implicit declaration of function 'BIT' [-Werror=implicit-function-declaration] > > CTINFO_MODE_DSCP = BIT(0), > > ^~~ > > ./usr/include/linux/tc_act/tc_ctinfo.h:30:2: error: enumerator value for 'CTINFO_MODE_DSCP' is not an integer constant > > CTINFO_MODE_DSCP = BIT(0), > > ^~~~~~~~~~~~~~~~ > > ./usr/include/linux/tc_act/tc_ctinfo.h:32:1: error: enumerator value for 'CTINFO_MODE_CPMARK' is not an integer constant > > }; > > ^ > > > > Caused by commit > > > > 24ec483cec98 ("net: sched: Introduce act_ctinfo action") > > > > Presumably exposed by commit > > > > b91976b7c0e3 ("kbuild: compile-test UAPI headers to ensure they are self-contained") > > > > from the kbuild tree. > > > My commit correctly blocked the broken UAPI header, Hooray! > > People export more and more headers that > are never able to compile in user-space. > > We must block new breakages from coming in. > > > BIT() is not exported to user-space > since it is not prefixed with underscore. > > > You can use _BITUL() in user-space, > which is available in include/uapi/linux/const.h > > I just took a look at include/uapi/linux/tc_act/tc_ctinfo.h I just wondered why the following can be compiled: struct tc_ctinfo { tc_gen; }; Then, I found 'tc_gen' is a macro. #define tc_gen \ __u32 index; \ __u32 capab; \ int action; \ int refcnt; \ int bindcnt What a hell. -- Best Regards Masahiro Yamada