* [PATCH] um: Include kbuild.h instead of duplicating its macros
@ 2017-04-03 19:54 Matthias Kaehlcke
2017-04-17 20:37 ` Matthias Kaehlcke
2017-05-03 20:54 ` Richard Weinberger
0 siblings, 2 replies; 5+ messages in thread
From: Matthias Kaehlcke @ 2017-04-03 19:54 UTC (permalink / raw)
To: Jeff Dike, Richard Weinberger, Thomas Gleixner, Ingo Molnar,
H . Peter Anvin
Cc: user-mode-linux-devel, user-mode-linux-user, linux-kernel,
Matthias Kaehlcke
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
arch/x86/um/shared/sysdep/kernel-offsets.h | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/arch/x86/um/shared/sysdep/kernel-offsets.h b/arch/x86/um/shared/sysdep/kernel-offsets.h
index 46a9df99f3c5..7e1d35b6ad5c 100644
--- a/arch/x86/um/shared/sysdep/kernel-offsets.h
+++ b/arch/x86/um/shared/sysdep/kernel-offsets.h
@@ -2,16 +2,9 @@
#include <linux/sched.h>
#include <linux/elf.h>
#include <linux/crypto.h>
+#include <linux/kbuild.h>
#include <asm/mman.h>
-#define DEFINE(sym, val) \
- asm volatile("\n->" #sym " %0 " #val : : "i" (val))
-
-#define BLANK() asm volatile("\n->" : : )
-
-#define OFFSET(sym, str, mem) \
- DEFINE(sym, offsetof(struct str, mem));
-
void foo(void)
{
#include <common-offsets.h>
--
2.12.2.564.g063fe858b8-goog
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] um: Include kbuild.h instead of duplicating its macros
2017-04-03 19:54 [PATCH] um: Include kbuild.h instead of duplicating its macros Matthias Kaehlcke
@ 2017-04-17 20:37 ` Matthias Kaehlcke
2017-04-18 7:44 ` Richard Weinberger
2017-05-03 20:54 ` Richard Weinberger
1 sibling, 1 reply; 5+ messages in thread
From: Matthias Kaehlcke @ 2017-04-17 20:37 UTC (permalink / raw)
To: Jeff Dike, Richard Weinberger, Thomas Gleixner, Ingo Molnar,
H . Peter Anvin
Cc: user-mode-linux-devel, user-mode-linux-user, linux-kernel,
Masahiro Yamada
El Mon, Apr 03, 2017 at 12:54:58PM -0700 Matthias Kaehlcke ha dit:
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
> arch/x86/um/shared/sysdep/kernel-offsets.h | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/arch/x86/um/shared/sysdep/kernel-offsets.h b/arch/x86/um/shared/sysdep/kernel-offsets.h
> index 46a9df99f3c5..7e1d35b6ad5c 100644
> --- a/arch/x86/um/shared/sysdep/kernel-offsets.h
> +++ b/arch/x86/um/shared/sysdep/kernel-offsets.h
> @@ -2,16 +2,9 @@
> #include <linux/sched.h>
> #include <linux/elf.h>
> #include <linux/crypto.h>
> +#include <linux/kbuild.h>
> #include <asm/mman.h>
>
> -#define DEFINE(sym, val) \
> - asm volatile("\n->" #sym " %0 " #val : : "i" (val))
> -
> -#define BLANK() asm volatile("\n->" : : )
> -
> -#define OFFSET(sym, str, mem) \
> - DEFINE(sym, offsetof(struct str, mem));
> -
> void foo(void)
> {
> #include <common-offsets.h>
> --
Ping, any comment on this patch?
Cheers
Matthias
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] um: Include kbuild.h instead of duplicating its macros
2017-04-17 20:37 ` Matthias Kaehlcke
@ 2017-04-18 7:44 ` Richard Weinberger
2017-04-18 8:17 ` Masahiro Yamada
0 siblings, 1 reply; 5+ messages in thread
From: Richard Weinberger @ 2017-04-18 7:44 UTC (permalink / raw)
To: Matthias Kaehlcke, Jeff Dike, Thomas Gleixner, Ingo Molnar,
H . Peter Anvin
Cc: user-mode-linux-devel, user-mode-linux-user, linux-kernel,
Masahiro Yamada
Matthias,
Am 17.04.2017 um 22:37 schrieb Matthias Kaehlcke:
> El Mon, Apr 03, 2017 at 12:54:58PM -0700 Matthias Kaehlcke ha dit:
>
>> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
>> ---
>> arch/x86/um/shared/sysdep/kernel-offsets.h | 9 +--------
>> 1 file changed, 1 insertion(+), 8 deletions(-)
>>
>> diff --git a/arch/x86/um/shared/sysdep/kernel-offsets.h b/arch/x86/um/shared/sysdep/kernel-offsets.h
>> index 46a9df99f3c5..7e1d35b6ad5c 100644
>> --- a/arch/x86/um/shared/sysdep/kernel-offsets.h
>> +++ b/arch/x86/um/shared/sysdep/kernel-offsets.h
>> @@ -2,16 +2,9 @@
>> #include <linux/sched.h>
>> #include <linux/elf.h>
>> #include <linux/crypto.h>
>> +#include <linux/kbuild.h>
>> #include <asm/mman.h>
>>
>> -#define DEFINE(sym, val) \
>> - asm volatile("\n->" #sym " %0 " #val : : "i" (val))
>> -
>> -#define BLANK() asm volatile("\n->" : : )
>> -
>> -#define OFFSET(sym, str, mem) \
>> - DEFINE(sym, offsetof(struct str, mem));
>> -
>> void foo(void)
>> {
>> #include <common-offsets.h>
>> --
>
> Ping, any comment on this patch?
Looks good, nothing exploded while a quick test.
I'll queue it for the next merge window. :-)
Thanks,
//richard
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] um: Include kbuild.h instead of duplicating its macros
2017-04-18 7:44 ` Richard Weinberger
@ 2017-04-18 8:17 ` Masahiro Yamada
0 siblings, 0 replies; 5+ messages in thread
From: Masahiro Yamada @ 2017-04-18 8:17 UTC (permalink / raw)
To: Richard Weinberger
Cc: Matthias Kaehlcke, Jeff Dike, Thomas Gleixner, Ingo Molnar,
H . Peter Anvin, user-mode-linux-devel, user-mode-linux-user,
Linux Kernel Mailing List
2017-04-18 16:44 GMT+09:00 Richard Weinberger <richard@nod.at>:
> Matthias,
>
> Am 17.04.2017 um 22:37 schrieb Matthias Kaehlcke:
>> El Mon, Apr 03, 2017 at 12:54:58PM -0700 Matthias Kaehlcke ha dit:
>>
>>> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
>>> ---
>>> arch/x86/um/shared/sysdep/kernel-offsets.h | 9 +--------
>>> 1 file changed, 1 insertion(+), 8 deletions(-)
>>>
>>> diff --git a/arch/x86/um/shared/sysdep/kernel-offsets.h b/arch/x86/um/shared/sysdep/kernel-offsets.h
>>> index 46a9df99f3c5..7e1d35b6ad5c 100644
>>> --- a/arch/x86/um/shared/sysdep/kernel-offsets.h
>>> +++ b/arch/x86/um/shared/sysdep/kernel-offsets.h
>>> @@ -2,16 +2,9 @@
>>> #include <linux/sched.h>
>>> #include <linux/elf.h>
>>> #include <linux/crypto.h>
>>> +#include <linux/kbuild.h>
>>> #include <asm/mman.h>
>>>
>>> -#define DEFINE(sym, val) \
>>> - asm volatile("\n->" #sym " %0 " #val : : "i" (val))
>>> -
>>> -#define BLANK() asm volatile("\n->" : : )
>>> -
>>> -#define OFFSET(sym, str, mem) \
>>> - DEFINE(sym, offsetof(struct str, mem));
>>> -
>>> void foo(void)
>>> {
>>> #include <common-offsets.h>
>>> --
>>
>> Ping, any comment on this patch?
>
> Looks good, nothing exploded while a quick test.
> I'll queue it for the next merge window. :-)
>
> Thanks,
> //richard
If not too late, please feel free to add my
Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] um: Include kbuild.h instead of duplicating its macros
2017-04-03 19:54 [PATCH] um: Include kbuild.h instead of duplicating its macros Matthias Kaehlcke
2017-04-17 20:37 ` Matthias Kaehlcke
@ 2017-05-03 20:54 ` Richard Weinberger
1 sibling, 0 replies; 5+ messages in thread
From: Richard Weinberger @ 2017-05-03 20:54 UTC (permalink / raw)
To: Matthias Kaehlcke
Cc: Jeff Dike, Richard Weinberger, Thomas Gleixner, Ingo Molnar,
H . Peter Anvin, user-mode-linux-devel, user-mode-linux-user,
LKML
On Mon, Apr 3, 2017 at 9:54 PM, Matthias Kaehlcke <mka@chromium.org> wrote:
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
> arch/x86/um/shared/sysdep/kernel-offsets.h | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/arch/x86/um/shared/sysdep/kernel-offsets.h b/arch/x86/um/shared/sysdep/kernel-offsets.h
> index 46a9df99f3c5..7e1d35b6ad5c 100644
> --- a/arch/x86/um/shared/sysdep/kernel-offsets.h
> +++ b/arch/x86/um/shared/sysdep/kernel-offsets.h
> @@ -2,16 +2,9 @@
> #include <linux/sched.h>
> #include <linux/elf.h>
> #include <linux/crypto.h>
> +#include <linux/kbuild.h>
> #include <asm/mman.h>
>
> -#define DEFINE(sym, val) \
> - asm volatile("\n->" #sym " %0 " #val : : "i" (val))
> -
> -#define BLANK() asm volatile("\n->" : : )
> -
> -#define OFFSET(sym, str, mem) \
> - DEFINE(sym, offsetof(struct str, mem));
> -
> void foo(void)
> {
> #include <common-offsets.h>
> --
> 2.12.2.564.g063fe858b8-goog
>
Applied.
--
Thanks,
//richard
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-05-03 20:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-03 19:54 [PATCH] um: Include kbuild.h instead of duplicating its macros Matthias Kaehlcke
2017-04-17 20:37 ` Matthias Kaehlcke
2017-04-18 7:44 ` Richard Weinberger
2017-04-18 8:17 ` Masahiro Yamada
2017-05-03 20:54 ` Richard Weinberger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).