From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <michal.lkml@markovi.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kbuild: remove old check for CFLAGS use
Date: Fri, 14 Sep 2018 22:06:54 +0900 [thread overview]
Message-ID: <CAK7LNARaKFfC_VR8HXWvMf7HQtP2b9YvHfH_WTLer0uGdkPVzg@mail.gmail.com> (raw)
In-Reply-To: <1536733082-19110-1-git-send-email-yamada.masahiro@socionext.com>
2018-09-12 15:18 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> This check has been here more than a decade since commit 0c53c8e6eb45
> ("kbuild: check for wrong use of CFLAGS").
>
> Enough time for migration has passed.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
Applied to linux-kbuild.
> scripts/Makefile.build | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/scripts/Makefile.build b/scripts/Makefile.build
> index 5a2d1c9..cb03774 100644
> --- a/scripts/Makefile.build
> +++ b/scripts/Makefile.build
> @@ -36,21 +36,11 @@ subdir-ccflags-y :=
>
> include scripts/Kbuild.include
>
> -# For backward compatibility check that these variables do not change
> -save-cflags := $(CFLAGS)
> -
> # The filename Kbuild has precedence over Makefile
> kbuild-dir := $(if $(filter /%,$(src)),$(src),$(srctree)/$(src))
> kbuild-file := $(if $(wildcard $(kbuild-dir)/Kbuild),$(kbuild-dir)/Kbuild,$(kbuild-dir)/Makefile)
> include $(kbuild-file)
>
> -# If the save-* variables changed error out
> -ifeq ($(KBUILD_NOPEDANTIC),)
> - ifneq ("$(save-cflags)","$(CFLAGS)")
> - $(error CFLAGS was changed in "$(kbuild-file)". Fix it to use ccflags-y)
> - endif
> -endif
> -
> include scripts/Makefile.lib
>
> # Do not include host rules unless needed
> --
> 2.7.4
>
--
Best Regards
Masahiro Yamada
prev parent reply other threads:[~2018-09-14 13:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 6:18 [PATCH] kbuild: remove old check for CFLAGS use Masahiro Yamada
2018-09-14 13:06 ` Masahiro Yamada [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNARaKFfC_VR8HXWvMf7HQtP2b9YvHfH_WTLer0uGdkPVzg@mail.gmail.com \
--to=yamada.masahiro@socionext.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).