From: Masahiro Yamada <masahiroy@kernel.org>
To: Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Michal Marek <michal.lkml@markovi.net>
Subject: Re: [PATCH] kbuild: show warning for 'make headers_check'
Date: Wed, 10 Mar 2021 00:29:57 +0900 [thread overview]
Message-ID: <CAK7LNARcrGJnoBuzC8mSJqAXPQjdTt-bC8EZEwNBTCTb=o3yQA@mail.gmail.com> (raw)
In-Reply-To: <20210302142614.505888-1-masahiroy@kernel.org>
On Tue, Mar 2, 2021 at 11:26 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> Since commit 7ecaf069da52 ("kbuild: move headers_check rule to
> usr/include/Makefile"), the headers_check target is no-op.
>
> This stub target is remaining here in case some scripts still invoke
> 'make headers_check'. In order to prompt people to remove stale code,
> show a noisy warning message if used. The stub will be really removed
> after the Linux 5.15 release.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
Applied to linux-kbuild.
>
> Makefile | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index f9b54da2fca0..a3336d9b4a22 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1339,7 +1339,11 @@ headers: $(version_h) scripts_unifdef uapi-asm-generic archheaders archscripts
> # Deprecated. It is no-op now.
> PHONY += headers_check
> headers_check:
> - @:
> + @echo >&2 "=================== WARNING ==================="
> + @echo >&2 "Since Linux 5.5, 'make headers_check' is no-op,"
> + @echo >&2 "and will be removed after Linux 5.15 release."
> + @echo >&2 "Please remove headers_check from your scripts."
> + @echo >&2 "==============================================="
>
> ifdef CONFIG_HEADERS_INSTALL
> prepare: headers
> --
> 2.27.0
>
--
Best Regards
Masahiro Yamada
prev parent reply other threads:[~2021-03-09 15:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-02 14:26 [PATCH] kbuild: show warning for 'make headers_check' Masahiro Yamada
2021-03-09 15:29 ` Masahiro Yamada [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK7LNARcrGJnoBuzC8mSJqAXPQjdTt-bC8EZEwNBTCTb=o3yQA@mail.gmail.com' \
--to=masahiroy@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).