From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7948EC2D0CE for ; Tue, 21 Jan 2020 15:44:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 44A0C207E0 for ; Tue, 21 Jan 2020 15:44:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579621468; bh=9+SqA3IKcvFv3ypoDeMjmD58qS3Q4mBVAGNFZGev1l8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=FvyWrEz/a1pe512HmrxkHeetWHK5PQArMMqdJ7JKaHpg0I7kzJacMrSPVpCtH7pXX ZxTSx4mqIV4LPwZhfjhgmuvMkbo1nW7tawooR2IlW87mDWdfjBaj4cJ95Jn5jZLX0M 3+hPNsMsm8Kt9DoFNuBW2YwEwjP9vZQmjra3sUc8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729366AbgAUPo1 (ORCPT ); Tue, 21 Jan 2020 10:44:27 -0500 Received: from conssluserg-05.nifty.com ([210.131.2.90]:44971 "EHLO conssluserg-05.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729017AbgAUPo0 (ORCPT ); Tue, 21 Jan 2020 10:44:26 -0500 Received: from mail-ua1-f44.google.com (mail-ua1-f44.google.com [209.85.222.44]) (authenticated) by conssluserg-05.nifty.com with ESMTP id 00LFi5Mr030302; Wed, 22 Jan 2020 00:44:06 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-05.nifty.com 00LFi5Mr030302 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1579621446; bh=ZtcJE4J/VnghOLG5BqGNTkLhqnSDrYqFSMA9B/PJv3k=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=22uMx27sxZ4iLBL3b5a2GCT1vzgo36uJ/LkCdpC+Q7rUalnLH5X93rBvfJ6r+Pom6 0o/uI4mds34zlVe9kLrre0jf42OJ0h6Gzs6WuXnE3PqgqJiehf0iyvPKh61HIb9reM BK6m+Iaq+nXKGZa35YP1Knxk4wopevX6IhVA76h5v+ep8FbEuU2JO402pv2ViHJIt9 7Iud1SK2G/mcT+9GzKuU/rxMhwmetJtvRMMv3bXSnuBWDiS8fgTXfAPaC8RNTslYjI ucrY32VBEYpSntsGXkqvTxzJ+9NFzMU9NSQRABiXCmgOsiY6dsEFA/WyMc11os2pwG p7Az2qT9YUBVA== X-Nifty-SrcIP: [209.85.222.44] Received: by mail-ua1-f44.google.com with SMTP id y3so1163058uae.3; Tue, 21 Jan 2020 07:44:06 -0800 (PST) X-Gm-Message-State: APjAAAUIX/hzPtjGqxcamIsKsUBtz/8JnpF32BOlP7pCQ7YfG0RAouv5 MCZ3SpbQ/fB7pbbHEmABw4EupSw5tXLktnGUuuA= X-Google-Smtp-Source: APXvYqxKN7+aDx4+rhRRBTGSg5TMBpRLbtTObTQdzxulxrRZeJxHYNHdH9TfFK4spH3h0GZVhCOVCIk1jgp5oP8+2Vg= X-Received: by 2002:ab0:7049:: with SMTP id v9mr3149137ual.95.1579621444684; Tue, 21 Jan 2020 07:44:04 -0800 (PST) MIME-Version: 1.0 References: <0274919c5e3b134df19d943f99cb7e84e5135ccd.1579248206.git.michal.simek@xilinx.com> In-Reply-To: <0274919c5e3b134df19d943f99cb7e84e5135ccd.1579248206.git.michal.simek@xilinx.com> From: Masahiro Yamada Date: Wed, 22 Jan 2020 00:43:28 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/2] asm-generic: Make dma-contiguous.h a mandatory include/asm header To: Michal Simek Cc: Linux Kernel Mailing List , Michal Simek , git@xilinx.com, Christoph Hellwig , Christoph Hellwig , Paul Burton , Arnd Bergmann , Borislav Petkov , linux-mips@vger.kernel.org, Thomas Gleixner , Catalin Marinas , "open list:SIFIVE DRIVERS" , linux-arch , linux-s390 , Palmer Dabbelt , X86 ML , Guo Ren , Kate Stewart , Wesley Terpstra , Greg Kroah-Hartman , Ralf Baechle , Paul Walmsley , Max Filippov , linux-xtensa@linux-xtensa.org, "H. Peter Anvin" , "Peter Zijlstra (Intel)" , Will Deacon , Christian Borntraeger , Deepa Dinamani , Chris Zankel , Ingo Molnar , Waiman Long , linux-arm-kernel , Albert Ou , Vasily Gorbik , James Hogan , Heiko Carstens Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi. On Fri, Jan 17, 2020 at 5:03 PM Michal Simek wrote: > > dma-continuguous.h is generic for all architectures except arm32 which has > its own version. Currently, is present for only architectures that select HAVE_DMA_CONTIGUOUS. After this commit, the other architectures will end up with generating the unused header. That would not be a big deal, but it could be mentioned in the commit message? > Similar change was done for msi.h by commit a1b39bae16a6 > ("asm-generic: Make msi.h a mandatory include/asm header") > > Suggested-by: Christoph Hellwig > Signed-off-by: Michal Simek > --- > > Changes in v2: > - New patch suggested by Christoph > > arch/arm64/include/asm/Kbuild | 1 - > arch/csky/include/asm/Kbuild | 1 - > arch/mips/include/asm/Kbuild | 1 - > arch/riscv/include/asm/Kbuild | 1 - > arch/s390/include/asm/Kbuild | 1 - > arch/x86/include/asm/Kbuild | 1 - > arch/xtensa/include/asm/Kbuild | 1 - > > include/asm-generic/Kbuild | 1 + > 8 files changed, 1 insertion(+), 7 deletions(-) > > diff --git a/arch/arm64/include/asm/Kbuild b/arch/arm64/include/asm/Kbuild > index bd23f87d6c55..d3077c991962 100644 > --- a/arch/arm64/include/asm/Kbuild > +++ b/arch/arm64/include/asm/Kbuild > @@ -3,7 +3,6 @@ generic-y += bugs.h > generic-y += delay.h > generic-y += div64.h > generic-y += dma.h > -generic-y += dma-contiguous.h > generic-y += dma-mapping.h > generic-y += early_ioremap.h > generic-y += emergency-restart.h > diff --git a/arch/csky/include/asm/Kbuild b/arch/csky/include/asm/Kbuild > index 4d4754e6bf89..bc15a26c782f 100644 > --- a/arch/csky/include/asm/Kbuild > +++ b/arch/csky/include/asm/Kbuild > @@ -7,7 +7,6 @@ generic-y += delay.h > generic-y += device.h > generic-y += div64.h > generic-y += dma.h > -generic-y += dma-contiguous.h > generic-y += dma-mapping.h > generic-y += emergency-restart.h > generic-y += exec.h > diff --git a/arch/mips/include/asm/Kbuild b/arch/mips/include/asm/Kbuild > index 61b0fc2026e6..179403ae5837 100644 > --- a/arch/mips/include/asm/Kbuild > +++ b/arch/mips/include/asm/Kbuild > @@ -6,7 +6,6 @@ generated-y += syscall_table_64_n64.h > generated-y += syscall_table_64_o32.h > generic-y += current.h > generic-y += device.h > -generic-y += dma-contiguous.h > generic-y += emergency-restart.h > generic-y += export.h > generic-y += irq_work.h > diff --git a/arch/riscv/include/asm/Kbuild b/arch/riscv/include/asm/Kbuild > index 1efaeddf1e4b..ec0ca8c6ab64 100644 > --- a/arch/riscv/include/asm/Kbuild > +++ b/arch/riscv/include/asm/Kbuild > @@ -7,7 +7,6 @@ generic-y += div64.h > generic-y += extable.h > generic-y += flat.h > generic-y += dma.h > -generic-y += dma-contiguous.h > generic-y += dma-mapping.h > generic-y += emergency-restart.h > generic-y += exec.h > diff --git a/arch/s390/include/asm/Kbuild b/arch/s390/include/asm/Kbuild > index 2531f673f099..1832ae6442ef 100644 > --- a/arch/s390/include/asm/Kbuild > +++ b/arch/s390/include/asm/Kbuild > @@ -7,7 +7,6 @@ generated-y += unistd_nr.h > generic-y += asm-offsets.h > generic-y += cacheflush.h > generic-y += device.h > -generic-y += dma-contiguous.h > generic-y += dma-mapping.h > generic-y += div64.h > generic-y += emergency-restart.h > diff --git a/arch/x86/include/asm/Kbuild b/arch/x86/include/asm/Kbuild > index 8b52bc5ddf69..ea34464d6221 100644 > --- a/arch/x86/include/asm/Kbuild > +++ b/arch/x86/include/asm/Kbuild > @@ -7,7 +7,6 @@ generated-y += unistd_32_ia32.h > generated-y += unistd_64_x32.h > generated-y += xen-hypercalls.h > > -generic-y += dma-contiguous.h > generic-y += early_ioremap.h > generic-y += export.h > generic-y += mcs_spinlock.h > diff --git a/arch/xtensa/include/asm/Kbuild b/arch/xtensa/include/asm/Kbuild > index 3acc31e55e02..271917c24b7f 100644 > --- a/arch/xtensa/include/asm/Kbuild > +++ b/arch/xtensa/include/asm/Kbuild > @@ -4,7 +4,6 @@ generic-y += bug.h > generic-y += compat.h > generic-y += device.h > generic-y += div64.h > -generic-y += dma-contiguous.h > generic-y += dma-mapping.h > generic-y += emergency-restart.h > generic-y += exec.h > diff --git a/include/asm-generic/Kbuild b/include/asm-generic/Kbuild > index ddfee1bd9dc1..cd17d50697cc 100644 > --- a/include/asm-generic/Kbuild > +++ b/include/asm-generic/Kbuild > @@ -4,5 +4,6 @@ > # (This file is not included when SRCARCH=um since UML borrows several > # asm headers from the host architecutre.) > > +mandatory-y += dma-contiguous.h > mandatory-y += msi.h > mandatory-y += simd.h > -- > 2.25.0 > -- Best Regards Masahiro Yamada