Re: [PATCH] scripts: update the comments of kallsyms support

[Masahiro Yamada <masahiroy@kernel.org>]

On Fri, Oct 8, 2021 at 8:25 PM Hui Su <suhui_kernel@163.com> wrote:
>
> update the comments of kallsyms support
>
> Signed-off-by: Hui Su <suhui_kernel@163.com>
> ---

I added

Fixes: af73d78bd384 ("kbuild: Remove debug info from kallsyms linking")


Applied to linux-kbuild. Thanks.




>  scripts/link-vmlinux.sh | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh
> index d74cee5c4326..a98c4f045302 100755
> --- a/scripts/link-vmlinux.sh
> +++ b/scripts/link-vmlinux.sh
> @@ -369,14 +369,14 @@ if [ -n "${CONFIG_KALLSYMS}" ]; then
>         # kallsyms support
>         # Generate section listing all symbols and add it into vmlinux
>         # It's a three step process:
> -       # 1)  Link .tmp_vmlinux1 so it has all symbols and sections,
> +       # 1)  Link .tmp_vmlinux.kallsyms1 so it has all symbols and sections,
>         #     but __kallsyms is empty.
>         #     Running kallsyms on that gives us .tmp_kallsyms1.o with
>         #     the right size
> -       # 2)  Link .tmp_vmlinux2 so it now has a __kallsyms section of
> +       # 2)  Link .tmp_vmlinux.kallsyms2 so it now has a __kallsyms section of
>         #     the right size, but due to the added section, some
>         #     addresses have shifted.
> -       #     From here, we generate a correct .tmp_kallsyms2.o
> +       #     From here, we generate a correct .tmp_vmlinux.kallsyms2.o
>         # 3)  That link may have expanded the kernel image enough that
>         #     more linker branch stubs / trampolines had to be added, which
>         #     introduces new names, which further expands kallsyms. Do another
> --
> 2.25.1
>
>


-- 
Best Regards
Masahiro Yamada