From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64853C43441 for ; Thu, 29 Nov 2018 11:47:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8D74A205C9 for ; Thu, 29 Nov 2018 11:47:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nifty.com header.i=@nifty.com header.b="vN4RZ/39" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8D74A205C9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=socionext.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728053AbeK2WwZ (ORCPT ); Thu, 29 Nov 2018 17:52:25 -0500 Received: from conssluserg-03.nifty.com ([210.131.2.82]:57621 "EHLO conssluserg-03.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726736AbeK2WwZ (ORCPT ); Thu, 29 Nov 2018 17:52:25 -0500 Received: from mail-vs1-f44.google.com (mail-vs1-f44.google.com [209.85.217.44]) (authenticated) by conssluserg-03.nifty.com with ESMTP id wATBlBvr016243; Thu, 29 Nov 2018 20:47:12 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-03.nifty.com wATBlBvr016243 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1543492032; bh=LjdfDPbnmz4VV5cNPPitHindzrHkJCEMqaI1B72Emm8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=vN4RZ/39OUGIwY4sO9yrYESTBSQorKUdHTkphghOnAjfBiqtQzT6A9NS/lIqiEDnf TIGiFIYlNW3VRj6qC4FJapF859FPeYFkHNaRL1EC7Kf6HPcVFAcuxGL37TAlwYL3rb 9kFMn4P/G9z8HPChhznN9juXEcgvzDMODXAw9nyKdy6g8i3Mj13MIfJIwTcRXIDlMM +f9diXC/wXjUihNq+CqhIomfcR9YTC2H7qithnPFg17P+UZfLs6j1M32szzZZoMUio eGRvrmUQ5r6RchB5C6WqbM4wgf1WPhgFGEE6iubt8GDL4f9prMV+JHUInZJE1kSN2X V8s06IUVY8i6A== X-Nifty-SrcIP: [209.85.217.44] Received: by mail-vs1-f44.google.com with SMTP id e7so952162vsc.2; Thu, 29 Nov 2018 03:47:11 -0800 (PST) X-Gm-Message-State: AA+aEWbvyl/kRYh09f+t2vX7AsdlMtJgEQhSNDSJCO5u2bqiZZCYAy18 2OTiNJ7a0PlMC2o91nNO7YqHZDnAlOM302+fC7o= X-Google-Smtp-Source: AFSGD/X3n/GDOUB8HeHslwf+rQXFcSWMAq3opoZjZRd0j3sEU7f7dBrcuMg92k7kH9iAGRZmjMfT7f7cz8VnJ2s67Zs= X-Received: by 2002:a67:485:: with SMTP id 127mr471709vse.54.1543492030904; Thu, 29 Nov 2018 03:47:10 -0800 (PST) MIME-Version: 1.0 References: <20181003213100.189959-1-namit@vmware.com> <20181007091805.GA30687@zn.tnic> <20181007132228.GJ29268@gate.crashing.org> <20181008073128.GL29268@gate.crashing.org> <20181009145330.GT29268@gate.crashing.org> In-Reply-To: <20181009145330.GT29268@gate.crashing.org> From: Masahiro Yamada Date: Thu, 29 Nov 2018 20:46:34 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: PROPOSAL: Extend inline asm syntax with size spec To: Segher Boessenkool , Nadav Amit , Ingo Molnar , "H. Peter Anvin" Cc: rguenther@suse.de, matz@suse.de, Borislav Petkov , gcc@gcc.gnu.org, Linux Kernel Mailing List , X86 ML , Sam Ravnborg , Alok Kataria , Christopher Li , Greg Kroah-Hartman , Jan Beulich , Josh Poimboeuf , Juergen Gross , Kate Stewart , Kees Cook , linux-sparse@vger.kernel.org, "Peter Zijlstra (Intel)" , Philippe Ombredanne , Thomas Gleixner , virtualization@lists.linux-foundation.org, Linus Torvalds , Chris Zankel , Max Filippov , linux-xtensa@linux-xtensa.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi. On Wed, Oct 10, 2018 at 1:14 AM Segher Boessenkool wrote: > > On Mon, Oct 08, 2018 at 11:07:46AM +0200, Richard Biener wrote: > > On Mon, 8 Oct 2018, Segher Boessenkool wrote: > > > On Sun, Oct 07, 2018 at 03:53:26PM +0000, Michael Matz wrote: > > > > On Sun, 7 Oct 2018, Segher Boessenkool wrote: > > > > > On Sun, Oct 07, 2018 at 11:18:06AM +0200, Borislav Petkov wrote: > > > > > > Now, Richard suggested doing something like: > > > > > > > > > > > > 1) inline asm ("...") > > > > > > > > > > What would the semantics of this be? > > > > > > > > The size of the inline asm wouldn't be counted towards the inliner size > > > > limits (or be counted as "1"). > > > > > > That sounds like a good option. > > > > Yes, I also like it for simplicity. It also avoids the requirement > > of translating the number (in bytes?) given by the user to > > "number of GIMPLE instructions" as needed by the inliner. > > This patch implements this, for C only so far. And the syntax is > "asm inline", which is more in line with other syntax. > > How does this look? Thank you very much for your work. https://gcc.gnu.org/ml/gcc-patches/2018-10/msg01932.html How is the progress of this in GCC ML? I am really hoping the issue will be solved by compiler instead of the in-kernel workaround. Since commit 77b0bf55bc675233d22cd5df97605d516d64525e, DISTCC breakage was reported. Then, another problem showed up. Debian linux-headers package is broken due to missing arch/x86/kernel/macros.s https://www.spinics.net/lists/linux-kbuild/msg20037.html The kernel-devel RPM package is broken as well. More fundamentally, the external module building itself is broken; 'make clean' must keep all files needed for external modules, but *.s files are all gone. Of course, we can fix the problems at the cost of uglifying Makefiles. I wrote a patch to fix the external module building and packages, and now have it in hand locally. But, I'd like to ask if x86 people want to keep this macros.s approach. Revert 77b0bf55bc675 right now assuming the compiler will eventually solve the issue? Do you have ideas? Comments? -- Best Regards Masahiro Yamada