From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D674EC04A6B for ; Mon, 13 May 2019 02:28:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A4973208C0 for ; Mon, 13 May 2019 02:28:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nifty.com header.i=@nifty.com header.b="P+lQyPvT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727445AbfEMC2X (ORCPT ); Sun, 12 May 2019 22:28:23 -0400 Received: from conssluserg-04.nifty.com ([210.131.2.83]:59012 "EHLO conssluserg-04.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727311AbfEMC2X (ORCPT ); Sun, 12 May 2019 22:28:23 -0400 Received: from mail-vs1-f49.google.com (mail-vs1-f49.google.com [209.85.217.49]) (authenticated) by conssluserg-04.nifty.com with ESMTP id x4D2S32G020024; Mon, 13 May 2019 11:28:03 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-04.nifty.com x4D2S32G020024 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1557714483; bh=mKVTMOpXJZy0RBYuveQeK3SC7Jv9ekJhYPaluqciiaU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=P+lQyPvTAMnh+TzsBqaX0nwerSmK/DrRoaAELUB/2lFhf783YzpA0qJNOliC72ihA 6MisFcer9iU5mDrM6fkbJG/MftKW49dRuXoXPgbcZaKpCWkRFPeEQPRf8OV+ciZlmy 9daiw6LuktXkJrXz7YUbSWrEjH2WfzEBYA255Phcjd1maYZDpPWbexSKsgP0RCyOFC bLBCKagTcYNt8mxXn4Zz4NaIyUQmHawLX5BjjgeMSjFcnJl2WCJ+QaDUiPpS0mlnF6 Jc6NimZmEclYsB6xpchyHWeL/PRw8Y9HbLUvdmxFPTZbtlXMpw20EV4bTG0xQzexHX z67nqQXql4tDQ== X-Nifty-SrcIP: [209.85.217.49] Received: by mail-vs1-f49.google.com with SMTP id v9so7046410vse.5; Sun, 12 May 2019 19:28:03 -0700 (PDT) X-Gm-Message-State: APjAAAWGmqEvUFvGAAQAdspRTqtwWJUKEo56BV4FLTsQn+VZpRcrkpjy /Oi8KMzqurjEGqAtLfx3XxzMbHVNq2fdMJwJsYY= X-Google-Smtp-Source: APXvYqyAkrFnURFlA7U3xveznlZxTCNXWwXEiVNn7STSnMKFZ7bossR+ykdWC8HLMnT9NAp8kXh8D19ost6K0aNHYzs= X-Received: by 2002:a67:fc4:: with SMTP id 187mr12256595vsp.215.1557714482609; Sun, 12 May 2019 19:28:02 -0700 (PDT) MIME-Version: 1.0 References: <20190509073555.15545-1-yamada.masahiro@socionext.com> In-Reply-To: <20190509073555.15545-1-yamada.masahiro@socionext.com> From: Masahiro Yamada Date: Mon, 13 May 2019 11:27:26 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] kbuild: terminate Kconfig when $(CC) or $(LD) is missing To: Linux Kbuild mailing list Cc: Joel Stanley , Michal Marek , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 9, 2019 at 4:36 PM Masahiro Yamada wrote: > > If the compiler specified by $(CC) is not present, the Kconfig stage > sprinkles 'not found' messages, then succeeds. > > $ make CROSS_COMPILE=foo defconfig > /bin/sh: 1: foogcc: not found > /bin/sh: 1: foogcc: not found > *** Default configuration is based on 'x86_64_defconfig' > ./scripts/gcc-version.sh: 17: ./scripts/gcc-version.sh: foogcc: not found > ./scripts/gcc-version.sh: 18: ./scripts/gcc-version.sh: foogcc: not found > ./scripts/gcc-version.sh: 19: ./scripts/gcc-version.sh: foogcc: not found > ./scripts/gcc-version.sh: 17: ./scripts/gcc-version.sh: foogcc: not found > ./scripts/gcc-version.sh: 18: ./scripts/gcc-version.sh: foogcc: not found > ./scripts/gcc-version.sh: 19: ./scripts/gcc-version.sh: foogcc: not found > ./scripts/clang-version.sh: 11: ./scripts/clang-version.sh: foogcc: not found > ./scripts/gcc-plugin.sh: 11: ./scripts/gcc-plugin.sh: foogcc: not found > init/Kconfig:16:warning: 'GCC_VERSION': number is invalid > # > # configuration written to .config > # > > Terminate parsing files immediately if $(CC) or $(LD) is not found. > "make *config" will fail more nicely. > > $ make CROSS_COMPILE=foo defconfig > *** Default configuration is based on 'x86_64_defconfig' > scripts/Kconfig.include:34: compiler 'foogcc' not found > make[1]: *** [scripts/kconfig/Makefile;82: defconfig] Error 1 > make: *** [Makefile;557: defconfig] Error 2 > > Signed-off-by: Masahiro Yamada > --- Applied to linux-kbuild. > Makefile | 2 +- > scripts/Kconfig.include | 8 ++++++++ > 2 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index 28965187c528..bd7ae11947cb 100644 > --- a/Makefile > +++ b/Makefile > @@ -537,7 +537,7 @@ endif > # Some architectures define CROSS_COMPILE in arch/$(SRCARCH)/Makefile. > # CC_VERSION_TEXT is referenced from Kconfig (so it needs export), > # and from include/config/auto.conf.cmd to detect the compiler upgrade. > -CC_VERSION_TEXT = $(shell $(CC) --version | head -n 1) > +CC_VERSION_TEXT = $(shell $(CC) --version 2>/dev/null | head -n 1) > > ifeq ($(config-targets),1) > # =========================================================================== > diff --git a/scripts/Kconfig.include b/scripts/Kconfig.include > index 87ff1dcc6bd5..0b267fb27f07 100644 > --- a/scripts/Kconfig.include > +++ b/scripts/Kconfig.include > @@ -18,6 +18,10 @@ if-success = $(shell,{ $(1); } >/dev/null 2>&1 && echo "$(2)" || echo "$(3)") > # Return y if exits with 0, n otherwise > success = $(if-success,$(1),y,n) > > +# $(failure,) > +# Return n if exits with 0, y otherwise > +failure = $(if-success,$(1),n,y) > + > # $(cc-option,) > # Return y if the compiler supports , n otherwise > cc-option = $(success,$(CC) -Werror $(1) -E -x c /dev/null -o /dev/null) > @@ -26,5 +30,9 @@ cc-option = $(success,$(CC) -Werror $(1) -E -x c /dev/null -o /dev/null) > # Return y if the linker supports , n otherwise > ld-option = $(success,$(LD) -v $(1)) > > +# check if $(CC) and $(LD) exist > +$(error-if,$(failure,command -v $(CC)),compiler '$(CC)' not found) > +$(error-if,$(failure,command -v $(LD)),linker '$(LD)' not found) > + > # gcc version including patch level > gcc-version := $(shell,$(srctree)/scripts/gcc-version.sh $(CC)) > -- > 2.17.1 > -- Best Regards Masahiro Yamada