From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B29E0C43612 for ; Tue, 15 Jan 2019 14:59:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 80B9A20656 for ; Tue, 15 Jan 2019 14:59:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nifty.com header.i=@nifty.com header.b="y6LjAJFc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730538AbfAOO7G (ORCPT ); Tue, 15 Jan 2019 09:59:06 -0500 Received: from conssluserg-04.nifty.com ([210.131.2.83]:43898 "EHLO conssluserg-04.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727307AbfAOO7G (ORCPT ); Tue, 15 Jan 2019 09:59:06 -0500 Received: from mail-vk1-f182.google.com (mail-vk1-f182.google.com [209.85.221.182]) (authenticated) by conssluserg-04.nifty.com with ESMTP id x0FEwelM014392; Tue, 15 Jan 2019 23:58:40 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-04.nifty.com x0FEwelM014392 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1547564321; bh=8UDmBSl+gjzoSWclaFcvO3xDYwUdpY9ay/TXvDz5OEM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=y6LjAJFcPAOXNvCm5WIxLGO/FoW3ZcPy2YXBYrMXY5HxNMwPZUaxpAHXTyy5Dud9j j//GPp8jtJZxZoQCvWz0CeneAlXC9cljgtWhSafPY9punWcOc70oLO1mkbElO3k/Wk iCzLasb5Ssxy3jZjvA8uzTtQFNtzXOt6HwYGtBAXgFKkdA2Z56HbuB1eKm9QaK89o2 sKy5mODeQGlhnkE69rFtpVe58MnQSmg+nRR0skpg8VTvt9D8s0db9nLRG/QMwvJuKI C5ceXamv/fzCcoF9rH9QE/Ykgg/ZoqcXxhWYh/l90JbOqJ4Xe/JBcrQJDNg4lY+j/G Kfe+C/rfAzArA== X-Nifty-SrcIP: [209.85.221.182] Received: by mail-vk1-f182.google.com with SMTP id 197so660379vkf.4; Tue, 15 Jan 2019 06:58:40 -0800 (PST) X-Gm-Message-State: AJcUukc+WSOHMJG4iFxdsA3vYdtgZ6LqrV7dukSX8/So5W1FI2m1rId6 8RZTpSY41l7O/M6Ez2kGz8ZqCXebnSfwZ5KPjXc= X-Google-Smtp-Source: ALg8bN6AhjSqVLCYdHcGvvdOgCSQLWIaZZAKNEz68MSaIKAyf8HD/9Czf7kruZpGeJOiOC6pBlub1zAcmMUN1ZRbips= X-Received: by 2002:a1f:4d47:: with SMTP id a68mr1640605vkb.34.1547564319674; Tue, 15 Jan 2019 06:58:39 -0800 (PST) MIME-Version: 1.0 References: <1547536740-1572-1-git-send-email-yamada.masahiro@socionext.com> In-Reply-To: From: Masahiro Yamada Date: Tue, 15 Jan 2019 23:58:03 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] kbuild: mark prepare0 as PHONY to fix external module build To: Mathieu Malaterre Cc: linux-kbuild , Michal Marek , Samuel Holland , Alexey Kardashevskiy , Ard Biesheuvel , LKML , "linux-stable # v4 . 20" , linuxppc-dev Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 15, 2019 at 7:35 PM Mathieu Malaterre wrote: > > On Tue, Jan 15, 2019 at 8:22 AM Masahiro Yamada > wrote: > > > > Commit c3ff2a5193fa ("powerpc/32: add stack protector support") > > caused kernel panic on PowerPC if an external module is used with > > CONFIG_STACKPROTECTOR because the 'prepare' target was not executed > > for the external module build. > > > > Commit e07db28eea38 ("kbuild: fix single target build for external > > module") turned it into a build error because the 'prepare' target is > > now executed but the 'prepare0' target is missing for the external > > module build. > > > > External module on arm/arm64 with CONFIG_STACKPROTECTOR_PER_TASK is > > also broken in the same way. > > > > Move 'PHONY += prepare0' to the common place. Make is fine with missing > > rule for phony targets. > > > > I minimize the change so it can be easily backported to 4.20.x > > > > To fix v4.20 for external modules of PowerPC, please backport > > e07db28eea38 ("kbuild: fix single target build for external module"), > > and then this commit. > > > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=201891 > > Fixes: e07db28eea38 ("kbuild: fix single target build for external module") > > Fixes: c3ff2a5193fa ("powerpc/32: add stack protector support") > > Fixes: 189af4657186 ("ARM: smp: add support for per-task stack canaries") > > Fixes: 0a1213fa7432 ("arm64: enable per-task stack canaries") > > Cc: linux-stable # v4.20 > > Reported-by: Samuel Holland > > Reported-by: Alexey Kardashevskiy > > Signed-off-by: Masahiro Yamada > > --- > > > > Makefile | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/Makefile b/Makefile > > index 499b968..789b332 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -955,6 +955,7 @@ ifdef CONFIG_STACK_VALIDATION > > endif > > endif > > > > +PHONY += prepare0 > > > > ifeq ($(KBUILD_EXTMOD),) > > core-y += kernel/ certs/ mm/ fs/ ipc/ security/ crypto/ block/ > > @@ -1061,8 +1062,7 @@ scripts: scripts_basic scripts_dtc > > # archprepare is used in arch Makefiles and when processed asm symlink, > > # version.h and scripts_basic is processed / created. > > > > -# Listed in dependency order > > The above comment may need to be tweaked a bit The comment is wrong irrespective of this patch, and less important. Do you have any suggestion how to tweak it? > > -PHONY += prepare archprepare prepare0 prepare1 prepare2 prepare3 > > +PHONY += prepare archprepare prepare1 prepare2 prepare3 > > > > # prepare3 is used to check if we are building in a separate output directory, > > # and if so do: > > -- > > 2.7.4 > > -- Best Regards Masahiro Yamada