From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Paul Burton <paul.burton@mips.com>
Cc: "linux-kbuild@vger.kernel.org" <linux-kbuild@vger.kernel.org>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Paul Burton <pburton@wavecomp.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Nicholas Piggin <npiggin@gmail.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] kbuild: Disable LD_DEAD_CODE_DATA_ELIMINATION with ftrace & GCC <= 4.7
Date: Fri, 11 Jan 2019 11:15:22 +0900 [thread overview]
Message-ID: <CAK7LNAS-r4gZOxdJCNaQwHtOYbxHbdupu57qncWkE+bhGfb_7g@mail.gmail.com> (raw)
In-Reply-To: <20190110181106.otlwmiznvq2l67iv@pburton-laptop>
On Fri, Jan 11, 2019 at 3:11 AM Paul Burton <paul.burton@mips.com> wrote:
>
> Hi Masahiro,
>
> On Thu, Jan 10, 2019 at 11:00:49AM +0900, Masahiro Yamada wrote:
> > On Thu, Jan 10, 2019 at 8:16 AM Paul Burton <paul.burton@mips.com> wrote:
> > > When building using GCC 4.7 or older, -ffunction-sections & the -pg flag
> > > used by ftrace are incompatible. This causes warnings or build failures
> > > (where -Werror applies) such as the following:
> > >
> > > arch/mips/generic/init.c:
> > > error: -ffunction-sections disabled; it makes profiling impossible
> > >
> > > This used to be taken into account by the ordering of calls to cc-option
> > > from within the top-level Makefile, which was introduced by commit
> > > 90ad4052e85c ("kbuild: avoid conflict between -ffunction-sections and
> > > -pg on gcc-4.7"). Unfortunately this was broken when the
> > > CONFIG_LD_DEAD_CODE_DATA_ELIMINATION cc-option check was moved to
> > > Kconfig in commit e85d1d65cd8a ("kbuild: test dead code/data elimination
> > > support in Kconfig"), because the flags used by this check no longer
> > > include -pg.
> > >
> > > Fix this by not allowing CONFIG_LD_DEAD_CODE_DATA_ELIMINATION to be
> > > enabled at the same time as ftrace/CONFIG_FUNCTION_TRACER when building
> > > using GCC 4.7 or older.
> > >
> > > Signed-off-by: Paul Burton <paul.burton@mips.com>
> > > Fixes: e85d1d65cd8a ("kbuild: test dead code/data elimination support in Kconfig")
> > > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > > Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
> > > Cc: Nicholas Piggin <npiggin@gmail.com>
> > > Cc: stable@vger.kernel.org # v4.19+
> > > ---
> > > init/Kconfig | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/init/Kconfig b/init/Kconfig
> > > index d47cb77a220e..c787f782148d 100644
> > > --- a/init/Kconfig
> > > +++ b/init/Kconfig
> > > @@ -1124,6 +1124,7 @@ config LD_DEAD_CODE_DATA_ELIMINATION
> > > bool "Dead code and data elimination (EXPERIMENTAL)"
> > > depends on HAVE_LD_DEAD_CODE_DATA_ELIMINATION
> > > depends on EXPERT
> > > + depends on !FUNCTION_TRACER || !CC_IS_GCC || GCC_VERSION >= 40800
> > > depends on $(cc-option,-ffunction-sections -fdata-sections)
> > > depends on $(ld-option,--gc-sections)
> > > help
> >
> > Thanks for the fix.
> >
> > I prefer this explicit 'depends on'.
> >
> > Relying on the order of $(call cc-option, ...) in Makefile is fragile.
> >
> > We raise the compiler minimum version from time to time.
> > So, this 'depends on' will eventually go away in the future.
> >
> > BTW, which one do you think more readable?
> >
> > depends on !FUNCTION_TRACER || !CC_IS_GCC || GCC_VERSION >= 40800
> >
> > OR
> >
> > depends on !(FUNCTION_TRACER && CC_IS_GCC && GCC_VERSION < 40800)
>
> Thanks - yes I agree it's nice that this is more explicit than the
> ordering we previously relied upon.
>
> I personally don't mind either of the 2 options above - let me know if
> you'd like me to submit a v2 using your second option.
>
> Thanks,
> Paul
Personally, I slightly prefer this:
depends on !(FUNCTION_TRACER && CC_IS_GCC && GCC_VERSION < 40800)
It is more consistent with your patch title:
"Disable LD_DEAD_CODE_DATA_ELIMINATION with ftrace & GCC <= 4.7"
May I ask v2?
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2019-01-11 2:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-08 8:48 Build regressions/improvements in v5.0-rc1 Geert Uytterhoeven
2019-01-08 9:01 ` Geert Uytterhoeven
2019-01-09 23:16 ` [PATCH] kbuild: Disable LD_DEAD_CODE_DATA_ELIMINATION with ftrace & GCC <= 4.7 Paul Burton
2019-01-10 2:00 ` Masahiro Yamada
2019-01-10 18:11 ` Paul Burton
2019-01-11 2:15 ` Masahiro Yamada [this message]
2019-01-11 19:06 ` [PATCH v2] " Paul Burton
2019-01-13 3:54 ` Masahiro Yamada
2019-01-14 0:03 ` Build regressions/improvements in v5.0-rc1 Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNAS-r4gZOxdJCNaQwHtOYbxHbdupu57qncWkE+bhGfb_7g@mail.gmail.com \
--to=yamada.masahiro@socionext.com \
--cc=geert@linux-m68k.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=npiggin@gmail.com \
--cc=paul.burton@mips.com \
--cc=pburton@wavecomp.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).