From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751629AbcGPP2J (ORCPT ); Sat, 16 Jul 2016 11:28:09 -0400 Received: from conssluserg-03.nifty.com ([210.131.2.82]:25043 "EHLO conssluserg-03.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751463AbcGPP2H (ORCPT ); Sat, 16 Jul 2016 11:28:07 -0400 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-03.nifty.com u6GFRcIQ017161 X-Nifty-SrcIP: [209.85.161.171] MIME-Version: 1.0 In-Reply-To: <20160713223433.GA20475@mwanda> References: <20160713223433.GA20475@mwanda> From: Masahiro Yamada Date: Sun, 17 Jul 2016 00:27:37 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [patch] kconfig: Add some missing curly braces To: Dan Carpenter Cc: "Yann E. MORIN" , "Luis R. Rodriguez" , Linux Kbuild mailing list , Linux Kernel Mailing List , kernel-janitors@vger.kernel.org, Michal Marek Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2016-07-14 7:34 GMT+09:00 Dan Carpenter : > There are missing curly braces here so we print some stuff to stderr > which we hadn't intended. > > Fixes: 1c199f2878f6 ('kbuild: document recursive dependency limitation / resolution') > Signed-off-by: Dan Carpenter > > diff --git a/scripts/kconfig/symbol.c b/scripts/kconfig/symbol.c > index 2432298..ff0feab 100644 > --- a/scripts/kconfig/symbol.c > +++ b/scripts/kconfig/symbol.c > @@ -1127,11 +1127,12 @@ static void sym_check_print_recursive(struct symbol *last_sym) > break; > } > } > - if (stack->sym == last_sym) > + if (stack->sym == last_sym) { > fprintf(stderr, "%s:%d:error: recursive dependency detected!\n", > prop->file->name, prop->lineno); > fprintf(stderr, "For a resolution refer to Documentation/kbuild/kconfig-language.txt\n"); > fprintf(stderr, "subsection \"Kconfig recursive dependency limitations\"\n"); > + } > if (stack->expr) { > fprintf(stderr, "%s:%d:\tsymbol %s %s value contains %s\n", > prop->file->name, prop->lineno, Good catch! BTW, another solution is to concatenate three messages into one. if (stack->sym == last_sym) fprintf(stderr, "%s:%d:error: recursive dependency detected!\n" "For a resolution refer to Documentation/kbuild/kconfig-language.txt\n" "subsection \"Kconfig recursive dependency limitations\"\n", prop->file->name, prop->lineno); Personally, I prefer this. It may be a matter of taste, though. -- Best Regards Masahiro Yamada