From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 269D0C433F5 for ; Thu, 3 Mar 2022 00:02:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229944AbiCCADe (ORCPT ); Wed, 2 Mar 2022 19:03:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230012AbiCCADX (ORCPT ); Wed, 2 Mar 2022 19:03:23 -0500 Received: from conssluserg-04.nifty.com (conssluserg-04.nifty.com [210.131.2.83]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34CDB205E0; Wed, 2 Mar 2022 16:02:38 -0800 (PST) Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) (authenticated) by conssluserg-04.nifty.com with ESMTP id 2230255c029376; Thu, 3 Mar 2022 09:02:06 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-04.nifty.com 2230255c029376 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1646265726; bh=1GjC9yWawG+f9/7QP15mK3z9L/3WiA7vCZuCL3HZ/ck=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=NKGLhqH/8mKIE4g16dYZk/L6M7ik/8e6QSzSPnBskQWr+t4IVxZpgOewQNsjXIUQs 3k9zOisBbUOsWN5JeeFBvPJnxny+kgqGydth9aNTxDjutVWV1phP/poVez4DzDV+YQ Olxupv1WEVnbZsxLxcCtrvOF9gJwlNtdxtjhLzjGfdg+xD34W67yirbOBVwUWQJxT5 APM+OwypDnmPKXewHxcmM0z/EJoYUYxnqx7ZoaUketWqPeIiEIeOUNiVdrC1IgxyKp PcXOqG80ErZdSkqNiX4fN9auVaMTnuPcFvB7Xiz+CwXlcWxggzMmmqjC3TlroHFDI/ 7OxcpgDqUO1+w== X-Nifty-SrcIP: [209.85.215.176] Received: by mail-pg1-f176.google.com with SMTP id o8so3010598pgf.9; Wed, 02 Mar 2022 16:02:05 -0800 (PST) X-Gm-Message-State: AOAM532nSsXtVlxZAVTgh4TdqF2PrwQthnfaGuwkvijrJq7Tk/QyDhZr bOFMmQJRwFrAEUa6nEVAK/z1FYJoCfgDNKiyKac= X-Google-Smtp-Source: ABdhPJzczkt6XTF1gd+/tMp7E2XEb5DrYtXsH1n4BNIFbWW6DCaFDFVyXHX09r9xlLxr6aZAyW4lJSxqyBndLDNhDtw= X-Received: by 2002:a63:e758:0:b0:378:8511:cfe7 with SMTP id j24-20020a63e758000000b003788511cfe7mr17071801pgk.126.1646265725034; Wed, 02 Mar 2022 16:02:05 -0800 (PST) MIME-Version: 1.0 References: <20220226123755.85213-1-masahiroy@kernel.org> In-Reply-To: From: Masahiro Yamada Date: Thu, 3 Mar 2022 09:01:22 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] kconfig: change .config format to use =n instead of "is not set" To: Boris Kolpackov Cc: Linux Kbuild mailing list , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 2, 2022 at 10:17 PM Boris Kolpackov wrote: > > Masahiro Yamada writes: > > > With this commit, Kconfig will output disable options in a more natural > > form, "CONFIG_FOO=n". > > While I agree with the overall direction, I was wondering how this > relates to string and int/hex options. It appears that they either > have a value or are not written to the .config at all, for example, > if the option is disabled via the `depends on` attribute. At first > I thought this would be inconsistent (i.e., =n for bool and omitted > for string), but it appears a disabled bool option is also omitted. > Hopefully the fact that sometimes a false bool option is =n and > sometimes it's omitted won't surprise anyone. Options with unmet 'depends on' are all omitted in the .config It is consistent for all types. > > Reviewed-by: Boris Kolpackov -- Best Regards Masahiro Yamada