From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 656D9C5B578 for ; Thu, 4 Jul 2019 00:43:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 33255218A3 for ; Thu, 4 Jul 2019 00:43:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nifty.com header.i=@nifty.com header.b="Qw5x5vW+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727021AbfGDAn6 (ORCPT ); Wed, 3 Jul 2019 20:43:58 -0400 Received: from conssluserg-05.nifty.com ([210.131.2.90]:30930 "EHLO conssluserg-05.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726550AbfGDAn5 (ORCPT ); Wed, 3 Jul 2019 20:43:57 -0400 Received: from mail-vk1-f170.google.com (mail-vk1-f170.google.com [209.85.221.170]) (authenticated) by conssluserg-05.nifty.com with ESMTP id x640hfs5007948; Thu, 4 Jul 2019 09:43:42 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-05.nifty.com x640hfs5007948 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1562201022; bh=YEglfdV6gwtLpwefdXYa4i8HSGcTtqk+NU8k5bljqhg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Qw5x5vW+HodXAsAM9eWx3LsERWErLbDHquz+/fNNvOizzhYBpWG6Wcg7/DpeJQx94 ousyH9k2gTLYlzvRSsSFBjOBLNC8UA78HsYGaBP+YZgg/DdZQWZPixX6la/rEVtUJB rRBlI4we8YDrikrXsG4S3EDpJieEMFpTMqZUtsYB9V1KY1yafQhZ9WgUY3Kt+w/tr2 TCFxYZzaTLr3G7upREzePgw9jNb2HTSBFFTabaz0mm48hK64k/QMPApQki6w88MaEl t14mn3q/7pBm/7qd8xyFmeHhpJKjJ3M5Ym6XWod4QDobzripQuwCjCt7/sCMeFX698 FbzFHhib2sstQ== X-Nifty-SrcIP: [209.85.221.170] Received: by mail-vk1-f170.google.com with SMTP id g124so301546vkd.1; Wed, 03 Jul 2019 17:43:42 -0700 (PDT) X-Gm-Message-State: APjAAAUyTLLQOiFNMkHux7LMeJuPlZf9y2gLzwtZFZJOXM06FD/cwrhC sb/0jEg9wXv5SGAIJkITS8RzeEKdzDq30ZAhgnE= X-Google-Smtp-Source: APXvYqwTIxDogC/SIRRHuAggdytqIbbtVGJ6ZbmryGi7Bqodet01ybGaLvoRyZFlQniP0SXM6NV/EYHc5F00hR1vxas= X-Received: by 2002:a1f:728b:: with SMTP id n133mr1331102vkc.84.1562201021033; Wed, 03 Jul 2019 17:43:41 -0700 (PDT) MIME-Version: 1.0 References: <1560752096-1323-1-git-send-email-Cedric_Hombourger@mentor.com> In-Reply-To: <1560752096-1323-1-git-send-email-Cedric_Hombourger@mentor.com> From: Masahiro Yamada Date: Thu, 4 Jul 2019 09:43:04 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] builddeb: generate multi-arch friendly linux-libc-dev package To: Cedric Hombourger Cc: isar-users@googlegroups.com, Michal Marek , Linux Kbuild mailing list , Linux Kernel Mailing List , Ben Hutchings , Riku Voipio Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org CCed a couple of people. On Mon, Jun 17, 2019 at 3:15 PM Cedric Hombourger wrote: > > Debian-based distributions place libc header files in a machine > specific directory (/usr/include/) instead of > /usr/include/asm to support installation of the linux-libc-dev > package from multiple architectures. Move headers installed by > "make headers_install" accordingly. > > Signed-off-by: Cedric Hombourger > Reviewed-by: Henning Schild > --- > scripts/package/builddeb | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/scripts/package/builddeb b/scripts/package/builddeb > index b03dd56a4782..8f7afb3a84e9 100755 > --- a/scripts/package/builddeb > +++ b/scripts/package/builddeb > @@ -132,6 +132,11 @@ fi > if [ "$ARCH" != "um" ]; then > $MAKE -f $srctree/Makefile headers_check > $MAKE -f $srctree/Makefile headers_install INSTALL_HDR_PATH="$libc_headers_dir/usr" > + # move asm headers to /usr/include//asm to match the structure > + # used by Debian-based distros (to support multi-arch) > + libc_mach=$($CC -dumpmachine) > + mkdir $libc_headers_dir/usr/include/$libc_mach > + mv $libc_headers_dir/usr/include/asm $libc_headers_dir/usr/include/$libc_mach/ > fi > > # Install the maintainer scripts I am not sure but, I just worried about the backward compatibility... Was this previously broken? I guess debian is using own control file instead of the one in upstream kernel. So, this is almost a matter for developers, I think. How did debian-base distros managed this before, and will this introduce no breakage? Ben, Could you comment on this? -- Best Regards Masahiro Yamada