From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Joel Stanley <joel@jms.id.au>,
Michael Ellerman <mpe@ellerman.id.au>,
Michal Marek <michal.lkml@markovi.net>,
dja@axtens.net,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH v2 1/2] Makefile: Export clang toolchain variables
Date: Tue, 13 Nov 2018 14:16:40 +0900 [thread overview]
Message-ID: <CAK7LNASE=xCaE-q_Jke5aDd9aF=dJ+ThUjORLa0i_m3e6UzUig@mail.gmail.com> (raw)
In-Reply-To: <CAKwvOdnBMFYXvS+GH0cUiczgkpLWtBinPRjkTJBQGrKjxktUUg@mail.gmail.com>
On Tue, Nov 13, 2018 at 3:56 AM Nick Desaulniers
<ndesaulniers@google.com> wrote:
>
> On Sun, Nov 11, 2018 at 8:21 PM Joel Stanley <joel@jms.id.au> wrote:
> >
> > The powerpc makefile will use these in it's boot wrapper.
> >
> > Signed-off-by: Joel Stanley <joel@jms.id.au>
> > ---
> > Makefile | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Makefile b/Makefile
> > index 09278330282d..840efe6eb54c 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -495,6 +495,7 @@ endif
> > ifneq ($(GCC_TOOLCHAIN),)
> > CLANG_FLAGS += --gcc-toolchain=$(GCC_TOOLCHAIN)
> > endif
> > +export CLANG_FLAGS
> > CLANG_FLAGS += -no-integrated-as
>
> Does this export CLANG_FLAGS before `-no-integrated-as` is set?
This does not matter.
For example, KBUILD_CFLAGS accumulates several compiler flags
after it is marked as 'export'.
> Either way, I think it would be clearer to export this after all the
> relevant flags are set.
OK. It is just a matter of preference,
but I will move the export line below
when I pick up this patch set.
> > KBUILD_CFLAGS += $(CLANG_FLAGS)
> > KBUILD_AFLAGS += $(CLANG_FLAGS)
> > --
> > 2.19.1
> >
>
>
> --
> Thanks,
> ~Nick Desaulniers
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2018-11-13 5:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-12 4:21 [PATCH v2 0/2] powerpc/boot: Fix cross compiling with clang Joel Stanley
2018-11-12 4:21 ` [PATCH v2 1/2] Makefile: Export clang toolchain variables Joel Stanley
2018-11-12 18:55 ` Nick Desaulniers
2018-11-13 5:16 ` Masahiro Yamada [this message]
2018-11-13 23:34 ` Masahiro Yamada
2018-11-12 4:21 ` [PATCH v2 2/2] powerpc/boot: Set target when cross-compiling for clang Joel Stanley
2018-11-12 11:14 ` Michael Ellerman
2018-11-12 19:03 ` Nick Desaulniers
2018-11-13 23:25 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK7LNASE=xCaE-q_Jke5aDd9aF=dJ+ThUjORLa0i_m3e6UzUig@mail.gmail.com' \
--to=yamada.masahiro@socionext.com \
--cc=dja@axtens.net \
--cc=joel@jms.id.au \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=michal.lkml@markovi.net \
--cc=mpe@ellerman.id.au \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).