From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
Lihao Liang <lianglihao@huawei.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Philippe Ombredanne <pombredanne@nexb.com>,
Pekka Enberg <penberg@kernel.org>
Subject: Re: [PATCH 3/3] types: use fixed width types without double-underscore prefix
Date: Wed, 16 May 2018 15:59:01 +0900 [thread overview]
Message-ID: <CAK7LNASHZpTW5VWOPdEqwuACN_K7HNKjar51iTbb-Y6+cJwCyw@mail.gmail.com> (raw)
In-Reply-To: <20180516062623.GA32694@kroah.com>
2018-05-16 15:26 GMT+09:00 Greg Kroah-Hartman <gregkh@linuxfoundation.org>:
> On Wed, May 16, 2018 at 10:07:50AM +0900, Masahiro Yamada wrote:
>> Hi Andrew,
>>
>> 2018-05-16 7:59 GMT+09:00 Andrew Morton <akpm@linux-foundation.org>:
>> > On Tue, 15 May 2018 11:22:05 +0900 Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
>> >
>> >> This header file is not exported. It is safe to reference types
>> >> without double-underscore prefix.
>> >>
>> >
>> > It may be safe to do this, but why is it desirable?
>>
>>
>> It is shorter. That's all.
>> If it is a noise commit, please feel free to drop it.
>>
>>
>> BTW, a large amount of kernel-space code
>> uses underscore-prefixed types.
>
> Sometimes it can/should do that.
I agree that UAPI headers must do that.
If you mean "it should even for non-exported code",
I have no idea why.
>> I wonder if we could check it by checkpatch.pl or something...
>
> You do understand the difference between the two types and why/when they
> are needed, right? I don't think checkpatch.pl can determine if data is
> coming from userspace or not very easily to make this a simple perl
> script check :(
I am getting puzzled...
It sounds like you are talking about __user or __kernel.
If so, it is a matter of sparse tool
but I believe it is a different topic.
If I understand correctly,
using 'u32' is safe outside of 'include/uapi/' and
arch/$(SRCARCH)/include/uapi/
Why can't a simple script do that?
Am I missing something?
> thanks,
>
> greg k-h
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2018-05-16 6:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-15 2:22 [PATCH 1/3] int-ll64.h: define u{8,16,32,64} and s{8,16,32,64} based on uapi header Masahiro Yamada
2018-05-15 2:22 ` [PATCH 2/3] types: define aligned_ types " Masahiro Yamada
2018-05-15 2:22 ` [PATCH 3/3] types: use fixed width types without double-underscore prefix Masahiro Yamada
2018-05-15 22:59 ` Andrew Morton
2018-05-16 1:07 ` Masahiro Yamada
2018-05-16 6:26 ` Greg Kroah-Hartman
2018-05-16 6:59 ` Masahiro Yamada [this message]
2018-05-16 7:52 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNASHZpTW5VWOPdEqwuACN_K7HNKjar51iTbb-Y6+cJwCyw@mail.gmail.com \
--to=yamada.masahiro@socionext.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=lianglihao@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@kernel.org \
--cc=pombredanne@nexb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).