From: Masahiro Yamada <masahiroy@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Liam Beguin <liambeguin@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-iio@vger.kernel.org, Peter Rosin <peda@axentia.se>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
KUnit Development <kunit-dev@googlegroups.com>
Subject: Re: kbuild problem: ERROR: modpost: missing MODULE_LICENSE() in drivers/iio/afe/iio-rescale.o
Date: Sat, 21 May 2022 13:14:53 +0900 [thread overview]
Message-ID: <CAK7LNASMOqfjHsE82ErjeYOJjxHgD_HZcm1VUcESORS6UridWw@mail.gmail.com> (raw)
In-Reply-To: <6601a387-de9a-a0d0-11b5-01e0cfa75657@infradead.org>
On Sat, May 21, 2022 at 12:51 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> Ok, one more.
> [also adding Liam here]
>
> On 5/20/22 20:17, Randy Dunlap wrote:
> >
> >
> > On 5/20/22 20:08, Randy Dunlap wrote:
> >>
> >>
> >> On 5/20/22 19:40, Randy Dunlap wrote:
> >>> Hi,
> >>>
> >>> In March I reported that a randconfig build complained:
> >>>
> >>> ERROR: modpost: missing MODULE_LICENSE() in drivers/iio/afe/iio-rescale.o
> >>>
> >>> (https://lore.kernel.org/all/16509fb6-e40c-e31b-2c80-264c44b0beb9@infradead.org/)
> >>>
> >>> I am still seeing this problem so I tried to dig into it a bit.
> >>> However, I don't see why get_next_modinfo() and friends don't find the
> >>> MODULE_LICENSE() since it is in the iio-rescale.o file.
> >>>
> >>> (BTW, I see this build error on many different $ARCH [around 15 tested]
> >>> and with 2 different versions of GCC.)
> >>>
> >>> Q1: Is modpost checking both vmlinux and iio-rescale.o for modinfo license
> >>> strings?
> >>>
> >>> It looks like it is, because it appears (?) that modpost is looking at
> >>> drivers/iio/test/iio-test-rescale.o (<<<<< a kunit test, which is builtin
> >>> in my .config) and at drivers/iio/afe/iio-rescale.o (which is built as a
> >>> loadable module).
> >>>
> >>> Is this confusing modpost?
> >>> I renamed drivers/iio/afe/iio-rescale.c to afe-rescale.c and changed its
> >>> Makefile entry accordingly and the MODULE_LICENSE error goes away.
> >>
> >> Oh well. This rename causes drivers/iio/test/iio-test-rescale.c to have
> >> build errors, so that's not a solution, just some info...
> >
> > and that was due to not updating drivers/iio/test/Makefile.
> > When that is done, the missing MODULE_LICENSE() is back in afe-rescale.o.
> >
> >>
> >>> Is this a modpost error or is kunit messing things up?
> >>>
> >>> thanks for looking.
>
> Does this look OK? It allows afe/iio-rescale.o to build XOR
> test/iio-rescale.o (not both of them).
>
> --- a/drivers/iio/test/Kconfig
> +++ b/drivers/iio/test/Kconfig
> @@ -6,7 +6,7 @@
> # Keep in alphabetical order
> config IIO_RESCALE_KUNIT_TEST
> bool "Test IIO rescale conversion functions"
> - depends on KUNIT=y && !IIO_RESCALE
> + depends on KUNIT=y && IIO_RESCALE=n
> default KUNIT_ALL_TESTS
> help
> If you want to run tests on the iio-rescale code say Y here.
>
>
> --
> ~Randy
As you may have already noticed,
the root cause is drivers/iio/test/Makefile
obj-$(CONFIG_IIO_RESCALE_KUNIT_TEST) += iio-test-rescale.o ../afe/iio-rescale.o
For the combination of
CONFIG_IIO_RESCALE=m
CONFIG_IIO_RESCALE_KUNIT_TEST=y,
drivers/iio/afe/iio-rescale.o is built twice;
as modular by drivers/iio/afe/Makefile, and
as built-in by drivers/iio/test/Makefile.
That's why MODULE_LICENSE() is lost.
I think your solution will work
although this Makefile is not recommended.
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2022-05-21 4:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-21 2:40 kbuild problem: ERROR: modpost: missing MODULE_LICENSE() in drivers/iio/afe/iio-rescale.o Randy Dunlap
2022-05-21 3:08 ` Randy Dunlap
2022-05-21 3:17 ` Randy Dunlap
2022-05-21 3:51 ` Randy Dunlap
2022-05-21 4:14 ` Masahiro Yamada [this message]
2022-05-21 5:39 ` Randy Dunlap
2022-05-26 15:36 ` Randy Dunlap
2022-05-26 16:04 ` Liam Beguin
2022-05-26 20:04 ` Randy Dunlap
2022-05-29 21:20 ` Liam Beguin
2022-05-30 0:17 ` Randy Dunlap
2022-05-30 2:37 ` Masahiro Yamada
2022-05-21 4:12 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNASMOqfjHsE82ErjeYOJjxHgD_HZcm1VUcESORS6UridWw@mail.gmail.com \
--to=masahiroy@kernel.org \
--cc=kunit-dev@googlegroups.com \
--cc=liambeguin@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=peda@axentia.se \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).