From: Masahiro Yamada <masahiroy@kernel.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Michal Marek <michal.lkml@markovi.net>,
Vincent Guittot <vincent.guittot@linaro.org>,
David Gibson <david@gibson.dropbear.id.au>,
Frank Rowand <frowand.list@gmail.com>,
Michal Simek <michal.simek@xilinx.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Anmar Oueja <anmar.oueja@linaro.org>,
Bill Mills <bill.mills@linaro.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V11 3/5] kbuild: Allow .dtso format for overlay source files
Date: Wed, 10 Mar 2021 20:29:57 +0900 [thread overview]
Message-ID: <CAK7LNAST04XTt7Y0DnSADHgAw-zy61HUcRJSyYRvy2rGHMdn4A@mail.gmail.com> (raw)
In-Reply-To: <CAK7LNASACr5EaG9j5c-eD3bYxKgrisb60Z3Qy7UsyS-i9YjORg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1940 bytes --]
On Wed, Mar 10, 2021 at 8:24 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> On Wed, Mar 10, 2021 at 2:35 PM Viresh Kumar <viresh.kumar@linaro.org> wrote:
> >
> > Since the overlays dtb files are now named as .dtbo, there is a lot of
> > interest in similarly naming the overlay source dts files as .dtso.
> >
> > This patch makes the necessary changes to allow .dtso format for overlay
> > source files.
> >
> > Note that we still support generating .dtbo files from .dts files. This
> > is required for the source files present in drivers/of/unittest-data/,
> > because they can't be renamed to .dtso as they are used for some runtime
> > testing as well.
> >
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> > ---
> > scripts/Makefile.lib | 9 ++++++++-
> > 1 file changed, 8 insertions(+), 1 deletion(-)
> >
> > diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> > index bc045a54a34e..59e86f67f9e0 100644
> > --- a/scripts/Makefile.lib
> > +++ b/scripts/Makefile.lib
> > @@ -339,7 +339,7 @@ $(obj)/%.dtb.S: $(obj)/%.dtb FORCE
> >
> > quiet_cmd_dtc = DTC $@
> > cmd_dtc = $(HOSTCC) -E $(dtc_cpp_flags) -x assembler-with-cpp -o $(dtc-tmp) $< ; \
> > - $(DTC) -O $(patsubst .%,%,$(suffix $@)) -o $@ -b 0 \
> > + $(DTC) -I dts -O $(patsubst .%,%,$(suffix $@)) -o $@ -b 0 \
>
> Even without "-I dts",
>
> inform = guess_input_format(arg, "dts");
>
> seems to fall back to "dts" anyway,
> but I guess you wanted to make this explicit, correct?
>
> I will drop the ugly -O.
> https://patchwork.kernel.org/project/linux-kbuild/patch/20210310110824.782209-1-masahiroy@kernel.org/
>
> I will queue it to linux-kbuild/fixes.
>
>
BTW, is the attached patch good for DTC?
I do not know when '-O dtbo' is useful,
unless I am missing something.
--
Best Regards
Masahiro Yamada
[-- Attachment #2: 0001-dtc-Remove-O-dtbo-support.patch --]
[-- Type: text/x-patch, Size: 927 bytes --]
From eeac710289a22397c6ae4e90a9334c4f7e178688 Mon Sep 17 00:00:00 2001
From: Masahiro Yamada <masahiroy@kernel.org>
Date: Wed, 10 Mar 2021 19:48:05 +0900
Subject: [PATCH] dtc: Remove -O dtbo support
This partially reverts 163f0469bf2e ("dtc: Allow overlays to have
.dtbo extension").
I do not understand why we need to support "dtbo" as --out-format.
*.dtb and *.dtbo have the same format, "dtb".
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
dtc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/dtc.c b/dtc.c
index 838c5df..3962d3f 100644
--- a/dtc.c
+++ b/dtc.c
@@ -359,8 +359,6 @@ int main(int argc, char *argv[])
#endif
} else if (streq(outform, "dtb")) {
dt_to_blob(outf, dti, outversion);
- } else if (streq(outform, "dtbo")) {
- dt_to_blob(outf, dti, outversion);
} else if (streq(outform, "asm")) {
dt_to_asm(outf, dti, outversion);
} else if (streq(outform, "null")) {
--
2.27.0
next prev parent reply other threads:[~2021-03-10 11:31 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 5:35 [PATCH V11 0/5] dt: Add fdtoverlay rule and statically build unittest Viresh Kumar
2021-03-10 5:35 ` [PATCH V11 1/5] kbuild: Simplify builds with CONFIG_OF_ALL_DTBS Viresh Kumar
2021-03-10 5:35 ` [PATCH V11 2/5] kbuild: Add generic rule to apply fdtoverlay Viresh Kumar
2021-03-10 5:35 ` [PATCH V11 3/5] kbuild: Allow .dtso format for overlay source files Viresh Kumar
2021-03-10 11:24 ` Masahiro Yamada
2021-03-10 11:29 ` Masahiro Yamada [this message]
2021-03-10 14:48 ` Viresh Kumar
2021-03-10 15:18 ` Masahiro Yamada
2021-03-12 3:52 ` Viresh Kumar
2021-03-10 14:47 ` Viresh Kumar
2021-03-10 15:15 ` Masahiro Yamada
2021-03-10 22:42 ` Frank Rowand
2021-03-12 4:47 ` Viresh Kumar
2021-03-12 7:03 ` Frank Rowand
2021-03-12 7:09 ` Frank Rowand
2021-03-12 7:13 ` Viresh Kumar
2021-03-13 5:11 ` Frank Rowand
2021-03-15 1:16 ` Frank Rowand
2021-03-15 6:40 ` Viresh Kumar
2021-03-15 17:43 ` Masahiro Yamada
2021-03-15 22:12 ` Laurent Pinchart
2021-03-16 5:39 ` Frank Rowand
2021-03-16 8:01 ` Geert Uytterhoeven
2021-04-09 6:03 ` Masahiro Yamada
2021-03-16 5:27 ` Viresh Kumar
2021-03-16 5:36 ` Frank Rowand
2021-03-16 5:42 ` Viresh Kumar
2021-03-24 7:34 ` Frank Rowand
2021-03-24 22:45 ` Frank Rowand
2021-03-10 5:35 ` [PATCH V11 4/5] of: unittest: Create overlay_common.dtsi and testcases_common.dtsi Viresh Kumar
2021-03-10 5:35 ` [PATCH V11 5/5] of: unittest: Statically apply overlays using fdtoverlay Viresh Kumar
2021-03-11 23:27 ` [PATCH V11 0/5] dt: Add fdtoverlay rule and statically build unittest Frank Rowand
2021-03-12 4:31 ` Viresh Kumar
2021-03-12 6:46 ` Frank Rowand
2021-03-12 4:32 ` Viresh Kumar
2021-03-15 17:13 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNAST04XTt7Y0DnSADHgAw-zy61HUcRJSyYRvy2rGHMdn4A@mail.gmail.com \
--to=masahiroy@kernel.org \
--cc=anmar.oueja@linaro.org \
--cc=bill.mills@linaro.org \
--cc=david@gibson.dropbear.id.au \
--cc=frowand.list@gmail.com \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=michal.simek@xilinx.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).