From: Masahiro Yamada <firstname.lastname@example.org>
To: Guenter Roeck <email@example.com>
Cc: David Miller <firstname.lastname@example.org>,
Linux Kernel Mailing List <email@example.com>,
Linux Kbuild mailing list <firstname.lastname@example.org>,
Marc Zyngier <email@example.com>
Subject: Re: [PATCH] sparc: vdso: Fix build failure seen due to kbuild changes
Date: Tue, 12 Nov 2019 21:06:20 +0900 [thread overview]
Message-ID: <CAK7LNASY209k5g61=+cbRgjNp8=1QGcP6c2RcCBad7NnfUhHHQ@mail.gmail.com> (raw)
On Mon, Nov 11, 2019 at 11:35 PM Guenter Roeck <firstname.lastname@example.org> wrote:
> On 11/10/19 5:47 PM, Masahiro Yamada wrote:
> > On Mon, Nov 11, 2019 at 10:32 AM David Miller <email@example.com> wrote:
> >> From: Guenter Roeck <firstname.lastname@example.org>
> >> Date: Sun, 10 Nov 2019 17:11:06 -0800
> >>> sparc64:allmodconfig fails to build with the following error.
> >>> unrecognized e_machine 18 arch/sparc/vdso/vdso32/vclock_gettime.o
> >>> arch/sparc/vdso/vdso32/vclock_gettime.o: failed
> >>> make: *** [arch/sparc/vdso/vdso32/vclock_gettime.o] Error 1
> >>> make: *** Deleting file 'arch/sparc/vdso/vdso32/vclock_gettime.o'
> >>> make: *** Waiting for unfinished jobs....
> >>> The problem bisects to commit a3de7a72c517 ("kbuild: change
> >>> *FLAGS_<basetarget>.o to take the path relative to $(obj)").
> >>> Duplicate the x86 specific defines from this commit to the sparc
> >>> vdso Makefile to fix the problem.
> >>> Fixes: a3de7a72c517 ("kbuild: change *FLAGS_<basetarget>.o to take the path relative to $(obj)")
> >>> Cc: Masahiro Yamada <email@example.com>
> >>> Cc: Marc Zyngier <firstname.lastname@example.org>
> >>> Signed-off-by: Guenter Roeck <email@example.com>
> >> Acked-by: David S. Miller <firstname.lastname@example.org>
> > Yeah, I had submitted a fix a long time before.
> > https://lore.kernel.org/patchwork/patch/1130469/
> > I do not know why it was not picked up.
> Why don't you just push it upstream yourself ?
> > It is OK whether any patch is picked up
> > as long as the build error is fixed.
> Same here.
> > (I think CFLAGS_REMOVE_vdso32/vdso-note.o
> > should be added too, though)
> Hard to decide for someone not involved in vdso development.
> It wasn't added for x86, and it compiles without, so I rather
> left it alone.
After looking at the code closer,
I believe your code is more correct.
vdso-note is assembly instead of C.
The -pg flag is added by the top Makefile,
only for C files.
CFLAGS_REMOVE_vdso-note.o = -pg
was unneeded in the first place.
BTW, I just thought this patch
was supposed to be applied by Dave
since it is touching a single file in arch/sparc/.
If Dave plans to pick up this, please feel free to add:
Reviewed-by: Masahiro Yamada <email@example.com>
If I should apply this to kbuild tree, please let me know.
prev parent reply other threads:[~2019-11-12 12:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 1:11 [PATCH] sparc: vdso: Fix build failure seen due to kbuild changes Guenter Roeck
2019-11-11 1:32 ` David Miller
2019-11-11 1:47 ` Masahiro Yamada
2019-11-11 14:35 ` Guenter Roeck
2019-11-12 12:06 ` Masahiro Yamada [this message]
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).