From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCF7CC43331 for ; Tue, 12 Nov 2019 12:07:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B3A292084E for ; Tue, 12 Nov 2019 12:07:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nifty.com header.i=@nifty.com header.b="PvG8uwgP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727049AbfKLMH1 (ORCPT ); Tue, 12 Nov 2019 07:07:27 -0500 Received: from conssluserg-02.nifty.com ([210.131.2.81]:27009 "EHLO conssluserg-02.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725944AbfKLMH1 (ORCPT ); Tue, 12 Nov 2019 07:07:27 -0500 Received: from mail-ua1-f53.google.com (mail-ua1-f53.google.com [209.85.222.53]) (authenticated) by conssluserg-02.nifty.com with ESMTP id xACC6vMN010836; Tue, 12 Nov 2019 21:06:57 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-02.nifty.com xACC6vMN010836 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1573560418; bh=Sgqs5/I3zJLWaBRJGnQJMZjSMC0UNfDF+eV/0rJAwU0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=PvG8uwgP2kQTVuBQk2kzxi2TDqds7N52zFu4NUW55dePkn2U3DyJ3dnvwZP28NF9r 6Fd+bid9vMKeORqvP6B/kyQh4ulOJKbukGUzqqkEzWvWj1hTgRYvp0x1ymem1MyP6W JC0npXimCoWWnF8/lEyOjtXtaGb0zP5FwJYoxgB+On9JAV0ClkTul7usUJPAAUHmDM J6wEOrS2AOPZLPxEIXcQ5rzLG3fdrsTSeLlyNXPA4+ce/8aLhLb7BNMOjcxgzOxItD a+Shc2VBRwvBsN77DaASxY/A+/XKKWOpbi3P13W7PeVMVD3K7pBdqc+PDuHcx33htI 4NlsdRuSB/P1A== X-Nifty-SrcIP: [209.85.222.53] Received: by mail-ua1-f53.google.com with SMTP id u99so4619719uau.5; Tue, 12 Nov 2019 04:06:57 -0800 (PST) X-Gm-Message-State: APjAAAXVqpRFic+pHvzjUJh6K040QUy80Ge4lM0A3ZmyqLzXOyAuEiLP TLz9mgHBMuELKNvNssLqpUoy6NgOy0nUOmMLzCg= X-Google-Smtp-Source: APXvYqxvFq5FgSgnUVNLyeoqfHZziPLTY9nkt64faSHe5hVF5nFrk880h1LTgcUSxKS6qI4PoU80uumy9ITmkIObu5k= X-Received: by 2002:a9f:3e81:: with SMTP id x1mr3415007uai.121.1573560416440; Tue, 12 Nov 2019 04:06:56 -0800 (PST) MIME-Version: 1.0 References: <20191111011106.18427-1-linux@roeck-us.net> <20191110.173203.1243596361382467520.davem@davemloft.net> <591a9e5e-1347-8883-c080-38940fffd535@roeck-us.net> In-Reply-To: <591a9e5e-1347-8883-c080-38940fffd535@roeck-us.net> From: Masahiro Yamada Date: Tue, 12 Nov 2019 21:06:20 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] sparc: vdso: Fix build failure seen due to kbuild changes To: Guenter Roeck Cc: David Miller , sparclinux , Linux Kernel Mailing List , Linux Kbuild mailing list , Marc Zyngier Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 11, 2019 at 11:35 PM Guenter Roeck wrote: > > On 11/10/19 5:47 PM, Masahiro Yamada wrote: > > On Mon, Nov 11, 2019 at 10:32 AM David Miller wrote: > >> > >> From: Guenter Roeck > >> Date: Sun, 10 Nov 2019 17:11:06 -0800 > >> > >>> sparc64:allmodconfig fails to build with the following error. > >>> > >>> unrecognized e_machine 18 arch/sparc/vdso/vdso32/vclock_gettime.o > >>> arch/sparc/vdso/vdso32/vclock_gettime.o: failed > >>> make[2]: *** [arch/sparc/vdso/vdso32/vclock_gettime.o] Error 1 > >>> make[2]: *** Deleting file 'arch/sparc/vdso/vdso32/vclock_gettime.o' > >>> make[2]: *** Waiting for unfinished jobs.... > >>> > >>> The problem bisects to commit a3de7a72c517 ("kbuild: change > >>> *FLAGS_.o to take the path relative to $(obj)"). > >>> Duplicate the x86 specific defines from this commit to the sparc > >>> vdso Makefile to fix the problem. > >>> > >>> Fixes: a3de7a72c517 ("kbuild: change *FLAGS_.o to take the path relative to $(obj)") > >>> Cc: Masahiro Yamada > >>> Cc: Marc Zyngier > >>> Signed-off-by: Guenter Roeck > >> > >> Acked-by: David S. Miller > > > > > > Yeah, I had submitted a fix a long time before. > > > > https://lore.kernel.org/patchwork/patch/1130469/ > > > > I do not know why it was not picked up. > > > > Why don't you just push it upstream yourself ? > > > > > It is OK whether any patch is picked up > > as long as the build error is fixed. > > > Same here. > > > > > (I think CFLAGS_REMOVE_vdso32/vdso-note.o > > should be added too, though) > > > Hard to decide for someone not involved in vdso development. > It wasn't added for x86, and it compiles without, so I rather > left it alone. After looking at the code closer, I believe your code is more correct. vdso-note is assembly instead of C. arch/sparc/vdso/vdso-note.S arch/sparc/vdso/vdso32/vdso-note.S The -pg flag is added by the top Makefile, only for C files. CFLAGS_REMOVE_vdso-note.o = -pg was unneeded in the first place. BTW, I just thought this patch was supposed to be applied by Dave since it is touching a single file in arch/sparc/. If Dave plans to pick up this, please feel free to add: Reviewed-by: Masahiro Yamada If I should apply this to kbuild tree, please let me know. -- Best Regards Masahiro Yamada