From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Christoph Hellwig <hch@lst.de>
Cc: mporter@kernel.crashing.org, Alex Bounine <alex.bou9@gmail.com>,
Dominik Brodowski <linux@dominikbrodowski.net>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-pci@vger.kernel.org,
linux-arch <linux-arch@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
linux-alpha@vger.kernel.org,
Linux-MIPS <linux-mips@linux-mips.org>
Subject: Re: [PATCH 5/9] PCI: consolidate the PCI_DOMAINS and PCI_DOMAINS_GENERIC config options
Date: Fri, 23 Nov 2018 11:41:19 +0900 [thread overview]
Message-ID: <CAK7LNASYobpeAMqenZXycNieWErRFkNHz6xQUzEruJ0-nNwfdA@mail.gmail.com> (raw)
In-Reply-To: <20181115190538.17016-6-hch@lst.de>
On Fri, Nov 16, 2018 at 4:07 AM Christoph Hellwig <hch@lst.de> wrote:
> diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig
> index a8128a1946a2..95812fc4958c 100644
> --- a/drivers/pci/Kconfig
> +++ b/drivers/pci/Kconfig
> @@ -21,6 +21,15 @@ menuconfig PCI
> support for PCI-X and the foundations for PCI Express support.
> Say 'Y' here unless you know what you are doing.
>
> +config PCI_DOMAINS
> + depends on PCI
> + bool
> +
> +config PCI_DOMAINS_GENERIC
> + depends on PCI
> + select PCI_DOMAINS
> + bool
> +
> source "drivers/pci/pcie/Kconfig"
>
> config PCI_MSI
I reordered this so it 'bool' comes first.
config PCI_DOMAINS
bool
depends on PCI
config PCI_DOMAINS_GENERIC
bool
depends on PCI
select PCI_DOMAINS
Of course, it is just a matter of slight taste.
I just wanted the code to look consistent.
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2018-11-23 2:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 19:05 move bus (PCI, PCMCIA, EISA, rapdio) config to drivers/ v4 Christoph Hellwig
2018-11-15 19:05 ` [PATCH 1/9] arm: remove EISA kconfig option Christoph Hellwig
2018-11-23 2:38 ` Masahiro Yamada
2018-11-15 19:05 ` [PATCH 2/9] alpha: force PCI on for non-jensen configs Christoph Hellwig
2018-11-23 2:38 ` Masahiro Yamada
2018-11-15 19:05 ` [PATCH 3/9] MIPS: remove the HT_PCI config option Christoph Hellwig
2018-11-19 21:01 ` Paul Burton
2018-11-19 21:05 ` Paul Burton
2018-11-23 2:37 ` Masahiro Yamada
2018-11-15 19:05 ` [PATCH 4/9] PCI: consolidate PCI config entry in drivers/pci Christoph Hellwig
2018-11-16 9:10 ` Geert Uytterhoeven
2018-11-19 21:13 ` Paul Burton
2018-11-15 19:05 ` [PATCH 5/9] PCI: consolidate the PCI_DOMAINS and PCI_DOMAINS_GENERIC config options Christoph Hellwig
2018-11-23 2:41 ` Masahiro Yamada [this message]
2018-11-15 19:05 ` [PATCH 6/9] PCI: consolidate the PCI_SYSCALL symbol Christoph Hellwig
2018-11-15 19:05 ` [PATCH 7/9] pcmcia: allow PCMCIA support independent of the architecture Christoph Hellwig
2018-11-15 19:05 ` [PATCH 8/9] rapidio: consolidate RAPIDIO config entry in drivers/rapidio Christoph Hellwig
2018-11-15 19:05 ` [PATCH 9/9] eisa: consolidate EISA Kconfig entry in drivers/eisa Christoph Hellwig
2018-11-23 2:34 ` Masahiro Yamada
2018-11-23 2:32 ` move bus (PCI, PCMCIA, EISA, rapdio) config to drivers/ v4 Masahiro Yamada
2018-11-23 2:36 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNASYobpeAMqenZXycNieWErRFkNHz6xQUzEruJ0-nNwfdA@mail.gmail.com \
--to=yamada.masahiro@socionext.com \
--cc=alex.bou9@gmail.com \
--cc=hch@lst.de \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mporter@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).