From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kbuild <linux-kbuild@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kconfig: add build-only configurator targets
Date: Fri, 17 Aug 2018 10:55:13 +0900 [thread overview]
Message-ID: <CAK7LNASb4+dvhWKaNgn66+9RiJEosAbv2f_d7RsD48Tt9_LziQ@mail.gmail.com> (raw)
In-Reply-To: <a4139b9d-9842-a595-b273-1fce3eecf6a3@infradead.org>
2018-08-17 1:30 GMT+09:00 Randy Dunlap <rdunlap@infradead.org>:
> On 08/15/2018 08:27 PM, Masahiro Yamada wrote:
>> 2018-08-15 9:36 GMT+09:00 Randy Dunlap <rdunlap@infradead.org>:
>>> From: Randy Dunlap <rdunlap@infradead.org>
>>>
>>> Add build-only targets for build_menuconfig, build_nconfig,
>>> build_xconfig, and build_gconfig.
>>> (targets must end in "config" to qualify in top-level Makefile)
>>>
>>> This allows these target to be built without execution (e.g., to
>>> look for errors or warnings) and/or to be built and checked by sparse.
>>>
>>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>>> ---
Applied to linux-kbuild. Thanks!
>>> scripts/kconfig/Makefile | 8 ++++++++
>>> 1 file changed, 8 insertions(+)
>>>
>>> --- linux-next-20180814.orig/scripts/kconfig/Makefile
>>> +++ linux-next-20180814/scripts/kconfig/Makefile
>>> @@ -33,6 +33,14 @@ config: $(obj)/conf
>>> nconfig: $(obj)/nconf
>>> $< $(silent) $(Kconfig)
>>>
>>> +build_menuconfig: $(obj)/mconf
>>> +
>>> +build_nconfig: $(obj)/nconf
>>> +
>>> +build_gconfig: $(obj)/gconf
>>> +
>>> +build_xconfig: $(obj)/qconf
>>> +
>>> localyesconfig localmodconfig: $(obj)/conf
>>> $(Q)perl $(srctree)/$(src)/streamline_config.pl --$@ $(srctree) $(Kconfig) > .tmp.config
>>> $(Q)if [ -f .config ]; then \
>>>
>>
>>
>> OK, seems useful,
>> but these should be phony targets.
>>
>> May I squash the following change?
>>
>
> Of course. Thanks.
>
>>
>> diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile
>> index c0ca9ea..f7bdcc9 100644
>> --- a/scripts/kconfig/Makefile
>> +++ b/scripts/kconfig/Makefile
>> @@ -3,7 +3,8 @@
>> # Kernel configuration targets
>> # These targets are used from top-level makefile
>>
>> -PHONY += xconfig gconfig menuconfig config localmodconfig localyesconfig
>> +PHONY += xconfig gconfig menuconfig config localmodconfig localyesconfig \
>> + build_menuconfig build_nconfig build_gconfig build_xconfig
>>
>> ifdef KBUILD_KCONFIG
>> Kconfig := $(KBUILD_KCONFIG)
>
>
> --
> ~Randy
--
Best Regards
Masahiro Yamada
prev parent reply other threads:[~2018-08-17 1:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-15 0:36 [PATCH] kconfig: add build-only configurator targets Randy Dunlap
2018-08-16 3:27 ` Masahiro Yamada
2018-08-16 16:30 ` Randy Dunlap
2018-08-17 1:55 ` Masahiro Yamada [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNASb4+dvhWKaNgn66+9RiJEosAbv2f_d7RsD48Tt9_LziQ@mail.gmail.com \
--to=yamada.masahiro@socionext.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).