From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933762AbeCEJjU (ORCPT ); Mon, 5 Mar 2018 04:39:20 -0500 Received: from conssluserg-01.nifty.com ([210.131.2.80]:49699 "EHLO conssluserg-01.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933671AbeCEJjQ (ORCPT ); Mon, 5 Mar 2018 04:39:16 -0500 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-01.nifty.com w259dDmk021413 X-Nifty-SrcIP: [209.85.213.45] X-Google-Smtp-Source: AG47ELvL44eI/J3waLXqrp+gtKiNPPaWr171+IbYYVcoQUhcABq0tKf7nuqx6cJGl9foRu382uugAO9h/woPNFoBVKU= MIME-Version: 1.0 In-Reply-To: References: <20180228191805.20094-1-linux@rasmusvillemoes.dk> <20180228191805.20094-3-linux@rasmusvillemoes.dk> From: Masahiro Yamada Date: Mon, 5 Mar 2018 18:38:32 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 3/3] fixdep: do not ignore kconfig.h To: Rasmus Villemoes Cc: Michal Marek , Linus Torvalds , Linux Kbuild mailing list , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2018-03-05 17:15 GMT+09:00 Rasmus Villemoes : > On 5 March 2018 at 05:52, Masahiro Yamada wrote: >> 2018-03-01 4:17 GMT+09:00 Rasmus Villemoes : >>> kconfig.h was excluded from consideration by fixdep by >>> 6a5be57f0f00 (fixdep: fix extraneous dependencies) to avoid some false >>> positive hits > [...] >>> We've already had one case [2] where the lack of include/linux/kconfig.h in >>> the .o.cmd file caused a missing rebuild, > [...] >>> [2] https://lkml.org/lkml/2018/2/22/838 >> >> >> Sorry, I missed to include this series in the Kbuild fixes PR >> I sent two days ago. >> >> I was not tracking the randomize-struct thread. >> I read [2] and I noticed the background of this series just now. >> >> Hopefully, I will have another opportunity of PR >> if this series is necessary for v4.16 (seems so) > > I should probably have put 3/3 first, if that is 4.16 material, the > other two can obviously wait for 4.17. They don't really depend on > each other apart from overlapping context, and the above commit > message would need slight rewording if put before the others. I can do > that reordering and resend if you wish. > > Rasmus 1/3 is obviously safe, 2/3 too. I think the current series is OK for v4.16. I will queue it up to the fixes branch shortly. Thanks! -- Best Regards Masahiro Yamada