From: Masahiro Yamada <masahiroy@kernel.org>
To: RANDRIANAINA Georges Aaron <georges-aaron.randrianaina@irisa.fr>
Cc: Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Mathieu Acher <mathieu.acher@irisa.fr>
Subject: Re: [PATCH] kconfig: add KCONFIG_ALLCONFIG support for tinyconfig
Date: Tue, 8 Mar 2022 11:40:44 +0900 [thread overview]
Message-ID: <CAK7LNASmwT3s2s88_wD4FvthCR0=EJYginf5qFXs4dh59oTcoQ@mail.gmail.com> (raw)
In-Reply-To: <87zgm41xwp.fsf@irisa.fr>
On Sat, Mar 5, 2022 at 7:44 PM RANDRIANAINA Georges Aaron
<georges-aaron.randrianaina@irisa.fr> wrote:
>
>
> Masahiro Yamada <masahiroy@kernel.org> writes:
>
> > On Fri, Mar 4, 2022 at 2:27 AM Randrianaina Georges Aaron
> > <georges-aaron.randrianaina@irisa.fr> wrote:
> >>
> >> Since f8f0d06438e5, tinyconfig overrides KCONFIG_ALLCONFIG to
> >> include kernel/configs/tiny-base.config. However, this ignores
> >> user's preset if defined.
> >>
> >> This modification checks if the user has set KCONFIG_ALLCONFIG
> >> and if so, concatenates it with kernel/configs/tiny-base.config
> >> to be used as preset config symbols.
> >>
> >> Signed-off-by: Randrianaina Georges Aaron <georges-aaron.randrianaina@irisa.fr>
> >> ---
> >> scripts/kconfig/Makefile | 6 ++++++
> >> 1 file changed, 6 insertions(+)
> >>
> >> diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile
> >> index b8ef0fb4bbef..337693fb4762 100644
> >> --- a/scripts/kconfig/Makefile
> >> +++ b/scripts/kconfig/Makefile
> >> @@ -102,7 +102,13 @@ configfiles=$(wildcard $(srctree)/kernel/configs/$@ $(srctree)/arch/$(SRCARCH)/c
> >>
> >> PHONY += tinyconfig
> >> tinyconfig:
> >> +ifeq ($(KCONFIG_ALLCONFIG),)
> >> $(Q)KCONFIG_ALLCONFIG=kernel/configs/tiny-base.config $(MAKE) -f $(srctree)/Makefile allnoconfig
> >> +else
> >> + $(Q)cat $(KCONFIG_ALLCONFIG) <(echo) kernel/configs/tiny-base.config > .tmp.config
> >
> >
> > I assume "<(echo)" exists here to insert a blank line.
> > The process substitution is a bash'ism.
> >
> > If you execute it on Debian or its variants, where /bin/sh is a symlink
> > to dash, it fails.
> >
> > masahiro@grover:~/ref/linux$ make KCONFIG_ALLCONFIG=/tmp/dummy.config
> > tinyconfig
> > /bin/sh: 1: Syntax error: "(" unexpected
> > make[1]: *** [scripts/kconfig/Makefile:108: tinyconfig] Error 2
> > make: *** [Makefile:619: tinyconfig] Error 2
> >
> >
> >
> > We can delete '<(echo)', but another issue is that this does not work
> > with O=<dir> option.
>
> Yes, we can delete `<(echo)`. We can solve the remaining issue by adding
> `$(srctree)` in the presets' path to make it work with O=<dir>.
Yes.
--
Best Regards
Masahiro Yamada
prev parent reply other threads:[~2022-03-08 2:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 16:51 [PATCH] kconfig: add KCONFIG_ALLCONFIG support for tinyconfig Randrianaina Georges Aaron
2022-03-04 17:06 ` Masahiro Yamada
2022-03-05 9:05 ` RANDRIANAINA Georges Aaron
2022-03-08 2:40 ` Masahiro Yamada [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK7LNASmwT3s2s88_wD4FvthCR0=EJYginf5qFXs4dh59oTcoQ@mail.gmail.com' \
--to=masahiroy@kernel.org \
--cc=georges-aaron.randrianaina@irisa.fr \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.acher@irisa.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).