From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
cocci@systeme.lip6.fr, Nicolas Palix <nicolas.palix@imag.fr>,
Gilles Muller <Gilles.Muller@lip6.fr>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Michal Marek <michal.lkml@markovi.net>
Subject: Re: [PATCH v2] coccinelle: fix parallel build with CHECK=scripts/coccicheck
Date: Tue, 14 Nov 2017 01:32:58 +0900 [thread overview]
Message-ID: <CAK7LNASpxfq6Vg42rogQg1bixNL15O=8152=KJEnKQA=Ez6Dxw@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1711131628370.20333@hadrien>
Hi Julia,
2017-11-14 0:30 GMT+09:00 Julia Lawall <julia.lawall@lip6.fr>:
>
>
> On Thu, 9 Nov 2017, Masahiro Yamada wrote:
>
>> The command "make -j8 C=1 CHECK=scripts/coccicheck" produces lots of
>> "coccicheck failed" error messages.
>>
>> I do not know the coccinelle internals, but I guess --jobs does not
>> work well if spatch is invoked from Make running in parallel.
>> Disable --jobs in this case.
>
> Why is this change under:
>
> if [ "$C" = "1" -o "$C" = "2" ];
>
> The coccicheck failed messages come also if one runs Coccinelle on the
> entire kernel.
As far as I tested, "coccicheck failed" error only happens
when ONLINE=1.
make -j8 C=1 CHECK=scripts/coccicheck COCCI=scripts/coccinelle/misc/bugon.cocci
emits lots of errors.
make -j8 coccicheck COCCI=scripts/coccinelle/misc/bugon.cocci
is fine.
Have you tested it?
Do you mean you got a different result from mine?
> julia
>
>
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>> ---
>>
>> Changes in v2:
>> - Grep '-j' instead of '--jobserver-auth'.
>> '--jobserver-*' is not a stable option flag.
>> Make 4.2 change '--jobserver-fds' into '--jobserver-auth'
>> - Add -q option to grep
>>
>> scripts/coccicheck | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/scripts/coccicheck b/scripts/coccicheck
>> index 040a8b1..8bab11e 100755
>> --- a/scripts/coccicheck
>> +++ b/scripts/coccicheck
>> @@ -70,6 +70,9 @@ if [ "$C" = "1" -o "$C" = "2" ]; then
>> # Take only the last argument, which is the C file to test
>> shift $(( $# - 1 ))
>> OPTIONS="$COCCIINCLUDE $1"
>> +
>> + # --jobs does not work if Make is running in parallel
>> + echo $MAKEFLAGS | grep -q -E '(^| )-j' && USE_JOBS="no"
>> else
>> ONLINE=0
>> if [ "$KBUILD_EXTMOD" = "" ] ; then
>> --
>> 2.7.4
>>
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2017-11-13 16:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-09 7:00 [PATCH v2] coccinelle: fix parallel build with CHECK=scripts/coccicheck Masahiro Yamada
2017-11-10 15:42 ` Julia Lawall
2017-11-11 7:30 ` [Cocci] " Julia Lawall
2017-11-13 16:31 ` Masahiro Yamada
2017-11-13 16:44 ` Julia Lawall
2017-11-13 15:30 ` Julia Lawall
2017-11-13 16:32 ` Masahiro Yamada [this message]
2017-11-13 16:45 ` Julia Lawall
2017-11-14 3:51 ` Masahiro Yamada
2017-11-14 6:44 ` Julia Lawall
2017-11-14 9:08 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK7LNASpxfq6Vg42rogQg1bixNL15O=8152=KJEnKQA=Ez6Dxw@mail.gmail.com' \
--to=yamada.masahiro@socionext.com \
--cc=Gilles.Muller@lip6.fr \
--cc=cocci@systeme.lip6.fr \
--cc=julia.lawall@lip6.fr \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).