From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: arm-soc <arm@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
ionela.voinescu@arm.com,
Daniel Lezcano <daniel.lezcano@linaro.org>,
chris.redpath@arm.com, DTML <devicetree@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 6/6] arm64: dts: socionext: Add missing cooling device properties for CPUs
Date: Fri, 1 Jun 2018 12:25:22 +0900 [thread overview]
Message-ID: <CAK7LNASv90x3QKPYEy-3Msow0wi99hV8aRiU32aAjS7jMJKydA@mail.gmail.com> (raw)
In-Reply-To: <744f4c0a9a6f0d3acfc36e49ef62f17f53831b3b.1527225682.git.viresh.kumar@linaro.org>
2018-05-25 14:40 GMT+09:00 Viresh Kumar <viresh.kumar@linaro.org>:
> The cooling device properties, like "#cooling-cells" and
> "dynamic-power-coefficient", should either be present for all the CPUs
> of a cluster or none. If these are present only for a subset of CPUs of
> a cluster then things will start falling apart as soon as the CPUs are
> brought online in a different order. For example, this will happen
> because the operating system looks for such properties in the CPU node
> it is trying to bring up, so that it can register a cooling device.
>
> Add such missing properties.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Applied to linux-uniphier.
I had already sent a PR for v4.18-rc1 before I received this patch.
Please wait for v4.19-rc1.
Thanks.
> ---
> arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi b/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi
> index 3a5ed789c056..10ffb5019013 100644
> --- a/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi
> +++ b/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi
> @@ -58,6 +58,7 @@
> clocks = <&sys_clk 32>;
> enable-method = "psci";
> operating-points-v2 = <&cluster0_opp>;
> + #cooling-cells = <2>;
> };
>
> cpu2: cpu@100 {
> @@ -77,6 +78,7 @@
> clocks = <&sys_clk 33>;
> enable-method = "psci";
> operating-points-v2 = <&cluster1_opp>;
> + #cooling-cells = <2>;
> };
> };
>
> --
> 2.15.0.194.g9af6a3dea062
>
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2018-06-01 3:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-25 5:40 [PATCH 0/6] arm64: dts: Add missing cooling device properties for CPUs Viresh Kumar
2018-05-25 5:40 ` [PATCH 1/6] arm64: dts: amlogic: " Viresh Kumar
2018-05-25 21:10 ` Olof Johansson
2018-05-26 8:37 ` Neil Armstrong
2018-05-28 11:16 ` Viresh Kumar
2018-05-28 11:13 ` Viresh Kumar
2018-06-02 8:14 ` Olof Johansson
2018-06-05 4:37 ` Viresh Kumar
2018-05-25 5:40 ` [PATCH 2/6] arm64: dts: freescale: " Viresh Kumar
2018-07-03 7:34 ` Shawn Guo
2018-07-03 8:34 ` Viresh Kumar
2018-07-03 10:08 ` Shawn Guo
2018-05-25 5:40 ` [PATCH 3/6] arm64: dts: hisilicon: " Viresh Kumar
2018-05-26 18:00 ` Wei Xu
2018-05-26 18:21 ` Wei Xu
2018-07-18 5:58 ` Viresh Kumar
2018-07-18 15:32 ` Wei Xu
2018-05-25 5:40 ` [PATCH 4/6] arm64: dts: mediatek: " Viresh Kumar
2018-07-02 16:56 ` Matthias Brugger
2018-05-25 5:40 ` [PATCH 5/6] arm64: dts: rockchip: " Viresh Kumar
2018-06-15 11:23 ` Heiko Stübner
2018-05-25 5:40 ` [PATCH 6/6] arm64: dts: socionext: " Viresh Kumar
2018-06-01 3:25 ` Masahiro Yamada [this message]
2018-06-04 7:14 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNASv90x3QKPYEy-3Msow0wi99hV8aRiU32aAjS7jMJKydA@mail.gmail.com \
--to=yamada.masahiro@socionext.com \
--cc=arm@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=chris.redpath@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=ionela.voinescu@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).