From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kbuild <linux-kbuild@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
stable <stable@vger.kernel.org>,
Lucas De Marchi <lucas.demarchi@profusion.mobi>,
Lucas De Marchi <lucas.de.marchi@gmail.com>,
Michal Marek <michal.lkml@markovi.net>,
Jessica Yu <jeyu@kernel.org>,
Chih-Wei Huang <cwhuang@linux.org.tw>,
"H. Nikolaus Schaller" <hns@goldelico.com>
Subject: Re: [PATCH v3] modules_install: make missing $DEPMOD a warning instead of an error
Date: Fri, 24 Aug 2018 13:20:02 +0900 [thread overview]
Message-ID: <CAK7LNASyhKFp+AWQr-RWTRbMu78=G7Uj=350xrjq_Lht8MVYzQ@mail.gmail.com> (raw)
In-Reply-To: <4449cd91-fae5-caf1-a917-82e0c5f0aba8@infradead.org>
Hi Randy,
2018-08-24 3:13 GMT+09:00 Randy Dunlap <rdunlap@infradead.org>:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> When $DEPMOD is not found, only print a warning instead of exiting
> with an error message and error status.
Could you add the motivation of this change
(as Nikolaus reported) ?
Without the reason recorded in git-log,
somebody may wonder why this commit is useful.
> Warning: 'make modules_install' requires /sbin/depmod. Please install it.
> This is probably in the kmod package.
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Fixes: 934193a654c1 ("kbuild: verify that $DEPMOD is installed")
> Cc: stable@vger.kernel.org
> Cc: Lucas De Marchi <lucas.demarchi@profusion.mobi>
> Cc: Lucas De Marchi <lucas.de.marchi@gmail.com>
> Cc: Michal Marek <michal.lkml@markovi.net>
> Cc: Jessica Yu <jeyu@kernel.org>
> Cc: Chih-Wei Huang <cwhuang@linux.org.tw>
> Cc: H. Nikolaus Schaller <hns@goldelico.com>
Reported-by: H. Nikolaus Schaller <hns@goldelico.com>
> ---
> v2: add missing "exit 0" and update the commit message (no Error).
> v3: add Fixes: and Cc: stable
>
> scripts/depmod.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- lnx-418.orig/scripts/depmod.sh
> +++ lnx-418/scripts/depmod.sh
> @@ -15,9 +15,9 @@ if ! test -r System.map ; then
> fi
>
> if [ -z $(command -v $DEPMOD) ]; then
> - echo "'make modules_install' requires $DEPMOD. Please install it." >&2
> + echo "Warning: 'make modules_install' requires $DEPMOD. Please install it." >&2
> echo "This is probably in the kmod package." >&2
> - exit 1
> + exit 0
> fi
>
> # older versions of depmod require the version string to start with three
BTW, if System.map is missing, depmod is silently skipped.
I think if System.map is missing, a user is doing something wrong,
but you could do like this:
$ make mrproper
[snip]
$ make defconfig
[snip]
$ make modules
[snip]
$ make modules_install
INSTALL drivers/thermal/x86_pkg_temp_thermal.ko
INSTALL fs/efivarfs/efivarfs.ko
INSTALL net/ipv4/netfilter/ipt_MASQUERADE.ko
INSTALL net/ipv4/netfilter/iptable_nat.ko
INSTALL net/ipv4/netfilter/nf_log_arp.ko
INSTALL net/ipv4/netfilter/nf_log_ipv4.ko
INSTALL net/ipv4/netfilter/nf_nat_ipv4.ko
INSTALL net/ipv6/netfilter/nf_log_ipv6.ko
INSTALL net/netfilter/nf_log_common.ko
INSTALL net/netfilter/nf_nat.ko
INSTALL net/netfilter/nf_nat_ftp.ko
INSTALL net/netfilter/nf_nat_irc.ko
INSTALL net/netfilter/nf_nat_sip.ko
INSTALL net/netfilter/xt_LOG.ko
INSTALL net/netfilter/xt_addrtype.ko
INSTALL net/netfilter/xt_mark.ko
INSTALL net/netfilter/xt_nat.ko
DEPMOD 4.18.0+
The log looks like all the process went well,
but depmod is actually skipped because System.map is
generated by "make vmlinux"
What do you think we should do about this case?
Skip depmod silently?
Make it fail?
Print noisy warning like missing depmod case?
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2018-08-24 4:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-23 18:13 [PATCH v3] modules_install: make missing $DEPMOD a warning instead of an error Randy Dunlap
2018-08-23 19:38 ` H. Nikolaus Schaller
2018-08-24 4:20 ` Masahiro Yamada [this message]
2018-08-28 19:55 ` Randy Dunlap
2018-08-29 1:06 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK7LNASyhKFp+AWQr-RWTRbMu78=G7Uj=350xrjq_Lht8MVYzQ@mail.gmail.com' \
--to=yamada.masahiro@socionext.com \
--cc=cwhuang@linux.org.tw \
--cc=gregkh@linuxfoundation.org \
--cc=hns@goldelico.com \
--cc=jeyu@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.de.marchi@gmail.com \
--cc=lucas.demarchi@profusion.mobi \
--cc=michal.lkml@markovi.net \
--cc=rdunlap@infradead.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).