From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Prasad Sodagudi <psodagud@codeaurora.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
segher@kernel.crashing.org, Greg Hackmann <ghackmann@google.com>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kbuild: clang: disable unused variable warnings only when constant
Date: Wed, 7 Feb 2018 09:22:41 +0900 [thread overview]
Message-ID: <CAK7LNASzk0awa4L6F_h9Lbyf7i0VbCkZ_O6Uuk64N_65N4e-5g@mail.gmail.com> (raw)
In-Reply-To: <1517960811-21674-1-git-send-email-psodagud@codeaurora.org>
2018-02-07 8:46 GMT+09:00 Prasad Sodagudi <psodagud@codeaurora.org>:
> Currently, GCC disables -Wunused-const-variable, but not
> -Wunused-variable, so warns unused variables if they are
> non-constant.
>
> While, Clang does not warn unused variables at all regardless of
> the const qualifier because -Wno-unused-const-variable is implied
> by the stronger option -Wno-unused-variable.
>
> Disable -Wunused-const-variable instead of -Wunused-variable so that
> GCC and Clang work in the same way.
>
> Signed-off-by: Prasad Sodagudi <psodagud@codeaurora.org>
> Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Applied to linux-kbuild/kbuild. Thanks!
--
Best Regards
Masahiro Yamada
prev parent reply other threads:[~2018-02-07 0:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-06 21:24 unused-variable warning is getting disabled with clang Sodagudi Prasad
2017-12-07 6:26 ` Greg Kroah-Hartman
2017-12-08 2:16 ` Sodagudi Prasad
2017-12-18 15:32 ` Masahiro Yamada
2018-01-27 0:59 ` [PATCH] kbuild: clang: Disable -Wunused-const-variable warnings Prasad Sodagudi
2018-01-28 16:22 ` Segher Boessenkool
2018-01-29 16:35 ` Sodagudi Prasad
2018-01-29 17:08 ` Prasad Sodagudi
2018-01-29 23:57 ` Segher Boessenkool
2018-02-02 16:01 ` Masahiro Yamada
2018-02-06 23:46 ` [PATCH] kbuild: clang: disable unused variable warnings only when constant Prasad Sodagudi
2018-02-07 0:22 ` Masahiro Yamada [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNASzk0awa4L6F_h9Lbyf7i0VbCkZ_O6Uuk64N_65N4e-5g@mail.gmail.com \
--to=yamada.masahiro@socionext.com \
--cc=ghackmann@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=psodagud@codeaurora.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).