From: Masahiro Yamada <masahiroy@kernel.org>
To: "Michal Suchánek" <msuchanek@suse.de>
Cc: Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Revert "kbuild: merge scripts/mkmakefile to top Makefile"
Date: Wed, 2 Jun 2021 18:45:58 +0900 [thread overview]
Message-ID: <CAK7LNAT-78qWBa-TzTTQ-PN7Cr5DdaAEgKzUiVkkB=uOgcAsDQ@mail.gmail.com> (raw)
In-Reply-To: <20210529053512.GT8544@kitsune.suse.cz>
On Sat, May 29, 2021 at 2:35 PM Michal Suchánek <msuchanek@suse.de> wrote:
>
> On Sat, May 29, 2021 at 02:15:55AM +0900, Masahiro Yamada wrote:
> > On Thu, May 27, 2021 at 5:28 AM Michal Suchánek <msuchanek@suse.de> wrote:
> > >
> > > On Thu, May 27, 2021 at 03:56:41AM +0900, Masahiro Yamada wrote:
> > > > On Thu, May 27, 2021 at 2:39 AM Michal Suchanek <msuchanek@suse.de> wrote:
> > > > >
> > > > > This reverts commit 243b50c141d71fcf7b88e94474b3b9269f0b1f9d.
> > > > >
> > > > > When packaging the kernel it is built in different place from the one in
> > > > > which it will be installed. After build the makefile needs to be
> > > > > regenerated with the target location but with mkmakefile merged into
> > > > > Makefile tehre is no way to do that.
> > > > >
> > > > > Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> > > >
> > > > My patch was not working as expected
> > > > regardless of packaging.
> > > >
> > > > Does the following fix-up work for you?
> > >
> > > For the packaging I need some way to regenerate the Makefile and fake
> > > the directory where the Makefile will be on the user system (ie DESTDIR)
> > >
> > > Without the mkmakefile I do not see any way to do it.
> > >
> > > If the kernel makefile is no longer location dependent there is no need
> > > any more, of course.
> > >
> > > Thanks
> > >
> > > Michal
> >
> > Sorry, I do not understand this.
> >
> > IIUC, this patch does not change any functionality.
> > The generated Makefile is still the same.
> > Why is it a problem?
>
> It cannot be regenerated.
This is an issue regardless of your packaging.
That is why I suggested a patch in my previous reply.
https://lore.kernel.org/linux-kbuild/CAK7LNASEqKwQeLPXedyut+ykSJGPuq3CO1g_fS=sVDaZrwBPBQ@mail.gmail.com/
Anyway, please try next-20210602
and see if you still have a problem.
>
> During package build you have four directories
>
> - the source directory
> - the build directory
> - the staging directory where files are installed to be included in the
> package
> - the target directory where files will be installed on the target
> system once the package is installed by the user
>
> The makefile is generated for the build directory, not the target
> directory. What is needed is a way to generate a makefile in the staging
> directory that will work when installed in the target directory.
> When mkmakefile is folded into makefile the makefile can no longer be
> regenerated because it is up-to-date, and it can no longer be specified
> that it should be generated for the target directory, not the staging
> directory.
>
> Thanks
>
> Michal
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2021-06-02 9:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 17:38 [PATCH] Revert "kbuild: merge scripts/mkmakefile to top Makefile" Michal Suchanek
2021-05-26 18:56 ` Masahiro Yamada
2021-05-26 20:28 ` Michal Suchánek
2021-05-28 17:15 ` Masahiro Yamada
2021-05-29 5:35 ` Michal Suchánek
2021-06-02 9:45 ` Masahiro Yamada [this message]
2021-06-02 10:03 ` Michal Suchánek
2021-06-02 15:44 ` Masahiro Yamada
2021-06-02 17:59 ` Michal Suchánek
2021-06-02 18:35 ` Masahiro Yamada
2021-06-17 7:57 ` Michal Suchánek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK7LNAT-78qWBa-TzTTQ-PN7Cr5DdaAEgKzUiVkkB=uOgcAsDQ@mail.gmail.com' \
--to=masahiroy@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=msuchanek@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).