From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Ulf Magnusson <ulfalizer@gmail.com>
Cc: Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Sam Ravnborg <sam@ravnborg.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kconfig: Warn if there is more than one help text
Date: Sat, 13 Jan 2018 22:18:57 +0900 [thread overview]
Message-ID: <CAK7LNAT0jJ7mj6_ZWCprK5wHp5-FRoBhaUxxwO_x23PO+XU-gQ@mail.gmail.com> (raw)
In-Reply-To: <20180112064747.22854-1-ulfalizer@gmail.com>
2018-01-12 15:47 GMT+09:00 Ulf Magnusson <ulfalizer@gmail.com>:
> Avoids mistakes like in the following real-world example, where only the
> final help string ("Say Y...") was used. This particular example was
> fixed in commit 561b29e4ec8d ("media: fix media Kconfig help syntax
> issues").
>
> config DVB_NETUP_UNIDVB
> ...
> select DVB_CXD2841ER if MEDIA_SUBDRV_AUTOSELECT
> ---help---
> Support for NetUP PCI express Universal DVB card.
> help
> Say Y when you want to support NetUP Dual Universal DVB card
> ...
>
> This now prints the following warning:
>
> drivers/media/pci/netup_unidvb:13: warning: 'DVB_NETUP_UNIDVB' defined with more than one help text -- only the last one will be used
>
> Also free() any extra help strings.
>
> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
> ---
Applied to linux-kbuild/kconfig
replacing "kconfig: Don't leak help strings during parsing"
Thanks!
--
Best Regards
Masahiro Yamada
prev parent reply other threads:[~2018-01-13 13:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-12 6:47 [PATCH] kconfig: Warn if there is more than one help text Ulf Magnusson
2018-01-13 13:18 ` Masahiro Yamada [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNAT0jJ7mj6_ZWCprK5wHp5-FRoBhaUxxwO_x23PO+XU-gQ@mail.gmail.com \
--to=yamada.masahiro@socionext.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=ulfalizer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).