From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6E28C54EBE for ; Sat, 7 Jan 2023 09:10:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231389AbjAGJKa (ORCPT ); Sat, 7 Jan 2023 04:10:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229475AbjAGJK2 (ORCPT ); Sat, 7 Jan 2023 04:10:28 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CAB19271A7; Sat, 7 Jan 2023 01:10:27 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5AE34609FB; Sat, 7 Jan 2023 09:10:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B3D6BC433F0; Sat, 7 Jan 2023 09:10:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673082626; bh=IBB4vS9uXFcRA5vbIOpEIyUnvisvZwkqPn9Sb1Psd/E=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ppMRysQWQN03Z7wpwi3vlzb66/WBwSqtJiTO7+Uoaa4xEfOJfhWqTqKevE+06AMs/ TyQwRzcX5X3FQ2S+h/s0U8CDyNBpVsPi1BPzA7VJbaufr+Q1gfuZKMts2blyiEE0Ug WwnZ32r1b8IRcfZqPR5S83nMC6jxtD6ToBfj0netvBYB8/Pv+piXsVYHm9YKMBLBqZ lJnZl9GUvleKl9TlA4thg5PrX22UnwpSkQGsZ7CP8J2oQUENp8Stxi3mx5JGTY3+Pg PBPEp8+ZfwDdMRFbjW/Vh1ihT97RYQ3KRi9Y9Al2jUjsGNCpBS0L2bWbhOFYngL5Pf 6L4b4iaxQVHXw== Received: by mail-ot1-f46.google.com with SMTP id r2-20020a9d7cc2000000b006718a7f7fbaso2264088otn.2; Sat, 07 Jan 2023 01:10:26 -0800 (PST) X-Gm-Message-State: AFqh2kozTnXskRRHi96JnMTIvFvZDG2GUwK7uXu+oF+eff/0BfGC7dtK hqR7X464q6F7eTUQE9uUrIxvOTesPftUc8ZoDHA= X-Google-Smtp-Source: AMrXdXuWtj+rWB/s6w4ffQZ35ddawNN5ZxJS3aZYJbk/c2fIqmUiiMaTwh5RfwH7fXDlq+d4890py22AWrj/Cm7q+20= X-Received: by 2002:a9d:128c:0:b0:66c:794e:f8c6 with SMTP id g12-20020a9d128c000000b0066c794ef8c6mr3619042otg.343.1673082625996; Sat, 07 Jan 2023 01:10:25 -0800 (PST) MIME-Version: 1.0 References: <20221231064203.1623793-1-masahiroy@kernel.org> <20221231064203.1623793-2-masahiroy@kernel.org> In-Reply-To: From: Masahiro Yamada Date: Sat, 7 Jan 2023 18:09:49 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/6] kbuild: specify output names separately for each emission type from rustc To: Miguel Ojeda Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Miguel Ojeda , Alex Gaynor , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Boqun Feng , Gary Guo , Nathan Chancellor , Nick Desaulniers , Nicolas Schier , Tom Rix , Wedson Almeida Filho , llvm@lists.linux.dev, rust-for-linux@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 4, 2023 at 5:45 AM Miguel Ojeda wrote: > > On Sat, Dec 31, 2022 at 7:42 AM Masahiro Yamada wrote: > > > > $ make -j$(nproc) samples/rust/rust_minimal.o samples/rust/rust_minimal.rsi \ > > samples/rust/rust_minimal.s samples/rust/rust_minimal.ll > > Yeah, we were testing the single targets, but not multiple at once, thanks! > > > + --emit=dep-info=$(depfile) --emit=obj=$@ --emit=metadata=$(dir $@)$(patsubst %.o,lib%.rmeta,$(notdir $@)) \ > > Perhaps a newline here to avoid the lengthy line? OK, I will wrap it in v2. > > > hostc_flags = -Wp,-MMD,$(depfile) $(_hostc_flags) > > hostcxx_flags = -Wp,-MMD,$(depfile) $(_hostcxx_flags) > > -hostrust_flags = $(_hostrust_flags) > > This was originally meant to be consistent with C and C++ indeed, but > if you prefer less variables, I guess it is fine, in which case, > should we update the C/C++ side too (in another series)? Yup, we could do this with less variables. I will send a clean up. > Reviewed-by: Miguel Ojeda > Tested-by: Miguel Ojeda > > Cheers, > Miguel -- Best Regards Masahiro Yamada